My small definitions page

PurpleMonkey

Hello.

This is a small website thingumy I put together for my 'AS level computing' course. The code I've re-used from other bits of code I've written. Features:

Regular expressions to find other terms highlighted in the site
Sorting algorithm to show ten results per page

It didn't take me long to make, anyway heres the link:

www.teamsbas.co.uk/terms

Comments/Critique welcome!

planetsim

You maybe should make it a unique counter, so far im counted as two people.

PurpleMonkey

That would require more programming, its finnished, and thats that.

planetsim

Well then your counter is inaccurate.. Also i believe this is a code critique not a site critique.

LordShryku

As far as a site goes, you need work too. You don't follow any W3C standard.

planetsim

well that would require more programming i did believe he said he was finished. Maybe this thread should be resolved ?

LordShryku

Good point. What's the point of comments and crtique if you don't plan to listen to any of them?

PurpleMonkey

Thats not what I meant. All I'm saying is that for this project, I've finnished with it. I'm happy for people point out ways for me to improve my programming for future projects I do.

You don't follow any W3C standard

Not that bothered about this myself as this is only a hobby.

LordShryku

Ok, but your markup is so blatantly wrong, that some portions might never work. Like putting scripts above your html...

<script>
function winClose() {
window.close();
}
</script>
<link rel="StyleSheet" type="text/css" href="css/style.css">
<html><head><title>Flashsoup - ASCII</title></head>
<script>
function winClose() {
window.close();
}
</script>
<link rel="StyleSheet" type="text/css" href="../css/style.css">
<body bgcolor=#cccccc>
 <img src="images/math.gif"> <b>ASCII</b> - Stands for 'American standard code for 
information interchange' this is a 8bit 
binary system used for the representation and
storage of inputed keyboard characters.<p>
<a href="javascript:winClose()">Close</a>

</body></html>

BuzzLY

First... if you truly want people to critique your work, then don't respond with "I can't be bothered with that since this project is done." The suggestions made were valid, regardless of whether or not you intend to implement them.

Second... if you want your PHP code critiqued, which is what this forum is for, then post a link to your code. You can save it as a .phps file on your server, then post a link to that phps file. If you DON'T want your code looked at, and all you want is a critique of your site, then you are in the wrong forum. This forum is for PHP Code critique only.

PurpleMonkey

I agree, I wouldn't normally of done it this way, but I only had two nights to get it working in. I'de actually re-used parts of my code from other scripts, where I was doing this:

<html><head><title>Pop-up Windows Source</title></head>
<script>
function winClose() {
window.close();
}
</script>
<link rel="StyleSheet" type="text/css" href="../css/style.css">
<body>
<?php

selection statements detailing my includes

?>
</body></html>

Which is how the origional worked, but I mainly just cut and pasted the code due to lack of time.

PurpleMonkey

Originally posted by BuzzLY
First... if you truly want people to critique your work, then don't respond with "I can't be bothered with that since this project is done." The suggestions made were valid, regardless of whether or not you intend to implement them.

Second... if you want your PHP code critiqued, which is what this forum is for, then post a link to your code. You can save it as a .phps file on your server, then post a link to that phps file. If you DON'T want your code looked at, and all you want is a critique of your site, then you are in the wrong forum. This forum is for PHP Code critique only.

I can't say sorry enough times!

I'll upload the source and give you a link to it, give me a second...

Had to do it DreamWeaver thanks to ISS:

www.teamsbas.co.uk/terms/source.html

BuzzLY

Sure you can! Come on, I know you can do it... "I'm sorry." Now write it 1000 more times. And no using a loop!

PurpleMonkey

aww and I was going to do it like this:

$i=0;
while( $i < 1001 ) {

 $msg.="I\'m sorry, please forgive me!!!<br>\n";
 $i++;
} echo($msg);

planetsim

no loops 😃 also no copy and paste we are clever people we will know 😃

tekky

Hehe, hope your teacher doesnt take off for spelling mistakes in comments.... 😃

<?php
#hits toaliser.

PurpleMonkey

If she did then I'de never get anywhere!

Shrike

Is recursion allowed? 🙂

function wibble($i){
  if($i < 100){
    ++$i;
    print("I'm so sorry for this geek joke.");
    wibble($i);
  }else{
    die("Dieeeeeeee!");
  }
}
wibble(0);

PurpleMonkey

function very_funny($i=3) {

 for($x=0; $x<$i; $x++) {

  echo("\n<br> Don't dis geek jokes");

 }

}
very_funny(1338);

onion2k

str_repeat("I'm sorry\n",1000);

Damn newbies.