Two Nagging Problems

eggoz

I am working on a creating a small "picture server" if you will. It is broken into 2 parts, one shows you the dirs, and the other creates a table with the pictures. On the second page, I have ran into 2 problems, both tied together. The file in txt format The problem lies in the $td, half way down the page. The $dir_new and %s are the problem.

The odd part (to me atleast) is that the $dir_new works when I am not inside the function. And the %s works when you only have 1 %s in the $td.
I am stumped. Thanks for the help.

tekky

well you are more likely to get help if people can read your code here... reather than going out of their way to view it......

<html>
<head><title>Process all files</title></head>
<body>

<?php
$exit_test = "$exit";
//echo $exit;
$full_name = "$exit_test";
$dir_new = basename($full_name);
print "<h1>$dir_new</h1><hr>";
//Open Dir
//$dir = opendir('./') or die($php_errormsg);
$dir = opendir($exit_test) or die($php_errormsg);
        while (false !== ($files =readdir($dir))) {
	if ('.' == ($files)) {
		continue;
	}
	if ('..' == ($files)) {
		continue;
	}
	if (is_file($files)) {
		continue;
	}
        $file[$x++] = $files;
       }
closedir($dir);

foreach($file as $filenum => $filename)
{
	//print "$filenum  $filename <p>\n";

}


//Create Array 15
$files = array();

//Create Table
function pc_grid_horizontal($array, $size) {

$table_width = 100;
$width = intval($table_width / $size);

$tr = '<tr align="center">';
$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus Camedia/$dir_new/%s\" target=\"window\"><img=\"pictures/Olympus Camedia/$dir_new/%s\"><br>pic</a><br></td>";

$grid = "<table width=\"$table_width%\" style=\"table_style\">$tr";

$i = 0;
foreach ($array as $e) {
	$grid .= sprintf($td, $e);
	$i++;

if (!($i % $size)) {
    	$grid .= "</tr>$tr";
    }
}

while ($i % $size) {
        $grid .= sprintf($td, '&nbsp;');
        $i++;
}

$end_tr_len = strlen($tr) * -1;
if (substr($grid, $end_tr_len) != $tr) {
        $grid .= '</tr>';
} else {
        $grid = substr($grid, 0, $end_tr_len);
}

$grid .= '</table>';

return $grid;
}

$grid = pc_grid_horizontal($file, 5);

print $grid;

?>

tekky

the reason behind the %s not working if more than one are in the variable is because sprintf replaces them in the order of the variables supplied to replace them with.... if you only have one argument to insert into %s then only the first is replaced....

otherwise you need to use str_replace($td,'%s',' ');

regarding the $dir_new... I'm still looking at that...

what are you expecint $dir_new to be set as? using base_name() you would have a filename.... looking at your code... you are expecting a dirname....

eggoz

I am expecting a dir name. For example, my pictures are located in /pictures/Olympus Camedia/Folder1. $dir_new should point to Folder1, changing as needed. Then when it displays the picture, the full link would be /pictures/Olympus Camedia/Folder1/picture1.jpg. Thanks.

eggoz

Can you explain something to me? When I use basename in the beginning of the script I get the folder name, which is what I am looking for. But when I use, dirname, I get the whole path which isn't what I am looking for. All I am looking for is the parent directory. Also, I set the variable $dir_new to display the directory, why won't it pass when I enter the function?

As much as I am trying to learn, I have gotten so fustrated, that I much rather just pass the variable into the function and not know why it works.

tekky

inside the function you need to do

global $variable_name;

to make an outside variable available inside the functions

eggoz

foreach ($array as $e) {
$grid .= str_replace('%s', $e, $td);
$i++;

    if (!($i % $size)) {
            $grid .= "</tr>$tr";
    }

}

Shouldn't this replace all %s with $e in the variable $td?

tekky

Yes it should...

eggoz

Sadly no. 🙁