I need code help

[junction99]

Hello all. I've been trying to figure out what I've done wrong in this code and I think I've looked at it too long to see what's not working right. Please help. Thanks to any who are willing to help out.

Here it is:

<?php
  $message = '<font color="red">The following errors occurred:<br><br>';
  $problem = FALSE;

  # Check for required firstName  
  if (strlen($_POST['firstName']) > 0){
   if (!eregi("^[[:alpha:]-']{2,}$"), stripslashes(trim($_POST['firstName']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid First Name.</li></ul>';
    }
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your First Name.</li></ul>';
   }

  # Check for required lastName
  if (strlen($_POST['lastName']) > 0){
   if (!eregi("^[[:alpha:]-']{2,}$"), stripslashes(trim($_POST['lastName']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Last Name.</li></ul>';
    }
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your Last Name.</li></ul>';
   }

  # Check for street
  if (strlen($_POST['street']) > 0){
   if (!eregi("^[[:alnum:][:blank:]-.']{4,}$"), stripslashes(trim($_POST['street']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Street Address.</li></ul>';
    }
   }

  # Check for city 
  if (strlen($_POST['city']) > 0){
   if (!eregi("^[[:alpha:][:blank:]-.']{2,}$"), stripslashes(trim($_POST['city']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid City.</li></ul>';
   }
  }

  # Check for state 
  if (strlen($_POST['state']) > 0){
   if (!eregi("[AL][AK][AS][AZ][AR][CA][CO][CT][DE][DC][FM][FL][GA][GU][HI][ID][IL][IN][IA][KS][KY][LA][MA][MD][ME][MH][MI][MN][MO][MS][MT][NE][NH][NV][NJ][NM][NY][NC][ND][MP][OH][OK][OR][PW][PA][PR][RI][SC][SD][TN][TX][UT][VT][VI][VA][WA][WV][WI][WY]"), stripslashes(trim($_POST['state']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid State.</li></ul>';
   }
  }

  # Check for zip
  if (strlen($_POST['zip']) > 0){
   if (!eregi("^([0-9]{5})(-[0-9]{4})?$"), stripslashes(trim($_POST['zip']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Zip.</li></ul>';
   }
  }

  # Check for phone
  if (strlen($_POST['phone']) > 0){
   if (!eregi("^([0-9]{3})(-[0-9]{3})(-[0-9]{4}$"), stripslashes(trim($_POST['phone']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Phone Number.</li></ul>';
   }
  }

  # Check for required e-mail 
  if (strlen($_POST['email']) > 0){
   if (!eregi("^[[:alnum:]][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,4}$"), stripslashes(trim($_POST['email']))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid E-mail Address.</li></ul>';
   } else {
   $email = eregi_replace("^[[:alnum:][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,4}$", '<a href="mailto:'$email'">E-mail</a>', stripslashes(trim($_POST['email'])))){
   } 
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your E-mail Address.</li></ul>';
  }

  # Check for required comments 
  if (strlen($_POST['comments']) > 0){
  } else {
  $problem = TRUE;
  $message .= '<ul><li>Please Enter Your Comments.</li></ul>';
  }

  if ($_POST['noCom'] > NULL) {
   $com = "Checked";
   } else $com = "Not Checked";

 if (!$problem){
  echo "<center><strong>Please check your information.</strong></center><br><br>";
  echo '<form action="http://www.arrowcontracting.com/mail.php">';
  echo "First Name: <b>($_POST['firstName'])</b><br>";
  echo "<input type=\"hidden\" name=\"firstName\" value=\"$_POST['firstName']\">";
  echo "Last Name: <b>($_POST['lastName'])</b><br><br>";
  echo "<input type=\"hidden\" name=\"lastName\" value=\"$_POST['lastName']\">";

  if (strlen($street) > 0){
    echo "Street: <b>$street</b><br>";
	echo "<input type=\"hidden\" name=\"street\" value=\"$_POST['street']\">";
   }

  if (strlen($city]) > 0){
    echo "City: <b>$city</b>&nbsp;&nbsp;&nbsp;&nbsp;";
	echo "<input type=\"hidden\" name=\"city\" value=\"$_POST['city']\">";
   }

  if (strlen($state) > 0){
    echo "State: <b>$state</b>&nbsp;&nbsp;&nbsp;&nbsp;";
	echo "<input type=\"hidden\" name=\"state\" value=\"$_POST['state']\">";
   }

  if (strlen($zip) > 0){
    echo "Zip: <b>$zip</b>";
	echo "<input type=\"hidden\" name=\"zip\" value=\"$_POST['zip']\">";
   }

  echo "<br><br>";

  if (strlen($phone) > 0){
   echo "Phone: <b>$phone</b><br><br>";
   echo "<input type=\"hidden\" name=\"phone\" value=\"$_POST['phone']\">";
   }

  echo "E-mail: <b>($_POST['email'])</b><br>";
  echo "<input type=\"hidden\" name=\"email\" value=\"$_POST['email']\">";
  echo '"I do not wish to receive communications from ArrowContracting.com": $com';
  echo "<input type=\"hidden\" name=\"com\" value=\"$_POST['com']\">";
  echo '<br><br><input type="button" value="&nbsp;Back&nbsp;" onClick="history.back()">&nbsp;&nbsp;&nbsp;&nbsp;<input type="submit" value="&nbsp;Submit&nbsp;"></form>';
 } else {
  echo $message;
  echo '</font><br><br><strong>Please go back and try again</strong><br><br><br>';
  echo '<form><input type="button" value="&nbsp;Back&nbsp;" onClick="history.back()"></form>';
 }

?>

I hope you guys can help me out.

[tekky]

it would be wise to actually say what you need help with... even I cant always read minds and tell what exactly you're expecting your code to do....

[LordShryku]

Geesh. Now we need a new stand in telepath :p

[tekky]

Originally posted by LordShryku
Geesh. Now we need a new stand in telepath :p

Hey now! I'm just a temp who got stuck with the job! 🙁
you try being a mind reader sometime! :rolleyes:
😃

[junction99]

Thanks Bevis and Butthead. I did tell you what I need. I need someone who knows PHP code to check mine (e.g. syntax ). Thanks agian. By the way keep up the quick comments they make life funny.

[LordShryku]

Well....if that's it....

I know php code, and yes, that looks like php code. Good job! :rolleyes:

[tekky]

Hmm so am I Beavis or are you Shryku?

Inregards to syntax, a quick glance at the PHP tag syntax hiliting thing-a-ma-bob they use here.... everything appears to be syntax'd correctly... posting code w/o giving what problems you have is generally... unproductive to say the least.... We have no idea where to start looking for a problem... and we have lifes/jobs of our own, so our time is still money, even if it's not your money we're getting by helping you 😉

[LordShryku]

Originally posted by tekky
Hmm so am I Beavis or are you Shryku?

Well, everyone else is south park characters, so this is fitting. I think I'm Butthead. I think junction99 will have to tell us...

[junction99]

OK I give up. I don't know if this is what you want to know or not but here goes.

This code was written for preprossesing forms from my site. I have a form on a different page that I use the POST method to send the info received from the form inputs. The action of the form points to a new page with this code in it. This block of code is supposed to check the variables sent by the previous page and return error messages if needed. Otherwise it will print out the results of the form and ask the user to double check the info entered. Once all the required info is submitted and it passes the tests from this code it is then passed to a new page to mail the info to me. I hope this is what you are looking for. Otherwise keep asking for more info.

Thanks

[tekky]

Originally posted by LordShryku
Well, everyone else is south park characters, so this is fitting. I think I'm Butthead. I think junction99 will have to tell us...

Yah... we can be special! heeeheee

Originally posted by junction99
I hope this is what you are looking for. Otherwise keep asking for more info.

getting there... we now know what we are looking at (without wasting alot of time translating it) -- however you have still failed to inform us of a problem with this code....
does it validate everything good regardles... does it display naked pictures of family members instead of the form info? 😕

[edit: any idea where I could find a pic of Beavis with a turban on his head? (whole telepath thing ya know... :p) --]

[junction99]

The problem is that I'm not getting anything when I hit the submit button from the form on the previous page. Just a blank page. No error messages telling me what line doesn't work. Nothing.

That's why I was thinking that something is wrong in the syntax and asking someone to check it out.

[tekky]

Originally posted by junction99
The problem is that I'm not getting anything when I hit the submit button from the form on the previous page. Just a blank page. No error messages telling me what line doesn't work. Nothing.

That's why I was thinking that something is wrong in the syntax and asking someone to check it out.

Ahah! Now you're cooking with propane! Now someone has the information they need to help ya...

good luck finding someone to help now

j/k :p I'll see what I can dig out of it

[junction99]

You guys are fun. I've enjoyed all 5 posts so far. Thanks for not being uptight.

[tekky]

first step of debugging....

echo '<pre>'. print_r($_POST) .'</pre>';

second step...
validate that all your ereg's are working properly...

I would recommend setting up a seperate page with a form for that allows you to input an EREG expression AND another input for "value to check against EREG" and make it submit and check each of those inputs....

(thats how I validate my eregs when I rarely use them....)

[junction99]

OK I've checked to make sure that I'm getting the variables and that worked just like it should. I'll try testing the eregi's next.

[tekky]

your echos like this...

echo "<input type=\"hidden\" name=\"com\" value=\"$_POST['com']\">"; 

could be the problem....

try doing...

echo '<input type="hidden" name="com" value="' .$_POST['com']. '">'; 

I seem to recall that arrays dont work too well in being evaluated inline.... I always concatenate them myself...

[edit: lunch time... back in a while :p --]

[junction99]

I caught that about 20 minutes ago and fixed that but I'm still having the same problems.

[tekky]

post your current code then since you've changed it :p

[junction99]

Well I'm testing my eregi's and they seem to work fine. It seems that the variables aren't working correctly. I haven't been able to pin point it yet though.

Here is the revised code so far:

<?php

  $message = '<font color="red">The following errors occurred:<br><br>';
  $problem = FALSE;

  # Check for required firstName  
  if ($_POST['firstName']) > NULL){
   if (!eregi("^[[:alpha:]-']{2,}$"), stripslashes(trim($_POST['firstName'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid First Name.</li></ul>';
    }
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your First Name.</li></ul>';
   }

  # Check for required lastName
  if ($_POST['lastName']) > NULL){
   if (!eregi("^[[:alpha:]-']{2,}$"), stripslashes(trim($_POST['lastName'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Last Name.</li></ul>';
    }
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your Last Name.</li></ul>';
   }

  # Check for street
  if ($_POST['street']) > NULL){
   if (!eregi("^[[:alnum:][:blank:]-.']{4,}$"), stripslashes(trim($_POST['street'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Street Address.</li></ul>';
    }
   }

  # Check for city 
  if ($_POST['city']) > NULL){
   if (!eregi("^[[:alpha:][:blank:]-.']{2,}$"), stripslashes(trim($_POST['city'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid City.</li></ul>';
   }
  }

  # Check for state 
  if ($_POST['state']) > NULL){
   if (!eregi("[AL][AK][AS][AZ][AR][CA][CO][CT][DE][DC][FM][FL][GA][GU][HI][ID][IL][IN][IA][KS][KY][LA][MA][MD][ME][MH][MI][MN][MO][MS][MT][NE][NH][NV][NJ][NM][NY][NC][ND][MP][OH][OK][OR][PW][PA][PR][RI][SC][SD][TN][TX][UT][VT][VI][VA][WA][WV][WI][WY]"), stripslashes(trim($_POST['state'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid State.</li></ul>';
   }
  }

  # Check for zip
  if ($_POST['zip']) > NULL){
   if (!eregi("^([0-9]{5})(-[0-9]{4})?$"), stripslashes(trim($_POST['zip'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Zip.</li></ul>';
   }
  }

  # Check for phone
  if ($_POST['phone']) > NULL){
   if (!eregi("^([0-9]{3})(-[0-9]{3})(-[0-9]{4}$"), stripslashes(trim($_POST['phone'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid Phone Number.</li></ul>';
   }
  }

  # Check for required e-mail 
  if ($_POST['email']) > NULL){
   if (!eregi("^[[:alnum:]][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,4}$"), stripslashes(trim($_POST['email'])))){
    $problem = TRUE;
    $message .= '<ul><li>Please Enter A Valid E-mail Address.</li></ul>';
   } else {
   $email = eregi_replace("^[[:alnum:][a-z0-9_.-]*@[a-z0-9.-]+\.[a-z]{2,4}$", '<a href="mailto:'$email'">E-mail</a>', ($_POST['email'])))){
   } 
  } else {
   $problem = TRUE;
   $message .= '<ul><li>Please Enter Your E-mail Address.</li></ul>';
  }

  # Check for required comments 
  if ($_POST['comments']) > NULL){
  } else {
  $problem = TRUE;
  $message .= '<ul><li>Please Enter Your Comments.</li></ul>';
  }

  if ($_POST['noCom'] > NULL){
   $com = "Checked";
   } else $com = "Not Checked";

 if (!$problem){
  echo "<center><strong>Please check your information.</strong></center><br><br>";
  echo '<form action="http://www.arrowcontracting.com/mail.php">';
  echo "First Name: <b>($_POST['firstName'])</b><br>";
  echo '<input type="hidden" name="com" value="'$_POST['firstName']'">';
  echo "Last Name: <b>($_POST['lastName'])</b><br><br>";
  echo '<input type="hidden" name="com" value="'$_POST['lastName']'">';

  if ($street > NULL){
    echo "Street: <b>$street</b><br>";
  echo '<input type="hidden" name="com" value="'$_POST['street']'">';
   }

  if ($city > NULL){
    echo "City: <b>$city</b>&nbsp;&nbsp;&nbsp;&nbsp;";
  echo '<input type="hidden" name="com" value="'$_POST['city']'">';
   }

  if ($state > NULL){
    echo "State: <b>$state</b>&nbsp;&nbsp;&nbsp;&nbsp;";
  echo '<input type="hidden" name="com" value="'$_POST['state']'">';
   }

  if ($zip > NULL){
    echo "Zip: <b>$zip</b>";
  echo '<input type="hidden" name="com" value="'$_POST['zip']'">';
   }

  echo "<br><br>";

  if ($phone > NULL){
   echo "Phone: <b>$phone</b><br><br>";
  echo '<input type="hidden" name="com" value="'$_POST['phone']'">';
   }

  echo "E-mail: <b>($_POST['email'])</b><br>";
  echo '<input type="hidden" name="com" value="'$_POST[email]'">';
  echo '"I do not wish to receive communications from ArrowContracting.com": $com';
  echo '<input type="hidden" name="com" value="'$_POST[com]'">';
  echo '<br><br><input type="button" value="&nbsp;Back&nbsp;" onClick="history.back()">&nbsp;&nbsp;&nbsp;&nbsp;<input type="submit" value="&nbsp;Submit&nbsp;"></form>';
 } else {
  echo $message;
  echo '</font><br><br><strong>Please go back and try again</strong><br><br><br>';
  echo '<form><input type="button" value="&nbsp;Back&nbsp;" onClick="history.back()"></form>';
 }

?>

[tekky]

did you determine that you didn NOT have to concatenate the $POST['state'] variables, but could get away with $var = "some string=$POST['state']" ?

also you may want to encapsulate all your $_POST array keys with 'single quotes' just to ensure you pull the right data, generally its not a problem but in rare occasions it can cause issues not quoting the keys