str_replace problem

eggoz

I am working on a picture gallery and I have ran into a small problem. I admit, I took part of this code from a book and modified it. Now I having trouble with it and it's twice as hard to fix.

http://php.imagiro-1.com/Pictures You can see what I have so far. When you click on a link, it should show you thumbnails of the pictures. And some pages have errors.

And here my code:

<html>
<head><title>Process all files</title></head>
<body>
<?php
$exit_test = "$exit";
//echo $exit;
$full_name = "$exit_test";
$dir_new = basename($full_name);
//session_register ("dir_new");
print "<h1>$dir_new</h1><br><hr>";
//echo $dir_final;
//Open Dir
//$dir = opendir('./') or die($php_errormsg);
$dir = opendir($exit_test) or die($php_errormsg);
        while (false !== ($files =readdir($dir))) {
	if ('.' == ($files)) {
		continue;
	}
	if ('..' == ($files)) {
		continue;
	}
	if (is_file($files)) {
		continue;
	}
        $file[$x++] = $files;
       }
closedir($dir);

foreach($file as $filenum => $filename)
{
	//print "$filenum  $filename <p>\n";

}


//Create Array 15
$files = array();

//Create Table
function pc_grid_horizontal($array, $size, $dir_final) {

$table_width = 100;
$width = intval($table_width / $size);

$tr = '<tr align="center">';
$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus Camedia/$dir_final/%s\" target=\"window\"><img=\"pictures/Olympus Camedia/$dir_final/%s\"><br>pic</a></td>";

$grid = "<table width=\"$table_width%\" style=\"table_style\">$tr";

$i = 0;
foreach ($array as $e) {
	$grid .= str_replace('%s', $e, $td);
	$i++;

if (!($i % $size)) {
    	$grid .= "</tr>$tr";
    }
}

while ($i % $size) {
        $grid .= sprintf($td, '&nbsp;');
        $i++;
}

$end_tr_len = strlen($tr) * -1;
if (substr($grid, $end_tr_len) != $tr) {
        $grid .= '</tr>';
} else {
        $grid = substr($grid, 0, $end_tr_len);
}

$grid .= '</table>';

return $grid;
}

$grid = pc_grid_horizontal($file, 5, $dir_new);

print $grid;

?>

This all started when I changed the str_replace. Before it was sprintf, but I need to replace all the %s with $e. Where am I going wrong?

bubblenut

Why not keep it sprintf?
$grid .= sprintf($td, $e, $e);

eggoz

Tried that. Still doesn't show the pictures.

bubblenut

In the following line are the two percentage just after $width necesary?

$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus Camedia/$dir_final/%s\" target=\"window\"><img=\"pictures/Olympus Camedia/$dir_final/%s\"><br>pic</a></td>";

They're throwing sprintf because it uses the percentage sign as a place holder. You can either remove them or escape them with backslashes.

eggoz

Fixed that and now the whole pages doesn't work. I thought there should be two % so that php will know it's followed by a percent sign? I could be wrong.

eggoz

Here is something else I noticed. If take a look at the page now you will see that it shows the files in a list format. But if you look carefully, before the numbers begin, there is an extra file. This isn't a file, it is a folder. I need to fix that. Could that cause a problem since it's trying to load a picture for a dir?

bubblenut

:o Sorry, yes you're right. I thought that line was line 60 when in fact it's this line

$grid .= sprintf($td, '&nbsp;');

and it needs another paramter to make it

$grid .= sprintf($td, '&nbsp;','&nbsp');

That will get rid of the warning but it won't show the image.
I think the problem there may be the spaces in the url. To solve this it may be better to urlencode the image paths before they're added.

//change this line
$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus Camedia/$dir_final/%s\" target=\"window\"><img=\"pictures/Olympus Camedia/$dir_final/%s\"><br>pic</a></td>";
//to
$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus%%20Camedia/$dir_final/%s\" target=\"window\"><img=\"pictures/Olympus%%20Camedia/$dir_final/%s\"><br>pic</a></td>";

//and this line
$grid .= sprintf($td, $e, $e);
//to
$grid .= sprintf($td, urlencode($e), urlencode($e));

HTH
Bubble

eggoz

Nope still no good.

Here is my updated code.

<html>
<head><title>Process all files</title></head>
<body>
<?php

$exit_test = "$exit";
$full_name = "$exit_test";
$dir_new = basename($full_name);
print "<h1>$dir_new</h1><hr>";

//Open Dir

$dir = opendir($exit) or die($php_errormsg);
        while (false !== ($files =readdir($dir))) {
	if ('.' == ($files)) {
		continue;
	}
	if ('..' == ($files)) {
		continue;
	}
	if (is_file($files)) {
		continue;
	}
        $file[$x++] = $files;
       }
closedir($dir);

foreach($file as $filenum => $filename)
{
	print "$filenum  $filename <p>\n";

}


//Create Array 15
$files = array();

//Create Table
function pc_grid_horizontal($array, $size, $dir_final) {

$table_width = 100;
$width = intval($table_width / $size);

$tr = '<tr align="center">';
$td = "<td width=\"$width%%\"><a href=\"pictures/Olympus%%20Camedia/$dir_final/%s\" target=\"window\"><img=\"pictures/Olympus%%20Camedia/$dir_final/%s\"><br>%s</a></td>";

$grid = "<table width=\"$table_width%\" style=\"table_style\">$tr";

$i = 0;
foreach ($array as $e) {
	$grid .= sprintf($td, urlencode($e), urlencode($e), urlencode($e));
	$i++;

if (!($i % $size)) {
    	$grid .= "</tr>$tr";
    }
}

while ($i % $size) {
        $grid .= sprintf($td, '&nbsp;', '&nbsp;', '&nbsp');
        $i++;
}

$end_tr_len = strlen($tr) * -1;
if (substr($grid, $end_tr_len) != $tr) {
        $grid .= '</tr>';
} else {
        $grid = substr($grid, 0, $end_tr_len);
}

$grid .= '</table>';

return $grid;
}

$grid = pc_grid_horizontal($file, 5, $dir_new);

print $grid;

?>
</body>
</html>

Two things I have noticed. One, if you take a look at the main page, under the directories I have it so you can see the arry. The first picture isn't numbered. I don't know if that even matters. I am also beginning to think this doesn't have anything to do with the php. Take a look at this page . This is the source code that my brower sees, copied, and made into a webpage. The picture still isn't there. And finally if you go to this page again, the picture isn't visable, yet the link works. Now I'm really confused.

bubblenut

Aha, you're right, the problem's not in your php it's in your html syntax. The syntax for the img tag is <img src="/link/to/img.jpg" /> not <img="/link/to/img.jpg">

HTH
Bubble

eggoz

I don't think I'll ever stop kicking myself for something like that.