Not inserting into database

[Dillenger]

Can someone tell me what I am doing wrong here?

I'm trying to check if the date is already in the database, and if it isn't, then I insert the new row, but it doesn't do anything...

$sql = "select * from archive_issue";

	$result = mysql_query($sql);

	while ($owners = mysql_fetch_array($result)) {

	$date2=$owners['date'];

	if ($date2 = $date){ }else{
	$SQL = " INSERT INTO archive_issue ";
	$SQL = $SQL . " (volume, issue, date) VALUES ";
	$SQL = $SQL . " ('$volume', '$issue', '$date')";
	$result3 = mysql_db_query($db,"$SQL",$connect);
	if (!$result3) {
	echo("ERROR: " . mysql_error() . "\n$SQL\n");
	}else{
	}
	}
	}

[bubblenut]

What the code you've written does is pull every entry in archive_issue table and then for each row check if the date in that row is the same as the date you have and if it not insert the details you have. This means that the new details will be inserted for every row in table that is not equal to the date supplied and none will be inserted if there is nothing in the table because it will never even enter the while loop. I understand this may be a little difficult to understand if you're new so I'll just go straight in and show the correct method and then explain it.

//select count all entried in archive_issue which have the 
//same date as that supplied ($date)
$sql="SELECT COUNT(*) FROM arhive_issue WHERE date='$date'";
$result = mysql_query($sql);
$row=mysql_fetch_array($result);
//check if there is already an entry
if($row[0]==0) { //there is not
  $sql="INSERT INTO archive_issue (volume, issue, date) VALUES ('$volume','$issue','$date')";
  if(!mysql_query($sql)) {
    echo("There was an error inserting");
  } else {
    echo("Inserted successfully");
} else {
  echo("There was already an entry for this date");
}

I think this is what you where trying to get at.
Bubble

[Dillenger]

thanks bubble,

i put that code in place though, and still nothing happens?

[bubblenut]

What output are you getting?

[Dillenger]

Oops, i uploaded the wrong file, but now I did the right one, and this is the error i get on the page:

Parse error: parse error in /home/dhill/public_html/database/admin/publish/south_permits.php on line 161

Line 161 is this : } else {

its the second else in your code

[Dillenger]

Ok, I semi fixed it, but now this is what I get?

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/dhill/public_html/database/admin/publish/south_permits.php on line 153
Inserted successfully

It inserts the data now, but its not doing the check properly, because i did it twice, and i have 2 of the same entry?

[bubblenut]

Ooops, I missed a closing brace (}) see if you can find it. It was a deliberate mistake to make things more fun for you, honest 😉

[bubblenut]

OK, there's a mysql error on the select statement. replace this line

$row=mysql_fetch_array($result); 

with this

$row=mysql_fetch_array($result) or die($sql.' : '.mysql_error()); 

HTH
Bubble

[Dillenger]

WOOHOO! that works now, the archive_issue was just spelt wrong 🙂

thank you SO much 🙂