PHP and Check boxes

[Will_742]

Ok well, I have a basic service script which asks a client what kind of service they want and so on, and it emails me the info, I have all that working, but I also have two checkboxes, one that asks the user if they want hosting with the service, and one that asks if they also want a domain. This is the problem that I am having, the form works correctly until a checkbox is clicked and submitted, the email is not submitted and the page comes back blank which it shouldn't because there should be an error message if the mail failed, but I am getting nothing at all. Well, here is my code:

To Order Our Services, Fill Out The Form Below!
<FORM method="POST" action="<? echo $_SERVER['PHP_SELF']; ?>">
<table>
<TR>
<TD>Name
<TD><INPUT TYPE="text" NAME="name"><br>
</TR>
<TR>
<TD>Service
<TD><INPUT TYPE="text" NAME="service"><br>
</TR>
<TR>
<TD>Description
<TD><TEXTAREA NAME="description" ROWS="5" COLS="35"></TEXTAREA><br>
</TR>
<TR>
<TD>Email
<TD><INPUT TYPE="text" NAME="email"><br>
</TR>
</table>
<a href="hosting.html">Hosting?</a><INPUT TYPE="checkbox" NAME="hosting">&nbsp;&nbsp;&nbsp;<a href="domain.html">Domain?</a><INPUT TYPE="checkbox" NAME="domain"><br>
<br>
<input type="submit" name="submit" value="Submit!">&nbsp;<INPUT TYPE="reset"><br><br>
</FORM>
</body>
</html>
<?php

if (isset($submit)) {
	if ($name == "") {
		echo "<font color=\"red\">Error : Please go back and insert a name.</font>";
		die();
	} else {
		if ($service == "") {
			echo "<font color=\"red\">Error : Please go back and insert a service.</font>";
			die();
		} else {
			if ($description == "") {
				echo "<font color=\"red\">Error : Please go back and insert a description.</font>";
				die();
			} else {
				if ($email == "") {
					echo "<font color=\"red\">Error : Please go back and insert an email address.</font>";
					die();
				} else {
					if (isset($hosting)) {
						$hosted = "Yes";
					} else {
						$hosted = "No";
						if (isset($domain)) {
							$dom = "Yes";
						} else {
							$dom = "No";
							$subject = "Service from Visual-Orgy";
							$line1 = "Name : $name";
							$line2 = "Service : $service";
							$line3 = "Description : $description";
							$line4 = "Email : $email";
							$line5 = "Hosting : $hosted";
							$line6 = "Domain : $dom";
							$line7 = "Please do not email back to this address, because it is just a script.";
							$mail = mail("[e-mail]", "$subject", "$line1\n\n$line2\n\n$line3\n\n$line4\n\n$line5\n\n$line6\n\n\n\n$line7","From: clients@{$_SERVER['SERVER_NAME']}\r\n" .
							"Reply-To: clients@{$_SERVER['SERVER_NAME']}\r\n" .
							"X-Mailer: PHP/" . phpversion());
							if ($mail) {
								echo "<font color=\"green\">Mail Sucessfully Sent!</font>";
							} else {
								echo "<font color=\"red\">Mail could not be sent!</font>";
							}
						}
					}
				}
			}
		}
	}
}

?>

To see an example, go here.

Any help greatly appreciated.

Thanks,
Will 🙂

[tuf-web_co_uk]

your problem lies here

<?
if (isset($hosting)) { 
                        $hosted = "Yes"; 
                    } else { 
                        $hosted = "No"; 
                        if (isset($domain)) { 
                            $dom = "Yes"; 
                        } else { 
                            $dom = "No"; 
                            $subject = "Service from Visual-Orgy"; 
                            $line1 = "Name
?>

the mail script will fail if u select hosting, because the mail script lies within the else of the if (isset($hosting)) statement, and the same with the if(isset($domain))

all you need to do is rearrange your script

take everything from $subject = "Service from Visual-Orgy";
to echo "<font color=\"red\">Mail could not be sent!</font>";
}
out of the else statement and place it outside the if(isset($hosting)) else

does that sound complicated? i'll show you, save us both time 🙂

To Order Our Services, Fill Out The Form Below! 
<FORM method="POST" action="<? echo $_SERVER['PHP_SELF']; ?>"> 
<table> 
<TR> 
<TD>Name 
<TD><INPUT TYPE="text" NAME="name"><br> 
</TR> 
<TR> 
<TD>Service 
<TD><INPUT TYPE="text" NAME="service"><br> 
</TR> 
<TR> 
<TD>Description 
<TD><TEXTAREA NAME="description" ROWS="5" COLS="35"></TEXTAREA><br> 
</TR> 
<TR> 
<TD>Email 
<TD><INPUT TYPE="text" NAME="email"><br> 
</TR> 
</table> 
<a href="hosting.html">Hosting?</a><INPUT TYPE="checkbox" NAME="hosting">&nbsp;&nbsp;&nbsp;<a href="domain.html">Domain?</a><INPUT TYPE="checkbox" NAME="domain"><br> 
<br> 
<input type="submit" name="submit" value="Submit!">&nbsp;<INPUT TYPE="reset"><br><br> 
</FORM> 
</body> 
</html> 
<?php 

if (isset($submit)) { 
    if ($name == "") { 
        echo "<font color=\"red\">Error : Please go back and insert a name.</font>"; 
        die(); 
    } else { 
        if ($service == "") { 
            echo "<font color=\"red\">Error : Please go back and insert a service.</font>"; 
            die(); 
        } else { 
            if ($description == "") { 
                echo "<font color=\"red\">Error : Please go back and insert a description.</font>"; 
                die(); 
            } else { 
                if ($email == "") { 
                    echo "<font color=\"red\">Error : Please go back and insert an email address.</font>"; 
                    die(); 
                } else { 
                    if (isset($hosting)) { 
                        $hosted = "Yes"; 
                    } else { 
                        $hosted = "No"; 
                        if (isset($domain)) { 
                            $dom = "Yes"; 
                        } else { 
                            $dom = "No"; 
                        } 
                    }

                $subject = "Service from Visual-Orgy"; 
                $line1 = "Name : $name"; 
                $line2 = "Service : $service"; 
                $line3 = "Description : $description"; 
                $line4 = "Email : $email"; 
                $line5 = "Hosting : $hosted"; 
                $line6 = "Domain : $dom"; 
                $line7 = "Please do not email back to this address, because it is just a script."; 
                $mail = mail("[e-mail]", "$subject", " $line1\n\n$line2\n\n$line3\n\n$line4\n\n$line5\n\n
$line6\n\n\n\n$line7","From: clients@{$_SERVER['SERVER_NAME']}\r\n" . 
                            "Reply-To: clients@{$_SERVER['SERVER_NAME']}\r\n" . 
                            "X-Mailer: PHP/" . phpversion()); 
                    if ($mail) { 
                    	echo "<font color=\"green\">Mail Sucessfully Sent!</font>"; 
                    } else { 
                    	echo "<font color=\"red\">Mail could not be sent!</font>"; 
                    } 
                } 
            } 
        } 
    } 
} 

?> 

hth

[Will_742]

Thank you, very much! But maybe you can help me with this problem. Whenever I leave 'hosting' unchecked it comes up blank in the email, but it works for domain? Hmm..

Help appreciated.
Thanks,
Will

[tuf-web_co_uk]

i think php fools with me sometimes

try changing

<?
if (isset($hosting)) {  

                        $hosted = "Yes";  

                    } else {  

                        $hosted = "No";  

                        if (isset($domain)) {  

                            $dom = "Yes";  

                        } else {  

                            $dom = "No";  

                        }  

                    }
?>

to

<?
if (isset($hosting)) {  

                        $hosted = "Yes";  

                    } else {  

                        $hosted = "No";
                    }
                        if (isset($domain)) {  

                            $dom = "Yes";  

                        } else {  

                            $dom = "No";  

                        }  

?>