writing a function

[Dutch_MaFia-boy]

I have a form and I want a warning message telling the user they have not inputted information in the form. I have done this before with the empty function, but I am kinda confused on how to incorporate that into the existing if/else code block I am using:

if ($totalqty == 0) {
echo "You did not fill in the order form";
} 
else
{
print '<p>Order processed at '. date("l dS of F Y h:i:s A") . '<p>';
echo '<p>Your order is as follows: <p>';
  if ($tireqty>0) 
  echo $tireqty.' tires<br />';
  if ($oilqty>0)
  echo $oilqty.' bottles of oil<br />';
  if (isset($sparkqty)) 
  echo $spark. 'spark plugs<br />'; 

1. So, is there a way to make this if/else statement work by adding the empty function so that it checks 3 things:
   a) to see if the data in the form isequal to 0 quantity
   b) to to see if the data in the form is above 0 quantity
   c) to see if a user inputted any data at all into the forms

AND

2. How would I do this solution using a function?

Thanks.

Adrian

[Strings]

You could create a function called 'checkQTY' and pass your quantity variables within the script that's processing your form like this:

function checkQTY($totalqty,$tireqty,$oilqty,$sparkqty)
{
 if ($totalqty == 0) {
 echo "You did not fill in the order form";
 } 
 else
 {
  print '<p>Order processed at '. date("l dS of F Y h:i:s A") . '<p>';
  echo '<p>Your order is as follows: <p>';
  if ($tireqty>0)
  { 
   echo $tireqty.' tires<br />';
  }
  if ($oilqty>0)
  {
  echo $oilqty.' bottles of oil<br />';
  }
  if (isset($sparkqty))
  { 
  echo $spark. 'spark plugs<br />';
  }
}

and then call the function like this, assuming your using html form elements with the following names:

checkQTY($_REQUEST['$totalqty'],$_REQUEST['$tireqty'],$_REQUEST['$oilqty'],$_REQUEST['$sparkqty']);

[mmilano]

i like to create a big long error string like this

<?
if($totalqty == 0){
  $error .= "<li> No QTY";
}
if($anotherfield == "") {
  $error .= "<li> No Other Field";
}
// keep validating till you are blue in the face

// if there is not error, then process data
if(!$error){
  // process data
}else{
  // otherwise, echo the errors .. 
  // or you could do it later in the page
  echo $error;
}
?>

[Dutch_MaFia-boy]

Thanks guys,

I'm trying to implement what Strings suggested. I have the function Strings gave me in a file called functions.php.

I am getting a parse error now on my variables:

$tireqty = $HTTP_POST_VARS['tireqty'];
$oilqty = $HTTP_POST_VARS['oilqty'];
$sparkqty = $HTTP_POST_VARS['sparkqty'];

Here is the whole file:

<?php
include functions.php  

$tireqty = $HTTP_POST_VARS['tireqty'];
$oilqty = $HTTP_POST_VARS['oilqty'];
$sparkqty = $HTTP_POST_VARS['sparkqty'];

$totalqty = 0;
$totalqty = $tireqty + $oilqty + $sparkqty;

// call the checkqty function from functions.php
checkqty($_REQUEST['$totalqty'],$_REQUEST['$tireqty'],$_REQUEST['$oilqty'],$_REQUEST['$sparkqty']); echo 'Items ordered: '.$totalqty.'<br />';

$totalamount = 0.00;

define('TIREPRICE', 100);
define('OILPRICE', 10);
define('SPARKPRICE', 4);

// echo TIREPRICE;

$totalamount = $tireqty * TIREPRICE
             + $oilqty * OILPRICE
             + $sparkqty * SPARKPRICE;

echo 'Subtotal: $'.number_format($totalamount,3).'<br />';

$taxrate = 0.10;
$totalamount = $totalamount * (1 + $taxrate);
echo 'Total Inclluding tax: $'.number_format($totalamount, 2).'<br />'; 

Do I have something in those variable that shouldn;t be there??

Thanks.

[lanjoky]

1 thing I see... havent looked at the whole file yet is

Where you have

include functions.php 

Try

include('functions.php');

HTH

[Dutch_MaFia-boy]

thanks lanjoky, I've included that in my file.

Unfortunatley, its still not working 100%. I hate it you get parse errors - and the code looks completely fine!!!!

I am getting these parse errors when the form is processed:

Parse error: parse error in /usr/local/apache/htdocs/functions.php on line 27

Fatal error: Call to undefined function: checkqty() in /usr/local/apache/htdocs/processorder.php on line 35

The first parse error is the closing php tag - no matter what line I put it on - that's the line that gets the parse error...

The second parse error is the calling my checkqty function -

checkqty($_REQUEST['$totalqty'],$_REQUEST['$tireqty'],$_REQUEST['$oilqty'],$_REQUEST['$sparkqty']);

So what the heck is going on? Is there like a phantom character somewhere??

thanks.

[ShawnK]

Well...in your file you call checkqty() but in your functions.php you name the function checkQTY() try changing that first. Look through functions.php because that's where one of your parse errors is from.

Also please post your current code so we can help you more.