Passing Variable In Url Problem !!

[ErocM]

I was hosting on a linux server and my site worked great! Went to a Windows server with php and everything, forums, etc work fine except for this:

    <?php 

// nothing included so include main.htm by default
if( $page == "" )
{
require("mymain.htm");
}
elseif( $page == "main" )
{
require("mymain.htm");
}
elseif( $page == "ranks" )
{
include("http://www.cnn.com");
}
elseif( $page == "rules" )
{
require("myrules.htm");
}    

elseif( $page == "pos" )
{
require("mypos.htm");
}

etc... it goes on for about 10 more...

I am calling this as such: http://www.9thsf.com/portal.php?page=rules

When I run it, it used to display that page inside my current one... now the only thing it displays is my mymain.htm. I tested this by changing the mymain.htm to cnn.com and cnn showed up. I can't get it to pass the page variable anymore and now most of my site links dont work!!!

Anyone tell me what the heck I am doing wrong?

My site is at www.9thsf.com if you need to see what I am talking about !

Thanks !!!
Eroc

[lilleman]

Maybe register_globals is disabled in the configuration for PHP? If that's the case, the code below should work for you:

<?php 

// check if page have been given
$page = isset($_GET['page']) ? $_GET['page'] : '';

// nothing included so include main.htm by default
if( $page == "" )
{
	require("mymain.htm");
}
elseif( $page == "main" )
{
	require("mymain.htm");
}
elseif( $page == "ranks" )
{
	include("http://www.cnn.com");
}
elseif( $page == "rules" )
{
	require("myrules.htm");
}    

elseif( $page == "pos" )
{
	require("mypos.htm");
}

?>

/ Erik

[ErocM]

That was it !!! That worked great !!!

Thank you so much, that's a life saver.

Btw, this is my web server, how do I go about turning on register_globals on the server?

Thanks again,
Eroc

[laserlight]

<?php 

// nothing included so include main.htm by default
if (!empty($_GET['page']))
{
	switch ($_GET['page'])
	{
	case "main":
		require "mymain.htm";
		break;
	case "ranks":
		require "http://www.cnn.com";
		break;
	case "rules":
		require "myrules.htm";
		break;
	case "pos":
		require "mypos.htm";
		break;
	default:
		require "mymain.htm";
	}
}
else
{
	require "mymain.htm";
}

Careful with the "http://www.cnn.com" thing.
You will probably need allow_url_fopen to be enabled (though it is by default).

As for the actual problem, that would be with register_globals.
Next time, also state your version of PHP.

[laserlight]

There is a reason why the default setting for register_globals was changed.

I would suggest that you code with the new $_* vars in mind instead.

[onion2k]

Laserlight..

Your "if (!empty($GET['page'])) " block adds nothing to that script. The default of the switch..case would pick up empty values of $GET['page'].

[laserlight]

.... unless $_GET['page'] doesnt exist.