Problem with this PHP code

matt001

I have coded this page to display information from a database, but its not working. None of the information is displaying from the database. would people please be able to go through and see why my code isn't working.

PHP Page Code:

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<table width="631" border="0" cellpadding="4" cellspacing="1" bgcolor="#CCCCCC">
<tr bgcolor="#000000">
<td width="114"> Staff Name </td>
<td width="103"> Staff Phone</td>
<td width="79"> Staff Dect </td>
<td width="75"> Staff Fax </td>
<td width="92"> Staff Email</td>
<td width="113"> Staff Mob </td>
</tr>
<? include("db.php");

$conn = mysql_connect(HOST, USER, PASS);
mysql_select_db(D😎;

// build SQL
$strsql = "SELECT * FROM staff_contacts ORDER BY 'staffname";

// avoid starting record > total records
if ($startRec > $totalRecs) {
$startRec = $totalRecs;
}

// set the last record to display
$stopRec = $startRec + $displayRecs - 1;
$recCount = $startRec - 1;

// move to the first record
@mysql_data_seek($rs, $recCount);
$recActual = 0;
while (($row = @mysql_fetch_array($rs)) && ($recCount < $stopRec)) {
$recCount++;
if ($recCount >= $startRec) {
$recActual++;
$bgcolor = "#FFFFFF"; // set row color
if (($recCount % 2) <> 0) { // display alternate color for rows
$bgcolor = "#F5F5F5";
}

// load key for record
$key = @$row["id"];
$x_id = @$row["id"];
$x_staffName = @$row["staffName"];
$x_StaffPhone = @$row["StaffPhone"];
$x_StaffDect = @$row["StaffDect"];
$x_StaffFax = @$row["StaffFax"];
$x_StaffEmail = @$row["StaffEmail"];
$x_StaffMob = @$row["StaffMob"];
$x_Category = @$row["Category"];
?>
<tr bgcolor="<?php echo $bgcolor; ?>">
<td><?php echo $x_staffName; ?> </td>
<td><?php echo $x_StaffPhone; ?> </td>
<td><?php echo $x_StaffDect; ?> </td>
<td><?php echo $x_StaffFax; ?> </td>
<td><a href="mailto:<?php echo $x_StaffEmail; ?>">Email Staff</a></td>
<td><?php echo $x_StaffMob; ?> </td>
</tr>
<?php
}
}
?>
</table>
</body>
</html>

opendb.php page

<?
$link=mysql_pconnect("localhost","root","test");
mysql_select_db ("absoe" ,$link) or die ("Could not connect to database");
?>

SQL Dump File

CREATE TABLE staff_contacts (
id int(11) NOT NULL auto_increment,
staffName varchar(50) NOT NULL default '',
StaffPhone varchar(5) NOT NULL default '',
StaffDect varchar(5) NOT NULL default '',
StaffFax varchar(5) NOT NULL default '',
StaffEmail varchar(150) NOT NULL default '',
StaffMob varchar(25) NOT NULL default '',
Category int(11) NOT NULL default '0',
PRIMARY KEY (id)
) TYPE=MyISAM AUTO_INCREMENT=9 ;

Dumping data for table `staff_contacts`

INSERT INTO staff_contacts VALUES (4, 'Kelly', '201', '4521', '211', 'kelly@test.com', '', 6);
INSERT INTO staff_contacts VALUES (3, 'Fred', '202', '2841', '211', 'fred@test.com', '0401 010 010', 2);
INSERT INTO staff_contacts VALUES (5, 'Tammie', '', '7544', '', 'Tammie@test.com', '', 2);
INSERT INTO staff_contacts VALUES (6, 'Ross', '210', '7898', '211', 'ross@test.com', '0401 0101 0101', 7);
INSERT INTO staff_contacts VALUES (7, 'Anne', '1234', '12365', '1253', 'anne@test.com', '', 1);
INSERT INTO staff_contacts VALUES (8, 'Matthew', '1234', '13442', '12343', 'matthew@test.com', '94949494', 6);

Please have a look through this and tell me what's wrong with the coding

Thanks

Matthew

dalecosp

Looks like a mistake in the SQL query:

$strsql = "SELECT FROM staff_contacts ORDER BY 'staffname";

I'd think that you want:

$strsql = "SELECT * FROM staff_contacts ORDER BY staffname";

It's also a very good idea to make sure the query is valid before going on with your script:

$result=mysql_query($strsql);

if (!$result) {
     die("Database error!  Mysql said: ".mysql_err());
}

// now you can go on with the script ...

onion2k

Are you managing to connect to our database? Just that you have 'include("db.php");', and then you say your database connection file is called opendb.php. And besides, you also have $conn = mysql_connect(HOST, USER, PASS); mysql_select_db(D😎;, and your script doesn't appear to define any of those constants...