Error Using LIST and EACH in Login script

[TKennedy]

I'm having trouble getting my login script to work. The login data is being retrieved from a text file that is located in a subdirectory named "files". The variable $Data_file is declared in an include file using a REQUIRE statement and is set to "files\data.txt".

When I run the script, this is the error that I get when I submit the login form:

Warning: Variable passed to each() is not an array or object in /home/public_html/test/page.php on line 765

Am I doing something wrong in the function? Line 765 is the line with the WHILE statement in it.

function VerifyPwd($user,$password) {
   $found=false;
   $ret = array();
   $pwdcrypted=md5($password);

   $fileopen = file("$data_file");

   \\ The error is from the line below.
   while (list($linenum, $line) = each($fileopen) && !$found) {
      $line=trim($line);
  	  if(!preg_match("{^#}",$line) && $line!="") {
  	  	  $array=explode("|",$line);	  	  

	  if($array[0]==$l && $array[1]==$pwdcrypted) {
	  	  $ret["AUTH"]=1;
		  $ret["USER"]=$user;
		  $ret["HOME"]=$array[2];
		  $found=true;
		}
	}
}
if(!$found)	{
	$ret["AUTH"]=0;
	$ret["USER"]=$user;
	$ret["HOME"]="";
}
  return $ret;
}

[rpanning]

Replace

$fileopen = file("$data_file");

With

if (($fileopen = file($data_file)) === false)
    print("Error: Couldn't read the file $data_file");

So, if you get that error message, which I think you will, that means file() couldn't read the file you gave it. Make sure you are sending a absolute path to the file. Ex: C:/htdocs/files/data.txt

[TKennedy]

Yes, you're right, the data file isn't being opened so the while loop fails.

The data file I need to open is located in a sub directory of where the script is running.

The variable is setup in the include file like this: $data_file = ("/files/data.txt");
but I have tried $data_file = ("files/data.txt");
and $data_file = ("/home/public_html/test/data.txt");

I know I'm missing something easy... 😕

[rpanning]

Try $data_file = dirname($_SERVER['SCRIPT_FILENAME']).'/files/data.txt'); That should give you the absolute directory that the script is running in and then it tacks on the sub directory and filename.

[maqmus]

Or this way:

$fpath = $_SERVER['SCRIPT_FILENAME'];
$fpath = str_replace("/myscript.php","",$fpath);
$data_file = $fpath.'/files/data.txt';

I noticed in TKennedys post something could be a typo:

$data_file = ("/home/public_html/test/data.txt");

It should be

$data_file = ("/home/public_html/test/files/data.txt");

or

$data_file = "/home/public_html/test/files/data.txt";

[TKennedy]

After much distress, I finally got it to work.... It opens the file atleast....

I had to modify the function and make the variable $data_file a global variable, and then it worked fine. The function looks like this now:

function VerifyPwd($user,$password) {
	global $data_file;
   $found=false;
   $ret = array();
   $pwdcrypted=md5($password);

   if (($fileopen = file($data_file)) == false) {

   echo "File Open Error: Unable to read file $data_file";
   }

   while (list($linenum, $line) = each($fileopen) && !$found) {
      $line=trim($line);
  	  if(!preg_match("{^#}",$line) && $line!="") {
  	  	  $array=explode("|",$line);	  	  

	  if($array[0]==$l && $array[1]==$pwdcrypted) {
	  	  $ret["AUTH"]=1;
		  $ret["USER"]=$user;
		  $ret["HOME"]=$array[2];
		  $found=true;
		}
	}
}
if(!$found)	{
	$ret["AUTH"]=0;
	$ret["USER"]=$user;
	$ret["HOME"]="";
}
  return $ret;
}

and the variable defined in the include file is:

$data_file = "files/data.txt";

the passwords from the file still don't validate...but one step at a time I suppose.