regex: ubbc links and URL conflict

sijis

I'm trying to create a capability (similar to this bb) with converting URL's into links.

user input:

[link="www.domain.com"]url text[/link]
http://www.otherdomain.com

my desired output is

<a href="http://www.domain.com">url text</a>
<a href="http://www.otherdomain.com">http://www.otherdomain.com</a>

the code i have converts the [link] tags just fine, but when the next regex executes, its screws up the [link] tags and the output isn't desired.

here's my code:

$text = '[link="www.domain.com"]url text[/link]
 http://www.otherdomain.com';
$text = preg_replace('/\[link=&quot;(.*?)&quot;\](.*?)\[\/link\]/i', '<a href="$1">$2</a>', $text);
$text = preg_replace('/(?:(http:\/\/)|(www\.))(\S+\b\/?)([[:punct:]]*)(\s|$)/i', '<a href="http://$2$3">$2$3</a>', $text);

i think my problem is with using preg_replace. I tried splitting the string into an array (by spaces, \r, and \t) but that created problems when the [link text contained a space.

I would appreciate any help on this. I'd also be open to another better approach to this type of problem.

thanks.

dnast

I love what the forum script does to regexp code. :rolleyes: 🙂 I thought you were missing some slashes at first until I thought about it.

I think you could test to make sure a quote doesn't proceed the string.

Seems like a simple [^\"] could do the trick.

If that doesn't work, I'll look at my stuff when I get home. I just went through this same problem a few weeks ago.

sijis

i appreciate the response but i don't know much about regex.

so your comment about adding a simple [^\"] to 'it'. which expression is it to?
and just so i know, what does that mean? (string doesn't have a " in it?)

Thanks.

dnast

Oh sorry, I meant like this:

$text = preg_replace('/[^\\"](?:(http:\\/\\/)|(www\\.))(\\S+\\b\\/?)([[:punct:]]*)(\\s|$)/i', '<a href="http://$2$3">$2$3</a>', $text);

Here's what I used in mine:

//"url" tag code
$info = preg_replace('/[url=((http|ftp):\/\/([^{\"]+?))]([^{<>]*?)[\/url]/i','<a}} href="\1">\4</a>',$info);

//Convert text URLs into hyperlinks (NOTE: Won't work if full text is URL)
$info = preg_replace('/((http|ftp):\/\/[a-zA-Z0-9]+(.[-a-zA-Z0-9]+).[a-zA-Z]{2,4}(\/[^{\s<>[]|\"\\]+)})[\s]/i','<a href="\1">\1</a>',$info);
$info = preg_replace('/\s/i','<a href="\1">\1</a>',$info);
$info = preg_replace('/([\s])(www.[-a-zA-Z0-9]+.[a-zA-Z0-9]{2,4})/i','\1<a href="http://\2">\2</a>',$info); //This one checks for www.whatever.dom (no http: etc)

Note: I didn't put them in php tags because I didn't want to go in and double up all of my slashes that the 'php' tag likes to erase

And the [\"] in front means "http" or "ftp" won't have a quote in front.

Looking at them now, I see my regular expressions could use a little tweaking 😃