posssible image to display

jannoy

In my show.htm
i have this code
<img src="myimage.php?id=1"

and in my image.php

$show=$_GET[id];
if ($show==1)
{
echo "banner1.jpg"
}

BuzzLY

How wonderful.

Mordecai

There's a little bit of mixed up logic here. If you were doing something along the lines of:

<img src="<?php if ($_GET['id'] == 1) {echo 'banner1.jpg'; } ?>" />

Then it would work, but this is assuming that you've got id=1 in the query string of the page you want the image on.

Since you're using the set page of myimage.php, you'll need to physically output the image. This is done through:
1) readfile() -- quick and easy
2) image functions (GD) -- long, but as much control as you would ever need
3) fopen() -- a lot of control, but probably not needed

Keep in mind that you'll need to output a header() that says what type of image it is. Take a look at image_type_to_mime_type(), exif_imagetype() and getimagesize().

BuzzLY

Great, Mordecai. How can I be a cranky bastard with any sort of credibility if you're gonna go answering the question he never really asked? Huh???? Sheesh!

jannoy

answer is too far from my question

BuzzLY

Jannoy, you didn't ask a question. What is it you are looking for?

jannoy

read my topic ? and the code

BuzzLY

I already did. If Cai's explanation doesn't help you, then I have NO idea what you want. If you aren't willing to expand on what you are talking about, then I guess I can't help you. There are plenty of other people here that need help, and are willing to be clear about what they want. Just let us know when you'd like to ask for help without being snotty about it.

drew010

echo "banner1.jpg" wont work in the code. you will either need to use readfile and output the contents along with the image type, or somehow turn that into an include.
i would try this:

image.php

<?php
$show = $_GET['id'];

if ($show == 1) {
     $banner = "banner1.jpg";

$idata = getimagesize($banner);
header("Content-Type: {$idata['mime']}");

echo file_get_contents($banner);
}
?>

the image should display fine that way.

jannoy

here is the logic i dont want the user to view the location of the images

drew010

they wont be able to view the location of the images. that script will output the data inside it to the browser so they will never be able to figure out where its coming from

onion2k

Originally posted by drew010
they wont be able to view the location of the images. that script will output the data inside it to the browser so they will never be able to figure out where its coming from

Only they will. Sure, they'll not know the actual location of the image file, but they'll still be able to call "<img src="myimage.php?id=1"> " and get the image instead. This solution offers no security whatsoever, and its a big waste of time.

BuzzLY

Originally posted by jannoy
ok

here is the logic i dont want the user to view the location of the images

I can see your motivation for doing this, but it's really unnecessary. I mean, unless your images are in a location you are embarrassed about, your users will have no more access to your images than they would using the php method you are trying to do. All you have to do is secure the directory the images are in, and users won't be able to browse through them.

corporateboy

also remember that a user can always circumvent image protection by

1) right clicking to save; or
2) copying and pasting the whole page into an editor; or
3) saving the page and all files associated with it; or
4) Print Screen (my personal favourite)

So there is no point in trying to hide the file's location, better to watermark the file if you really want to protect it - or hire a lawyer.

tommynanda

So there is no point in trying to hide the file's location

This solution offers no security whatsoever, and its a big waste of time.

What if we are using sessions? This solution offers better security than HTML for sure... Good for Dynamic image calling... Linking images that are not in webserver path... I think this is one of my Favorite scripts 😃

No offense meant
TommYNandA

drawmack

As was pointed out before if a user can view an image on their screen they can steal it PEROID

BuzzLY

Yeah. PEROID!

:queasy:

tommynanda

🙂 This is like... If I can check my eMail 1s... I can store my email.PEROID