Creating Links (Newbie Help Pls)

[legacyhosting]

<?

$ranknum = 1;
$current_row = 0;
while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
	$result_id = $row["id"];
	$result_name = $row["username"];
	$result_country = $row["country"];
	echo "<tr><td><p>" . $ranknum . "</p></td><td><p>" .  $result_name . "</p></td><td><p>" . $result_country . "</p></td>";
	$current_row++;
	$ranknum++;
}
echo "</table>";
mysql_close($conn);
?>

I'm trying to make it so every username that is placed gets a hyperlink to something like playstats.php?$username but whenever i try i get various errors. Any help??

thanks!

[bubblenut]

Firstly, where's the link you're building? I can't see any link in the code you provided? Also, what errors are you getting?

[legacyhosting]

Thats because i got no idea where to put it i tried puttin it in this bit:

echo "<tr><td><p>" . $ranknum . "</p></td><td><p>" .  $result_name . "</p></td><td><p>" . $result_country . "</p></td>"; 

on the result_name bit but i tried using an echo but it said unexpected echo or parse errors

[bubblenut]

<?

$ranknum = 1;
$current_row = 0;
while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
	$result_id = $row["id"];
	$result_name = $row["username"];
	$result_country = $row["country"];
	echo "<tr><td><p>$ranknum</p></td><td><p><a href=\"playstats.php?username=$result_name\"> $result_name</a></p></td><td><p>$result_country </p></td>";
	$current_row++;
	$ranknum++;
}
echo "</table>";
mysql_close($conn);
?>

Like so?

[edit]
NB. You don't have to drop out of the string if you're using double quotes and simple variables
[/edit]

[legacyhosting]

Yes thanks alot!! thanks for the quick reply too

[MrCool]

<?

$ranknum = 1;
$current_row = 0;
while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
	$result_id = $row["id"];
	$result_name = $row["username"];
	$result_country = $row["country"];
	echo "<tr><td><p>" . $ranknum . "</p></td><td><p><a href=\"playstats.php?username=".$result_name."\">" .  $result_name . "</a></p></td><td><p>" . $result_country . "</p></td></tr>";
	$current_row++;
	$ranknum++;
}
echo "</table>";
mysql_close($conn);
?>

I slightly edited your code and added the link and closed the tr at the end. The error you are talking about is it on that long echo line?

[legacyhosting]

Yeah it was, but now it all works, any suggestions to improve the coding it appricated if you want to though.

[bubblenut]

<?php

//You only need one variable and it can all be handled in a for loop: reduced memory footprint
for($ranknum = 1; $row = mysql_fetch_array($result, MYSQL_ASSOC); $ranknum++) 
	//No need to transfer array elements to simple variables, uses extra memory (all of a few bytes in this
	//case but may have more impact on larger resultsets) no <p></p> needed as the data 
	//is all that appears in each table element so any styling can be put in the CSS.
	echo "<tr><td>$ranknum</td><td>".$row['username'].'</td><td>'.$row['country'].'</td></tr>';
echo '</table>';
mysql_close($conn);
?> 

HTH
Bubble

[legacyhosting]

with that edited version where do i make the links on it so it still does what i originally wanted it to do?

[bubblenut]

I shouldn't need to do this as with about a seconds thought you'd have got it yourself :mad: but I'm bored so here.

for($ranknum = 1; $row = mysql_fetch_array($result, MYSQL_ASSOC); $ranknum++) 
    echo "<tr><td>$ranknum</td><td><a href=\"playstats.php?username=".$row['username'].'">'.$row['username'].'</a></td><td>'.$row['country'].'</td></tr>';
echo '</table>';
mysql_close($conn);

[legacyhosting]

hehe sorry, probably should of tried thinking for myself, but it's only been a little while i been learning php, but thanks for the help!