greeting parse error

jkatcher

hi -- i am trying to customize the greeting on a login / logout page, but keep getting a parse error w/ this code -- any thoughts?

<?php
if(!empty($HTTP_SESSION_VARS['username']))
{
echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\"login.php?do=logout">login</a>";
}
else
{
   echo "Hello, Guest <a href=\"login.php">logout</a>";
}
?>

LordShryku

Escape your quote here
do=logout">

rachel2004

Originally posted by jkatcher
echo "Hello, Guest <a href="login.php">logout</a>"
[/B]

You need to escape your inner quotes.

jkatcher

sorry -- what does that mean exactly?

LordShryku

Add a slash.

a href=\"<-(escaped)login.php"<-(not escaped)>logout</a>

jkatcher

<?php 
if(!empty($HTTP_SESSION_VARS['username'])) 
{ 
echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\"login.php?do=logout">login</a>"; 
} 
else 
{ 
   echo "Hello, Guest <a href=\"login.php">login</a>"; 
} 
?>

i am unfortunately still getting a parse error -- here:

echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\"login.php?do=logout">logout</a>";

For some reason the slash infront of "login.php" is not showing up on the post but it is there.

LordShryku

You are still not escaping it.

// Wrong
echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\"login.php?do=logout">logout</a>";

// Right
echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\"login.php?do=logout\">logout</a>";

rachel2004

Like I said, you need to escape your double quotes. Look at the word "logout" and you'll see what I mean.

Weedpacket

How ever did we get along in the old days, with monochrome monitors and no syntax highlighting? 🙂

<?php 
if(!empty($HTTP_SESSION_VARS['username'])) 
{ 
echo "Hello,". $HTTP_SESSION_VARS['username'] ."<a href=\\"login.php?do=logout\\">login</a>";
}
else
{
   echo "Hello, Guest <a href=\\"login.php\\">login</a>";
} 
?>

Or even just use single quotes for the strings:

<?php 
if(!empty($HTTP_SESSION_VARS['username'])) 
{ 
echo 'Hello,'. $HTTP_SESSION_VARS['username'] .'<a href="login.php?do=logout">login</a>';
}
else
{
   echo 'Hello, Guest <a href="login.php">login</a>';
} 
?>

jkatcher

resolved, thank you!!