Not So Random - Random Images

[ShawnK]

I was helping somebody earlier with a random picture script....well I made one...but it's not so random. Well whatdy'a think?

<? 

$totalpics = "5";
$imgext = ".jpg";

session_start(); 

if(!isset($_SESSION['lastimgviewed'])){ 

$_SESSION['lastimgviewed'] = "0"; 

} elseif(isset($_SESSION['lastimgviewed'])){ 

$lastimg = $_SESSION['lastimgviewed']; 

  if($lastimg == $totalpics){ 
              $nextimg = "1"; 
  else { 

  $nextimg = $lastimg + "1"; 

  $imgfile .= $nextimg; 
  $imgfile .= $imgext;

} 

echo "<img src=\"$imgfile\">"; 
} 

?>

[onion2k]

<?php

$totalpics = 5;
$imgext = ".jpg";

session_start();

if(!isset($_SESSION['lastimgviewed'])){
	$_SESSION['lastimgviewed'] = "0";
} elseif(isset($_SESSION['lastimgviewed'])){
	$lastimg = ++$_SESSION['lastimgviewed'];
}

if($lastimg >= $totalpics){
	$_SESSION['lastimgviewed'] = "";
	$nextimg = 1;
} else {
	$nextimg = $lastimg + 1;
}

$imgfile  = $nextimg.$imgext;

echo "<img src=\"$imgfile\">";

?>

Tweaked it so that it works. :p

(Was it supposed to rotate through 5 images? I figured it was.)

[onion2k]

<?php
session_start();
$_SESSION['lastimgviewed'] = ($_SESSION['lastimgviewed'] != 0) ? (($_SESSION['lastimgviewed'] >= 5) ? 1 : ++$_SESSION['lastimgviewed']) : 1;
echo "<img src=\"".$_SESSION['lastimgviewed'].".jpg\">";
?>

For the sake of evilness I've optimised it.

[onion2k]

<?php
session_start();
$_SESSION['l'] = ($_SESSION['l']%5==0) ? 1 : ++$_SESSION['l'];
echo "<img src=\"".$_SESSION['l'].".jpg\">";
?>

Thats better. None of that horrid bloat.

[BuzzLY]

A better idea might be to read in all of the files in the directory that are images, and build an array of file names. Then, figure out the last image displayed (from the session variable), find that image in the array, and display the next image.

It is a little more complicated than what you are doing, but it has a couple of advantages:

1. It will work with any number of images

2. You never have to modify the code to make it work with new images

3. You don't have to rename your image files

I have written a page that demonstrates this in action

BuzzLY's Image Rotator

To view the source, click here.

[onion2k]

Nice Buzzly. Now make it 3 short lines long. 😉

[BuzzLY]

:p

I could if I wanted to... but it would be difficult to read 😃