Problem in login script?

Dakkar

I have a login script with session variables but when i push the login button notting is happening i couldnt find where is the problem
here is my code

<?
session_start();

if ($username && $password)
{
$db_conn = mysql_connect("localhost", "root", "12345");
mysql_select_db("account", $db_conn);
$query = "select * from adminacc where username='$username' and password='$password'";
$result = mysql_query($query, $db_conn);
if (mysql_num_rows($result) > 0)
{
$valid_user = $username;
session_register("valid_user");
}
?>

<html>
<body>
<h1> Account Panel Login</h1>
<?
if (session_is_registered("valid_user"))
{
echo "You are logged in as : $valid_user <br>";
echo "<a href=\"logout.php\">Logout</a><br>";
}
else
{
  if (isset($username))
  {
  echo "Hatali Login";
  }
  else {
  echo "Login olmadiniz geri donup login olun";
  }
}

}
?>
<form method=get action=index.php>
<table>
<tr><td>Username:</tr></td>
<td><input type=text name=username></td></tr>
<tr><td>Password:</tr></td>
<td><input type=password name=password></td></tr>
<tr><td colspan=2 align=center>
<input type=submit value=LogIn></td></tr>
</table></form>
<br>
<a href="members.php">Members Section</a>
</body>
</html>

rachel2004

Originally posted by Dakkar
<?
session_start();

if ($username && $password)
[/B]

You need to tell PHP about the forms fields that you are receiving. Try this:

<?php
session_start();
$username = $_POST['username'];
$password = $_POST['password'];
if ($username && $password)

There may be other errors in your code, but start with that and post what happens afterwards when you submit.

dalecosp

Originally posted by Dakkar
I have a login script with session variables but when i push the login button notting is happening i couldnt find where is the problem
here is my code
<?
session_start();

if ($username && $password)
{
[/B]

See the first entry in the Newbie forum thread entitled "Newbie Forum FAQ and Bookmarked Threads".

Dakkar

I made it like this but still nothing is happening

<?
session_start();

$username = $_POST['username']; 
$password = $_POST['password'];

if ($username && $password)
{
$db_conn = mysql_connect("localhost", "root", "12345");
mysql_select_db("account", $db_conn);
$query = "select * from adminacc where username='$username' and password='$password'";
$result = mysql_query($query, $db_conn);
if (mysql_num_rows($result) > 0)
{
$valid_user = $username;
session_register("valid_user");
}
?>

<html>
<body>
<h1>Account Panel Login</h1>
<?
if (session_is_registered("valid_user"))
{
echo "You are logged in as : $valid_user <br>";
echo "<a href=\"logout.php\">Logout</a><br>";
}
else
{
  if (isset($username))
  {
  echo "Hatali Login";
  }
  else {
  echo "Login olmadiniz geri donup login olun";
  }
}

}
?>
<form method=get action=index.php>
<table>
<tr><td>Username:</tr></td>
<td><input type=text name=username></td></tr>
<tr><td>Password:</tr></td>
<td><input type=password name=password></td></tr>
<tr><td colspan=2 align=center>
<input type=submit value=LogIn></td></tr>
</table></form>
<br>
<a href="members.php">Members Section</a>
</body>
</html>

rachel2004

Change the following from:

if (mysql_num_rows($result) > 0)
{
$valid_user = $username;
session_register("valid_user");
}

To the following:

if (mysql_num_rows($result) > 0)
{
$_SESSION['valid_user'] = $username;
}

And change this from:

if (session_is_registered("valid_user"))
{
echo "You are logged in as : $valid_user <br>";

To the following:

if (isset($_SESSION['valid_user']))
{
echo "You are logged in as : $_SESSION['valid_user'] <br>";

and change...

else
{
  if (isset($username))

...to the following:

else
{
    if (isset($_SESSION['valid_user']))

Post back your results and tell me how everything goes.

Dakkar

I made my script like this but still nothing is happening no error no message etc...
even if i write db username and password wrong still nothing is happening

are there any other suggestion for making login session script or are there any solution about this

<?
session_start();

$username = $_POST['username']; 
$password = $_POST['password'];

if ($username && $password)
{
$db_conn = mysql_connect("localhost", "root", "12345");
mysql_select_db("account", $db_conn);
$query = "select * from adminacc where username='$username' and password='$password'";
$result = mysql_query($query, $db_conn);
if (mysql_num_rows($result) > 0) 
{ 
$_SESSION['valid_user'] = $username; 
}
?>

<html>
<body>
<h1>Account Panel Login</h1>
<?
if (isset($_SESSION['valid_user'])) 
{ 
echo "You are logged in  <br>";
echo "<a href=\"logout.php\">Logout</a><br>";
}
else 
{ 
  if (isset($_SESSION['valid_user']))
  {
  echo "Hatali Login";
  }
  else {
  echo "Login olmadiniz geri donup login olun";
  }
}

}
?>
<form method=get action=index.php>
<table>
<tr><td>Username:</tr></td>
<td><input type=text name=username></td></tr>
<tr><td>Password:</tr></td>
<td><input type=password name=password></td></tr>
<tr><td colspan=2 align=center>
<input type=submit value=LogIn></td></tr>
</table></form>
<br>
<a href="members.php">Members Section</a>
</body>
</html>

rachel2004

Your server may not serve the same version of superglobals that I'm suggesting you use... what version is your PHP?

Dakkar

I am using php 5.00Rc2

rachel2004

Give me about 30 minutes and I'll post back.

rachel2004

Originally posted by Dakkar

<form method=get action=index.php>

Change to:

By the way, what is the name of this script that we are working on?

Dakkar

I changed form method to get and my scripts name is index.php
but its still not working

rachel2004

Originally posted by Dakkar
I changed form method to get and my scripts name is index.php
but its still not working

Change it to post, not get.

Dakkar

Thanks so much for your help rachel it worked fine but this time even if i enter wrong username and password its still loging in like its correct
and i want one more thing how can i make this session available in another page?

rachel2004

Originally posted by Dakkar

if (mysql_num_rows($result) > 0) 
{ 
    $_SESSION['valid_user'] = $username; 
}
?>

[/B]

We need to insert a closing curly brace:

if (mysql_num_rows($result) > 0) 
{ 
    $_SESSION['valid_user'] = $username; 
}
}
?>

Post back if this fixes it.

Dakkar

Thanks seems like it worked
but i still have some problems i designed a logout.php like this

<?
session_start();

$old_user= $_SESSION['valid_user']
$result = session_unregister("$_SESSION['valid_user']");
session_destroy();
?>
<html>
<body>
<h1>Log Out</h1>

<?
if (!empty($old_user))
{
 if ($result)
 {
   echo "Guvenli Bir Sekilde Cikis Yaptiniz <br>";
 } else {
   echo "Cikis yapamadiniz.Oturumunuz zaten kapatilmis olabilir <br>";
 }
}
else
{
echo "Giris yapmadiginiz icin cikista yapamazsiniz <br>";
}
?>

But when i try o run it its always giving this error i couldnt find where is the problem?

Parse error: parse error, unexpected T_VARIABLE in C:\Program Files\Apache Group\Apache2\htdocs\Acc\logout.php on line 5

Weedpacket

$result = session_unregister("$_SESSION['valid_user']");

You mean

unset($_SESSION['valid_user']);

; and then the result will always be "Guvenli Bir Sekilde Cikis Yaptiniz <br>",

rachel2004

You were missing a semicolon among other things.

I wasn't sure if what you were showing me was the entire html/php for the logout page, but I noticed you hadn't created closing <body> and <html> tags, so I inserted them after your second block of php code.

See if this works for you:

<?
session_start();
// assign to a temp var called $old_session
$old_user= $_SESSION['valid_user'];
// unregister your session variable
$result = session_unregister($old_user);
// destroy the session itself
session_destroy();
?>
<html>
<body>
<h1>Log Out</h1>

<?
if (!empty($old_user))
{
 if ($result)
 {
   echo "Guvenli Bir Sekilde Cikis Yaptiniz <br>";
 } else {
   echo "Cikis yapamadiniz.Oturumunuz zaten kapatilmis olabilir <br>";
 }
}
else
{
echo "Giris yapmadiginiz icin cikista yapamazsiniz <br>";
}
?> 
</body>
</html>

Dakkar

Thanks so much it worked fine
now i designed a new page named ust.php but i am taking this error when i run this ust.php

<?
session_start();
$admin = $_SESSION['valid_user'];  

if (!empty($admin)) 
{ 
echo "<center><a href=\"members.php\">[Ekle]</a>  : <a href=\"display.php\">[Liste]</a></center> <br>";
}
else
{
echo "<center>You dont have to permission to see this page</center> <br>";
}

?>

the error is this

Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at C:\Program Files\Apache Group\Apache2\htdocs\SylAcc\members.php:9) in C:\Program Files\Apache Group\Apache2\htdocs\Acc\ust.php on line 2

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at C:\Program Files\Apache Group\Apache2\htdocs\Acc\members.php:9) in C:\Program Files\Apache Group\Apache2\htdocs\Acc\ust.php on line 2

but when i delete the session start(); part the php is not working?
I couldnt find where is the problem?

rachel2004

I get the feeling that you're not showing everything that appears in your page...

Can you post again and let me know if this is the entire code for that single page or if this is a snippet that you are attempting to insert into another page?

Consider using output buffering,
http://us3.php.net/manual/en/ref.outcontrol.php
but I guess one thing at a time. ;-)

Dakkar

This is my entire code

first of all this is members.php

<html>

<head>
<meta http-equiv="Content-Language" content="tr">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1254">
</head>

<body bgcolor="#FFFFD2">
<? include("ust.php"); ?>
<br>
<br>
<div align="center"><br><br>
  <center>
<form method="POST" action="asubmit.php">
  <table border="1" width="77%" cellspacing="0" cellpadding="0" bordercolor="#000000">
    <tr>
      <td width="100%" bgcolor="#C0C0C0" colspan="2">
        <p align="center"><b><font size="5">Yeni Hesap Açma Formu</font></b></td>
    </tr>
    <tr>
      <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Kullanýcý
        Ýsmi</b></font></td>
    </center>
    <td width="49%" bordercolor="#000000" bgcolor="#808080">
      <p align="left">&nbsp;<input type="text" name="username" size="50" style="font-family: Tahoma; font-size: 10px; 
color: #FF0000"></td>
  </tr>
  <center>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Parola</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="password" size="20" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Ýsim
      Soyad</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="fullname" size="50" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Anne
      Kýzlýk Soyadý</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="momname" size="25" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Telefon
      </b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="phone" size="14" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Adres</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="addr" size="70" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;E-Posta</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font><input type="text" 
name="email" size="50" style="font-family: Tahoma; font-size: 10px; color: #FF0000"></td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Hesap
      Süresi Bitiþ: (Ay/Gün/Yýl) Örnek: 19 1 2004</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;</font>
<input type="text" name="bg" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000"> -
<input type="text" name="ba" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000"> -
<input type="text" name="bay" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000"> 
</td>
  </tr>
  <tr>
    <td width="51%" bgcolor="#C0C0C0"><font face="Tahoma" size="2"><b>&nbsp;Baþlangýç
      Tarihi: (Ay/Gün/Yýl) Örnek: 19 1 2003</b></font></td>
    <td width="49%" bordercolor="#000000" bgcolor="#808080">&nbsp;
<input type="text" name="sg" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000"> -
<input type="text" name="sa" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000"> -
<input type="text" name="sy" size="2" style="font-family: Tahoma; font-size: 10px; color: #FF0000">
</td>
  </tr>
  <tr>

<td width="51%" bgcolor="#C0C0C0"><b><font size="2" face="Tahoma">&nbsp;Hesap
  Durumu:</font></b></td>
<td width="49%" bordercolor="#000000" bgcolor="#808080"><font face="Tahoma" size="2">&nbsp;<input type="radio" 
value="0" checked name="disable">
      Açýk :: <input type="radio" value="1" name="disable"> Kapalý</font></td>
  </tr>
  <tr>
    <td width="100%" bgcolor="#C0C0C0" colspan="2">
      <p align="center"><font face="Tahoma" size="2">&nbsp;</font><input type="submit" value="Ekle" name="submit" 
style="font-size: 10px; font-family: Tahoma"></td>
  </tr>
  </table>
  </center>
</div>

<p align="center">&nbsp;</p>
<p align="center">&nbsp;</p>

</form>

</body>

</html>

secondly this is ust.php that ı showed before

<? 
if (session_is_registered("valid user"))
{ 
echo "<center><a href=\"members.php\">[Ekle]</a>  : <a href=\"display.php\">[Liste]</a></center> <br>";
}
else
{
echo "<center>You dont have the permission to show this page</center> <br>";
}

?>