[Resolved] Seperating numerous results from a Query with a comma...

[ExpendableDecoy]

Hi there. 🙂

I'm currently trying to achieve as the title says.

I've got a query which will bounce back 2+ results and I need the results to show up next to one another seperated by a comma.

This is the code I've got so far, which fails to achieve what I want...mostly guess work from me.

$sql = " SELECT character_name , character_id FROM character_table
		WHERE character_guild_rank = '$guilds_member_rank' ";
if( !($result = $db->sql_query($sql)) )
{
	message_die(GENERAL_ERROR, 'Could not query Guild table for member rank', '', __LINE__, __FILE__, $sql);
}

if($rank_guild_members = $db->sql_fetchrow($result))
{
		$i = 0;
	do
	{
		$character_id = $rank_guild_members['character_id'];
		$members_list = "".$rank_guild_members[$i]['character_name'].", ";

	$template->assign_block_vars('guilds_ranks.rows', array(
		"U_GUILD_MEMBERS" => $members_list,
	));

$i++;
}
	while ( $rank_guild_members = $db->sql_fetchrow($result) );
}

It grabs the results fine, because echoing the character_id brings back what I would expect but I cannot work out how to output the values as I need them.

I need it to output the results to look like this:

Tom, Dick, Harry

Any help would be great!. :p 🙂

[TheDefender]

$qry = mysql_query("SELECT * FROM table");
$count = mysql_num_rows($qry);

WHILE($row = mysql_fetch_array($qry)){

  echo $row['fieldname'].", ";

}

Just loading this up quick, as I have to run, but you also have to utilize the count and use an IF/ELSE to determine whether to echo a comma or not. I don't have time to show you that right now, but I will make the mods later if someone hasn't come in to show you before I get the time.

[ExpendableDecoy]

Thanks TheDefender. 🙂

I'll take a read up on that then to see if I can work this out for myself with the info you just gave.

I have a feeling I'll be back but I shall try my best!. 🙂

[ExpendableDecoy]

Well, I've tried my best to work this one out but to no avail.

I keep getting one result out, but no more than that.

Any help would be realy apprieciated. 🙂

[TheDefender]

Something like this? This will output:
Tom, Dick, Harry

Notice how the last one doesn't have the trailing comma...
Let me know if this is more along the lines of what you are trying to do.

$sql = "SELECT character_name, character_id FROM character_table WHERE character_guild_rank = '$guilds_member_rank'";
$runquery = mysql_query($sql);
$countmembers = mysql_num_rows($runquery);

IF($countmembers > 0):

FOR($i = 0; $i < $countmembers; $i++):
	$row =  mysql_fetch_array($runquery);
	IF($i < ($countmembers-1)):
		echo $row['character_name'].", ";
	ELSE:
		echo $row['character_name'];
	ENDIF;
ENDFOR;

ELSE:

  echo "No results were returned.";

ENDIF;

[ExpendableDecoy]

That's exactly what I'm looking for!. Thank you DT. 🙂

One last question on this though.

I had to change the code slightly to comply with the standards set out by the forum I'm designing this for...this is how it looks:

// Grab general guild member details...
$sql = " SELECT character_name FROM character_table	
WHERE character_guild_rank = '$guilds_member_rank' ";

$runquery = db->sql_query($sql);
$countmembers = $db->sql_numrows($runquery);

if ( $countmembers > 0 ):
for ( $i = 0; $i < $countmembers; $i++ ):

$rank_member = $db->sql_fetchrow($runquery);

if ( $i < ($countmembers - 1) ):

$members_list_start = $rank_member['character_name'].", ";

else:

$members_list_end = $rank_member['character_name'];

endif;
endfor;

else:
      echo "No results were returned.";
endif;

Now this part:

if ( $i < ($countmembers - 1) ):

$members_list_start = $rank_member['character_name'].", ";

else:

$members_list_end = $rank_member['character_name'];

I had to replace the 'echo' amd make it into a variable so that it can be echo'd elsewhere (again to do with standards for the forum).

If I change the 'members_list_start' to 'echo' it shows all the members as it should, but when I make it into a variable it only shows one.

The 'members_list_end' 'else' part works fine though. 🙂

Any idea's why this would happen to the 'members_list_start' when turned into a variable?.

Thanks again. 🙂

[TheDefender]

Something more along these lines I presume... Let me know if this is more along the lines of what you need. This takes all of the names and makes it into one variable (called $members_list).

// Grab general guild member details... 
$sql = " SELECT character_name FROM character_table     

WHERE character_guild_rank = '$guilds_member_rank' "; 

$runquery = db->sql_query($sql); 
$countmembers = $db->sql_numrows($runquery); 

if ( $countmembers > 0 ):
	// Define the empty $members_list variable, so we have something to append to later when we concatenate the variables in our for loop. 
	$members_list = "";
	for ( $i = 0; $i < $countmembers; $i++ ): 
		$rank_member = $db->sql_fetchrow($runquery); 
		if ( $i < ($countmembers - 1) ):
			// Use the concatenate operator (.=) to append the first names in the list to include the trailing comma. 
			$members_list .= $rank_member['character_name'].", "; 
		else:
			// Use the concatenate operator (.=) to append the last name in the list to not include the trailing comma. 
			$members_list .= $rank_member['character_name']; 
		endif; 
	endfor; 

// echo the $members_list variable to make sure it is what you are looking for.
// Once you have verified this is what you need, feel free to delete it.
echo $members_list;

else: 
      echo "No results were returned."; 
endif;

[ExpendableDecoy]

That works great!.

Thanks for your time on this TD. 🙂

[TheDefender]

No problem ED. Have a nice day.