php not emailing

[davieboy]

i am trying to get a page to email data to the user when they enter in their address

<?php

$email = "Sender Name: Admin\nSender Email: admin@email"; 
$to = "david@email"; 
$subject = "Info Request"; 
$mailheaders = "From: $thereemail"; 
$mailheaders .= "$thereemail"; 
mail($to, $subject, $email, $mailheaders); 

//the above works fine and emails admin perfectly

include "config.php";
$db = mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
// We are now connected to the database
// We select one clients details and bring it into text boxes
$id = $_GET['id'];
$query = "SELECT * FROM clients WHERE id = '$id'";
$result = mysql_query($query)or die (mysql_error());
while($r=mysql_fetch_array($result))
{
$id=$r["id"];
$town=$r["town"];
$area=$r["area"];
$price=$r["price"];
$style=$r["style"];
$rooms=$r["rooms"];
$agent=$r["agent"];
$address=$r["address"];
$pcode=$r["pcode"];
$description=$r["description"];
$agent=$r["agent"];
$refcode=$r["refcode"];
//Send the relevant e-mail to the user
	$to = $_REQUEST['thereemail'];
    $mail_body = "Hello $name\n";
	$mail_body .= "You have requested information on:\n";
	$mail_body .= "Property Reference: $refcode\n";
	$mail_body .= "Area: $area, Town: $town\n";
	$mail_body .= "The property is $price, with $rooms Bedrooms and is a $style House.\n";
	$mail_body .= "The Agent selling it is $agent.\n";
	$mail_body .= "A direct link to the property is webaddress/fullinfo.php?id=$id \n";
	$mail_body .= "Yours \n David  \n \n web \n david@email \n web.com";
    mail($to, "web", $mail_body, "From: David \n");
}
print "Thank You for your Request, you will get the info via email shortly.";
include("index.php"); 
// the stuff above does not email out


?>

I know it will prob be a tiny problem, but i have no idea where

cheers
David

[sijis]

my gut feeling is that there is a problem with this statement:
$to = $_REQUEST['thereemail'];

what does the variable $to echo? are you sure you don't want $_POST['thereemail']; instead? it could be that the email passed is wrong.
also make sure that the form or querystring are matching 'thereemail' (should really be 'theiremail') and that its spelled correctly.

the other thing i'd look at is the header in the last mail() call.
mail($to, "web", $mail_body, "From: David \n");
maybe adding an email address might do the trick..
so
mail($to, "web", $mail_body, "From: David <[e-mail]>\n");
(i believe that's the format).

hth

sijis

[davieboy]

the code from the previous page is

<form method="post" action="thanks2.php">

  <table width="355" border="0" align="center" cellpadding="0" cellspacing="0">

<tr> 

  <td width="139" valign="top" class="normalfont">Your Name:</td>

  <td width="161"> 

    <input name="name" type="text" class="input" size="30">
<input type="hidden" value="$id" name="id">
        </td>

</tr>

<tr> 

  <td width="139" valign="top" class="normalfont">Your E-mail:</td>

  <td width="161"> 

    <input name="thereemail" type="text" class="input" size="30">

    </td>

</tr>

<tr> 

  <td width="139">&nbsp;</td>

  <td width="161"> 

    <input type="submit" name="Submit" value="Send Me the Details" class="input">

</td>

</tr>
</table>

<p>&nbsp;</p></form>

the mods yhou suggested dont work

[sijis]

i will assume that the initial code you posted is the thanks2.php file, if so do this:

$to = $_POST['thereemail'];
echo $to;
// what do you get?

if you do get a valid email, then simplify the mail() call...

mail($to, 'subject', 'message');

and see if that sends and email.

if it does, add the header.

mail($to, 'subject', 'message', "From: David \n");

then, try it with the $mail_body string... that should give you an idea why it isn't sending.

i hope you realize that you can potentially send more than one email at a time because the 2nd mail call is in a while loop.

sijis

[davieboy]

there is no email appearing in the echo from the
$to

[sijis]

that's odd. hmm.

$to = $_REQUEST['thereemail'];
echo $to;

// response?

you can also do

print_r($POST);
or
var_dump($POST);

and see what values you are reciveing from the form.
you can alternatively use $REQUEST instead of $POST.

also, go back to the form and re-enter the values... they might have gotten 'lost' somehow between refreshing.

sijis

[davieboy]

tried everything and the email is not being passed accross

hmm

[davieboy]

if i use the following

<?php
include "config.php";
$db = mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
// We are now connected to the database
// We select one clients details and bring it into text boxes
$id = $_GET['id'];
$thereemail=$_GET['thereemail'];
$query = "SELECT * FROM clients WHERE id = '$id'";
$result = mysql_query($query)or die (mysql_error());
while($r=mysql_fetch_array($result))
{
$id=$r["id"];
$townn=$r["town"];
$areaa=$r["area"];
$pricee=$r["price"];
$stylee=$r["style"];
$roomse=$r["rooms"];
$agente=$r["agent"];
$addresss=$r["address"];
$pcodee=$r["pcode"];
$refcodee=$r["refcode"];
}
//Send the relevant e-mail to the user
	$from = $_REQUEST['thereemail']; 
    $mail_body = "Hello $name\n";
	$mail_body .= "You have requested information on:\n";
	$mail_body .= "Property Reference: $refcodee\n";
	$mail_body .= "Area: $areaa, Town: $townn\n";
	$mail_body .= "The property is $pricee, with $roomse Bedrooms and is in the catagory: $stylee.\n";
	$mail_body .= "The Agent selling it is $agente.\n";
	$mail_body .= "A direct link to the property is website/ullinfo.php?id=$id \n";
	$mail_body .= "Yours \n David  \n \n web\n david@email \n [url]www.wmail[/url]";
    mail($from, 'web', $mail_body, "From: David <david@email>\n"); 

echo "Thank You for your Request, you will get the info via email shortly. R:$from";
include 'done.php'; 

?>

it sends me the email, but with noone of the data from the database in it