Problem With Repair Script

[legacyhosting]

Hi All!, okay i'm really unsure about this all i'm trying everything that i know of to try an make this script repair the previous results, like delete them an go back to the previous results information like fixing it up like stats. here is the code for the repair script, can you just check if the code is good or any improvements that might, any information you need to hav to make the decsion just ask.

mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

$query="SELECT * FROM repair";
$result=mysql_query($query);
$numrepair=mysql_numrows($result);

if ($numrepair > 0)

{

$points1=mysql_result($result,0,"points1");
$points2=mysql_result($result,0,"points2");
$points3=mysql_result($result,0,"points3");
$points4=mysql_result($result,0,"points4");
$points5=mysql_result($result,0,"points5");
$points6=mysql_result($result,0,"points6");
$points7=mysql_result($result,0,"points7");
$points8=mysql_result($result,0,"points8");


$query="SELECT * FROM results";
$result=mysql_query($query);
$num=mysql_numrows($result);  // The number of results that meet the criteria.
$num--;

$id=mysql_result($result,$num,"id");
$name1=mysql_result($result,$num,"name1");
$name2=mysql_result($result,$num,"name2");
$name3=mysql_result($result,$num,"name3");
$name4=mysql_result($result,$num,"name4");
$name5=mysql_result($result,$num,"name5");
$name6=mysql_result($result,$num,"name6");
$name7=mysql_result($result,$num,"name7");
$name8=mysql_result($result,$num,"name8");
$tags1=mysql_result($result,$num,"tags1");
$tags2=mysql_result($result,$num,"tags2");
$tags3=mysql_result($result,$num,"tags3");
$tags4=mysql_result($result,$num,"tags4");
$tags5=mysql_result($result,$num,"tags5");
$tags6=mysql_result($result,$num,"tags6");
$tags7=mysql_result($result,$num,"tags7");
$tags8=mysql_result($result,$num,"tags8");
$referee=mysql_result($result,$num,"referee");
$map=mysql_result($result,$num,"map");
$date=mysql_result($result,$num,"date");
$modifier=mysql_result($result,$num,"modifier");
$average=mysql_result($result,$num,"average");

$num++;

$query="DELETE FROM results WHERE 'id' = '$num' LIMIT 1";

$names[0]=$name1;
$names[1]=$name2;
$names[2]=$name3;
$names[3]=$name4;
$names[4]=$name5;
$names[5]=$name6;
$names[6]=$name7;
$names[7]=$name8;

$tagss[0]=$tags1;
$tagss[1]=$tags2;
$tagss[2]=$tags3;
$tagss[3]=$tags4;
$tagss[4]=$tags5;
$tagss[5]=$tags6;
$tagss[6]=$tags7;
$tagss[7]=$tags8;

$points[0]=$points1;
$points[1]=$points2;
$points[2]=$points3;
$points[3]=$points4;
$points[4]=$points5;
$points[5]=$points6;
$points[6]=$points7;
$points[7]=$points8;


$query="SELECT * FROM xtag";
$result=mysql_query($query);
$num=mysql_numrows($result);  // The number of entries in xtag.

$i=0;
$p=0;
$rank=1;

while ($i <= 7) { // Iterate through all of the entered names.

    $name=$names[$i];

    $p = 0;

    while ($p < $num) {

            $checkname = mysql_result($result,$p,"name");

            if ($name == $checkname) {  // If match is found.

                    $points=mysql_result($result,$p,"points");
                    $points=$points-$points[$i];

                    $games=mysql_result($result,$p,"games");
                    $games=$games-1;

                    $tags=mysql_result($result,$p,"tags");
                    $tags=$tags-$tagss[$i];

                    if ($i == 0) {

                            $wins=mysql_result($result,$p,"wins");
                            $wins--;

                            $top3=mysql_result($result,$p,"top3");
                            $top3--;

                    }

                    if ($i == 1) {

                            $top3=mysql_result($result,$p,"top3");
                            $top3--;
                    }

                    if ($i == 2) {

                            $top3=mysql_result($result,$p,"top3");
                            $top3--;
                    }

                    $rating=$points/$games;
                    $winsperc=$wins/$games;
                    $top3perc=$top3/$games;
                    $tagsperc=$tags/$games;

                    $query = "UPDATE xtag SET name = '$name',points = '$points',games = '$games',tags = '$tags',wins = '$wins',top3 = '$top3',rating = '$rating',winsperc = '$winsperc',top3perc = '$top3perc',tagsperc = '$tagsperc' WHERE name = '$name'";
                    mysql_query($query);

                    $i++;
                    $p++;

            } else { // If no match is found.

                    $p++;

            }


    }

    $i++;
    $rank++;

}

$query="SELECT * FROM results";
$result=mysql_query($query);
$num=mysql_numrows($result);  // The number of results that meet the criteria.
$num++;

$query="ALTER TABLE results AUTO_INCREMENT = $num";

mysql_close();

echo "Last report removed!";
echo "<br><br><a href=\"http://www.firelords.co.uk/xtag/report.php\">Back to the report page.</a>";

}

?>

[chads2k2]

The only thing I would say is start using arrays. A lot of your information is very repeitive. Try using an array or 3 and then call out using foreach(). I think that would shorten your code down signifanctly and make things easier to troubleshoot.

Other than that it's all good.

Lata.

[Weedpacket]

I'd also suggest reading up on "database normalisation"; if one day you were to want nine points or names or tags or whatever per record, you'll be in trouble.

And make your selections a bit more intelligent by selecting the fields you actually want instead of just using "SELECT *"; using that interferes with the dbms's attempts to optimise the query, and it also means that you waste time transferring stuff from the database to PHP that you have no use for.