What is this problem ???

HoneyBee

Dear:
I am making a web site which can mage discs. I use MS Access to make a data table, SQL and PHP so query. My code:

<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<TITLE> RESULT PAGE </TITLE>
</HEAD>
<BODY>
<font align="center" face=VNI-Netbut color = #336699 > <H1> RESULT </H1> </font>

<table align="center" border = 1 bordercolor=#006699 cellpading = 1 cellspacing = 1 bgcolor=#66ccff fontcolor=#ffffff>
<tr> <th> ID </th> <th> TITLE </th> <th> GENRE </th> <th>QUANTITY</th> </tr>

<?php

ket noi vao co so du lieu

$c = odbc_connect("danhmucdia","","");

$fsqlstart = 1;

$newSQL = "select * from danhmucdia";

if($id != "")
{
$newSQL = "$newSQL where MS like '%$id%' ";
$fsqlstart = 0;
}

if($title != "")
{
if($fsqlstart == 1)
$newSQL = "$newSQL where TenDia like '%$title%' ";
else
$newSQL = "$newSQL and TenDia like '%$title%' ";
$fsqlstart = 0;
}

if($genre != "")
{
if($fsqlstart == 1)
$newSQL = "$newSQL where TheLoai like '%$genre%' ";
else
$newSQL = "$newSQL and TheLoai like '%$genre%' ";
$fsqlstart = 0;
}

if($quantity != "")
{
if($fsqlstart == 1)
$newSQL = "$newSQL where SoDia like '%$quantity%' ";
else
$newSQL = "$newSQL and SoDia like '%$quantity%' ";
$fsqlstart = 0;
}

$query = $newSQL;

$result = odbc_exec($c,$query);

while( odbc_fetch_row($result) )
{
$MS = odbc_result($result,1);
$TenDia = odbc_result($result,2);
$TheLoai = odbc_result($result,3);
$SoDia = odbc_result($result,4);
print("<tr> <td>$MS</td> <td>$TenDia</td> <td>$TheLoai</td> <td>$SoDia</td> </tr> \n");
}

tat ket noi vao co so du lieu

odbc_close($c);
?>

</table>

<p></p>

</BODY>
</HTML>

My errors:

Warning: Undefined variable: id in C:\Inetpub\wwwroot\QuanLyDia\find.php on line 20

Warning: Undefined variable: title in C:\Inetpub\wwwroot\QuanLyDia\find.php on line 26

Warning: Undefined variable: genre in C:\Inetpub\wwwroot\QuanLyDia\find.php on line 35

Warning: Undefined variable: quantity in C:\Inetpub\wwwroot\QuanLyDia\find.php on line 44

So, how can i solve this problem ???
please help me as soon as possible...
Thanks again
Dannis Yang

nemonoman

Warning: Undefined variable: id
Warning: Undefined variable: title i
Warning: Undefined variable: genre
Warning: Undefined variable: quantity

How do you expect these variables to be defined? Do you expect that they are being POSTed from a form? or do you GET them as part of a URL query string?

Anyway, the variables have not been defined within the scope of the script...so you have a problem.

drawmack

First of all learn to code instead of having a generator do it for you 😃

Seriously:

Method 1 (my preference):
At the top of the file put lines that look like this for each variable used in the script:

    $id = '';

Method 2 (the lazy way):
At the top of the file add this line

error_reporting(E_ALL^E_WARN);

I don't like this method because it will suppress all warnings even those you should be getting.

drawmack

p.s. if this is a problem you have often you can create a function like this

<?php
/*void*/ function declare_vars($var_names) {
    if(ereg(',',$var_names) {
        $vars = explode(',',$var_names);
    } else {
        $vars = array($var_names);
    } //end for

foreach($vars as $cur_var) {
    global $$cur_var == '';
} //end foreach
} //end declare_vars
?>

Then you can put this function into an include file and call it at the top of your scripts with a comma seperated list of variable names like this:

    declare_vars('id,title,spasmo');

HoneyBee

Thank you, you are so kind !!!

HoneyBee

Ha ha. First: I do this by myself. Then, I still problem with var. If I declare vars in the top of script like this:
$id='';
$title='';
$genre='';
$quantity='';
It automatically shows all the result, all the data table, not like I request. If I use function to declare vars, maybe the function have a little problem.....

HoneyBee

Dear:
I knew why I have those warnings. I didn't name the textfield's name like vars in PHP file. So I have to name them again. Now, my web site is great !!!
Thank you for your all support.
Dannis.