Make URL a Hyperlink, STUCK!!!

[gordonrp]

Hey guys,

I need to convert a url within a string to be a hyperlink. I have made a function which works well except for when the url has a forward slash in it.

i.e. http://yahoo.com works fine.
but http://yahoo.com/somepage.htm would show http://yahoo.com (and then /somepage.htm not as part of the link)

Here is my function:

function makeLink ( $comment ) //if there is [url]http://[/url] or [url]www.[/url] in a string it makes it a link
{
	  $comment = str_replace  ( "http://", "", $comment );

  $comment = preg_replace ( "/[^<>\s]+(\.)(com|net|org|biz|info)/i", "<a href=\"out.php?gotoURL=\\0\" target=\"_blank\"><SPAN class=comment>\\0</SPAN></a>", $comment );
  $comment = preg_replace ("/(?<!<a href=\")((http|ftp)+(target=\"_blank\")(s)?:\/\/[^<>\s]+)/i", "<a href=\"http://\\0\" target=\"_blank\">\\0</a>", $comment );

  return $comment;
} // end of make link function

I have been stuck on this for days now, any help would be very much appreciated.

thanks,
gp

[gordonrp]

any ideas?

[crimaniak]

Originally posted by gordonrp
any ideas?

function MarkLinks($s,$target=null)
{
	if(isset($target)) $target=" TARGET=\"$target\"";
	$s=ereg_replace("([hH][tT][tT][pP][sS]{0,1}://[a-zA-Z0-9\.=?+%~#:@&/_-]+)","<A$target HREF=\"\\1\">\\1</A>",$s);
	return ereg_replace("([_a-zA-Z0-9\.-]+\@[_a-zA-Z0-9\.-]+)","<A$target HREF=\"mailto:\\1\">\\1</A>",$s);
}

[gordonrp]

thanks for your response, I have implemented your function but it doesnt seem to work.

Implementation at

http://www.gordonswebpages.com/dave/comments.php?id=5

login: gordon2
password: test

any other ideas? thanks gp.

[MisterChaum]

Try this code :

function make_links($string) {
return eregi_replace("([[:alnum:]]+)://([^[:space:]]*)([[:alnum:]#?/&=])",
"<A HREF=\"\\1://\\2\\3\" TARGET=\"_blank\">\\1://\\2\\3</A>",$string);

}

[drawmack]

http://us4.php.net/ereg_replace - example three

The manual not just for breakfast anymore.