check out this 2nd script I ever made

cyberlew15

<?php 
// get a web page into an array and print it out 
if ($HTTP_GET_VARS['cheatfile'] == "") {
echo "this file does not exist";
}
else {
$cheatfile = $HTTP_GET_VARS['cheatfile'] ;
// get a web page into a string 
$buf=implode ('', file ($cheatfile)); 
    $buf = trim($buf); 
    $buf = addslashes($buf); 
    $contentstart=strpos($buf, "<!---------------------------- BREADCRUMB CODE---------------------------->"); 
    if ($contentstart === false) { 
       echo "not found"; 
    exit; 
    } 
    $contentend=strpos($buf, "Thanks to Revolution"); 
    if ($contentend == "thanks to Revolution") { 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
    } 
    if ($contentend == "thanks to revolution") { 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
    } 
    if ($contentend == "Thanks To Revolution") { 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
    } 
    if ($contentend == "thanks To revolution") { 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
    } 
    if ($contentend == "Thanks To revolution") { 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
    } 
    $contentlength=$contentend-$contentstart; 
    $realcontent=substr($buf,$contentstart,$contentlength);
    echo $realcontent;
}
?>

this was a quick way to download cheats from another cheats site games-revolution and put the cheats into a clients cheat system. this is only the viewing code part e-mail me for the rest of the script & watch www.biglew.co.uk for my new site (@ the moment it's a crappy ham radio page my dads got)😃

[FONT=century gothic]mod: added [php] tags to the code. Please use them whenever showing us code. It's MUCH easier to read[/FONT]

planetsim

Sorry to be sounding critical but have you got permission to steal cheats from a site? Also use [php ] tags

BuzzLY

I agree with Planetsim... you really should not be grabbing code from another site without their permission.

Instead of repeating your code with various capitalizations, why don't you just do this:

$contentend=strpos($buf, "Thanks to Revolution");  

if (strtolower($contentend) == "thanks to revolution") {  

  $contentlength = $contentend - $contentstart;  

  $realcontent = substr($buf, $contentstart,
    $contentlength); 
  echo $realcontent; 
}

Of course, your code will still not work, since you are putting a number into $contentend, and testing to see if it's a string. Your if statement will always return FALSE.

Try this instead:

$contentend=strpos(strtolower($buf), "thanks to revolution");  

if ($contentend !== FALSE) {  

  $contentlength = $contentend - $contentstart;  

  $realcontent = substr($buf, $contentstart,
    $contentlength); 
  echo $realcontent; 
}

cyberlew15

Hey SmartGuys :mad: I was not stealing restricted content but quickly building a cheats database from there database the same cheats are on hundreds of websites hence them being public domain and for the really clever guy saying the code does'nt work it does work but i was wondering about ironing out innefficiencies and thats why it is in code critique rather than the problems section retard. :evilgrin:

BuzzLY

First, there is no need for hostilities. You posted your code and asked that it be critiqued. It was. Live with the critique, or don't post it here. Just because you didn't get the response you wanted ("yay, great code, you're a genius!!!"), doesn't mean you have to lash out.

Second, just because information is available "on hundreds of sites" doesn't make it right for you to grab it off of Game Revolutions' site. In fact, I have had a look at their Terms & Conditions (something you obviously haven't read):

Game Revolution User Agreement

.... yada, yada, yada... oh, here we go:

Use of Content

2.1 You acknowledge that the Service contains information, software, photographs, audio and video clips, graphics, links and other material (collectively, the "Content") that are protected by copyright, trademark or other proprietary rights of NRI or third parties. All Content on the Service is copyrighted as a collective work of NRI pursuant to applicable copyright law. You agree to comply with any additional copyright notices, information, or restrictions contained in any Content available on or accessed through the Service. Users of the Service may use the Content only for their personal, noncommercial use.

2.2 You may not modify, publish, transmit, transfer or sell, reproduce, create derivative works from, distribute, perform, display, or in any way exploit any of the Content, in whole or in part, except as expressly permitted in this Agreement. Content consisting of downloadable software may not be reverse engineered unless specifically authorized by the owner of the software's patent and/or copyright. You may post on the Service any Content owned by you (such as your original statements), Content for which you have received express permission from the owner and Content in the public domain. You assume all risk and responsibility for determining whether any Content is in the public domain. You grant to NRI the right to edit, copy, publish, distribute, translate and otherwise use in any medium any Content that you place on the Service without compensation to you. You represent and warrant that you are authorized to grant all rights set forth in the preceding sentence.

If you think that because "the same cheats are on hundreds of websites hence them being public domain," their lawyers would have a field day with you!

Third, your code is NOT correct. You use strpos() to create $contentend, which is either an integer showing the first position of the string, or "false." However, you compare $contentend with variations of "thanks to revolution," a string. It will always evaluate to false, so every if statement you have will result in a FALSE condition. I gave you some lines of code to fix that, and to condense your if statements to one condition. You chose to spit in my face.

If you ever want people to help you in the future, I would advise that you be a little more accepting of critique if you intend to post in the Code Critique forum.

Smart move, calling the moderator of the Code Critique forum a "retard." :rolleyes:

Gotta love the irony of your signature, though. That made me LOL.

elementaluk

cheat codes aren't really copyrighted.

Cheat codes are added to the game by the developers there for any cheat codes remain the copyright (if any) of the game developer so that cheat website has no right to state it owns the rights to these cheats UNLESS the cheat is a program created by that site.

Can't copyright what you don't own.

so cyberlaw15 would have a field day with the lawyers. Hit them with depression, emotional, psycotic and physical distress (due to them trying to sue you) during your counter sue.

P.S. if thats your second script then well done!, its quite good for your second attempt at PHP.

BuzzLY

A little late to the party, don't you think?

You might be correct, elemental. However, he is using code to automatically scrape information from their website. There is no guarantee that his code doesn't scrape copywritten information. It's the entire contents of the page that's copywritten, so if he is grabbing the whole page, then parsing through it to grab whatever he needs, he may still not have a right to do that, regardless of what he's actually displaying on his own site. Besides, the game publisher might own the rights to the cheats themselves, so he still has to deal with getting permission to display cheat codes on his site. If the site he is cannibalizing has permission, that permission does not make the cheat codes "public domain" for him to publish on his own site.

The other thing I take notice of is his attitude and rudeness with the members of this board. It is inexcusable, and I'm a little suprised that you elected to gloss over that and praise him for his coding ability. It's certainly a free society, and you can do what you want, of course. I'm just a little surprised that anyone would praise this guy. Unless, of course, you are actually him, having returned with a new nick 😃 LOL

elementaluk

yeah I know i'm a little late but I just love copyright topics 😛

that permission does not make the cheat codes "public domain" for him to publish on his own site

True, even though that cheat site does not own the copyright you would have to get rights from the developers and/or cheat code companys (e.g. action replay).

You acknowledge that the Service contains information, software, photographs, audio and video clips, graphics, links and other material (collectively, the "Content") that are protected by copyright, trademark or other proprietary rights of NRI or third parties. All Content on the Service is copyrighted as a collective work of NRI pursuant to applicable copyright law.

lol you can copyright links? thats new
Software: BS unless they made it,
Audio and Video clips: the cp of the game developers, they have rights not copyright.
Other material: its mine! all mine! my precious!! (sorry, seemed like the right thing to say)

It does say "or third parties" but thats a bit misleading as its not "or" its "is"

Yeah buzzly, your right, he's an ass. I agree. I was just stating its a no-bad script for his second attempt even if what it does is unjust.

Weedpacket

Originally posted by elementaluk
It does say "or third parties" but thats a bit misleading as its not "or" its "is"

" ...rights of NRI is third parties"? All it's saying is that NRI doesn't necessarily hold the copyright on each individual fragment, but that other parties may well be holding the copyright on the other bits; it also says "collective work", which has a specific meaning in relation to copyright - NRI did the work of building the collection, and the copyright for the collection is theirs.

elementaluk

yeah similar to that sorta.

its misleading as it signifys that atleast some cheats, video, audio and software is copyright NRI which is untrue.

There for it should really state its not theirs but they do have the rights to display/use this content as to not mislead anyone that would like to reproduce anything on that site.

planetsim

Originally posted by cyberlew15
cheats database from there database the same cheats are on hundreds of websites hence them being public domain

I dont know where any Software company that creates a game or any software in that matter as public domian. If your saying the cheats are I believe they are part of the software and are owned by the Software Company, if the cheats are public domain that would make the game itself public domain :glare:

Weedpacket

Originally posted by elementaluk
its misleading as it signifys that atleast some cheats, video, audio and software is copyright NRI which is untrue.

You sure about that? What about all the site design elements (it's not uncommon for copyright on design to be transferred from designer to client as part of the contract - partly to cover the situations where the designer used design elements that are ™ the client)? Reviews (I picked one at random, and it was apparently by a staff member)? Information and other materials? Read the whole excerpt you quote!