displaying data into a table

corruption

i'm trying to take some data out of a database and put it into a neat table. I want the table to consist of a different persons name in each new <td></td> tags. Here's the code that i have

//script to display the news in html format or something.
$sql    =    "SELECT * FROM makeout ORDER BY first_name DESC";
$result    =    mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($result) > 0)
    {
    ?>
    <body bgcolor="#FFFFFF" text="#000000">
    <table width="90%" align="center" cellpadding="0" cellspacing="0" bordercolor="#660099" border="2">
	<tr><td align="center" width="100px">First Name</td>
	<?php 
    while($row = mysql_fetch_array($result)) 
        { 
            $lname    =    $row['last_name']; 
			$fname    =    $row['first_name'];

        ?> 


        <td><?php echo $fname; ?></td><td><?php echo $fname;?></td>
		<tr>

		</tr>

        </table>


        <?php 
    } 
?> 
    </body>
?>

the data is at http://www2.truman.edu/~d1514/makeout/makeout.php

rachel2004

I cleaned it up a little bit, but this should give you what you're looking for:

<?php

//script to display the news in html format or something.
$sql    =    "SELECT * FROM makeout ORDER BY first_name DESC";
$result    =    mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($result) > 0)
{
?>
    <body bgcolor="#FFFFFF" text="#000000">
    <table width="90%" align="center" cellpadding="0" cellspacing="0" bordercolor="#660099" border="2">
    <tr><td align="center" width="100px">First Name</td>
    <?php 
    while($row = mysql_fetch_array($result)) 
    {
        echo "<td>";
        echo $row['first_name']." ".$row['last_name'];
        echo "</td>";
    }?>
    <tr>
    </tr>
    </table>
<?php 
} 
?> 
</body>

You have an extra <tr> tags right above your </tr> and </table>. It doesn't seem to be there for any reason that I could see... you may want to just delete it.

nemonoman

I've cleaned up a little more, this time with rows better managed (<tr> and </tr> tags.


<tr><td align="center" width="100px">First Name</td></tr> 
<?php  
while($row = mysql_fetch_array($result))  

    { 
        echo "<tr><td>"; 
        echo $row['first_name']." ".$row['last_name']; 
        echo "</td></tr>"; 
    }?> 
    </table>

corruption

it still looks the same to me. i don't know why though.

nemonoman

If 'it still looks the same', that means you haven't used either my code or Rachels.

Your code yields a mess: you add an end table tag</table> with every iteration of your while loop (which is a lot like adding close parentheses that aren't strictly speaking needed)))))))))))))))))))))))), and your <td> and<tr> tags are also wildly out of place.

Rachel's code provides a single long row of cells containing names.

My code provides that each name cell appears in its own row.

The results of the either new code will not 'look the same' as your old code, unless, as seems likely from the oddities in your example code, you have other vagaries in the HTML associated with this code.

rachel2004

Originally posted by corruption
it still looks the same to me. i don't know why though.

If the problem area is what you had originally posted and your stated goal was to use a bunch of <td></td> tags, then you should be seeing a line (maybe a very long line) of names this Friday evening.

You need to check the other parts of not just your PHP code, but your HTML to make sure tags match up. I'm only working with what you've shown me, so I have to assume that the rest of your page is working as it should.

corruption

<html>
<head>
<title>Makeout List</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<?
include 'connect.php';
include 'logincheck.php';
//script to display the news in html format or something.
$sql = "SELECT * FROM makeout ORDER BY first_name DESC";
$result = mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($result) > 0)
{
?>
<body bgcolor="#FFFFFF" text="#000000">
<table width="700px" align="center" padding="10px" border="medium" bordercolor="#999999">

<?php 
while($row = mysql_fetch_array($result)) 
    { 
        $lname    =    $row['last_name']; 
		$fname    =    $row['first_name'];

        ?> 

        <tr>
		<td width="50px"></td> 
        <td padding="5px"><?php echo $fname; ?></td>

		</tr>

        </table>


        <?php 
    } 
?> 
    </body>
<?php
}
else
{
echo "No rows returned!";
}

?>
</html>

here's what i have

nemonoman

Allow me to suggest with all the respect you deserve that you actually employ the code written by Rachel, or as amended by me, and note that the results are far more likely to provide a satisfactory display than the mess you have just shared with us.

Why would you insist on putting </table> tags inside the while loop designed to create the cells of that table?

Neither Rachel's code or my code does such a thing.

If you want to insist on using your own broken code, you might at least not complain to those who have provided clean code. You might in fact try to understand the help of those who have wasted their time working on your behalf.

corruption

i apologize it seems that i've changed the wrong file, or something so the changes weren't realized. I don't know what happened, but either way, i appreciate your help. it seems rachels code is more along the lines of what i want so i need to get it to output the data currently.

corruption

awesome you guys have been very helpful. thank you...one more thing a little more on the database side...

i have the two tables

1) mo_people

| first_name | last_name | email_address etc.

2) mo_places

        | first_name | last_name |

place1 |
place2|

that's what i want table mo_places to act as. I need to put a list of places in the first left hand column of the table we've been working on and allow people to select the places they've been via a form
i'm not sure how to get the two tables linked in that respect or how to add the places.

corruption

this is the code that i have set up for us to Add places....

<?php
include 'db.php';
//convert into variables
$place = $_POST['place'];
if (!get_magic_quotes_gpc()) {
  $place = mysql_escape_string($place);
  }
$sql= mysql_query("ALTER TABLE mo_places ADD $place char(1)") or die(mysql_error());
if(!$sql){
	echo 'There is a problem adding your place, contact your webmaster.';
} else {
 	echo 'Your place has been added successfully.';
	};
?>

it seems to add the places only if there are no spaces in the name. I am not sure how to get the name to be submitted for those with spaces in the name of the place.

nemonoman

Let me get this right...you're going to ALTER a TABLE when someone wants to enter a new place?

You going to create a new 1 character column each time someone wants enter a new place?

Since I don't know you, I can't say this for sure, but if one of my programmers were doing this, I would say s/he was certifiably nuts.

Perhaps you'd like to explain this approach so we can better support your efforts?

PS the reason why this SQL fails is that you need to put '$place' in quotes.

nemonoman

What you need is three tables;

PErson
Firstname/lastname etc
Person.id
IDEALLY you would assign a unique numeric id to each row

Place
PlaceID
PlaceName, etc
IDEALLY you would assign a unique numeric id to each row

personPlace
PersonID
PlaceID

This relates the two tables above.

SELECT person.firstname, place.placename
FROM person, place, personplace
WHERE person.personid=personplace.personid
AND place.placeid=personplace.place.id

WHERE person.ID

corruption

ok here's my overall goal....

a) a person can login therefore i need the

table PERSON with their information. Then once logged in it should display all the people involved in the first row accross in different columns until there are no more people.

The display should have the places in the first column on the left side, and under each person a check mark of some sort signifying that the task has been completed.

Additionally the people need be able to update their records. So, I would setup a link that enabled them to scroll through the different places and using a form with checkboxes , check off the newly completed tasks. Submit the form then update.

nemonoman

that's great. Let us know how it goes!

corruption

I'm getting close, i've got a problem when trying to extract the results from a different table. I thought that i could use the same variables. In which case they would be redifined...


<?php 
    while($row = mysql_fetch_array($result)) 
    {
        echo "<td>";
        echo $row['first_name']." ".$row['last_name'];
        echo "</td>";
    }
	?>
    </tr>
	<tr><td align="center">Places</td>
	 <?php 
	 //script to display the news in html format or something.
    $sql    =    "SELECT * FROM mo_places ORDER BY placeID ASC";
    $result    =    mysql_query($sql) or die(mysql_error());
    if(mysql_num_rows($result) > 0)
    {
    while($row = mysql_fetch_array($result)) 
    {
        echo "<tr><td>";
        echo $row['place'];
        echo "</td></tr>";
    }
	?>


</td></tr>
<tr><td><a href="addplace.html"><input type="button" value="Add Place"></a></tr>
</table>
<?php 
} 
    else
    {
    echo "No rows returned!";
    }

?>

everything up the the second time i run a query works.