want to regist with email

devil_online

Hi I have a script of login with to fields (name and pass). However I ad one more field (email). What changes should I made to put the field work. Thanks

here is the code that i'm using: (as you can see i already add the field in html)

<?
session_start();
include("database.php");

/**
 * Returns true if the username has been taken
 * by another user, false otherwise.
 */
function usernameTaken($username){
   global $conn;
   if(!get_magic_quotes_gpc()){
      $username = addslashes($username);
   }
   $q = "select username from users where username = '$username'";
   $result = mysql_query($q,$conn);
   return (mysql_numrows($result) > 0);
}

/**
 * Inserts the given (username, password) pair
 * into the database. Returns true on success,
 * false otherwise.
 */
function addNewUser($username, $password){
   global $conn;
   $q = "INSERT INTO users VALUES ('$username', '$password')";
   return mysql_query($q,$conn);
}

/**
 * Displays the appropriate message to the user
 * after the registration attempt. It displays a
 * success or failure status depending on a
 * session variable set during registration.
 */
function displayStatus(){
   $uname = $_SESSION['reguname'];
   if($_SESSION['regresult']){
?>

<h1>Registered!</h1>
<p>Thank you <b><? echo $uname; ?></b>, your information has been added to the database, you may now <a href="main.php" title="Login">log in</a>.</p>

<?
   }
   else{
?>

<h1>Registration Failed</h1>
<p>We're sorry, but an error has occurred and your registration for the username <b><? echo $uname; ?></b>, could not be completed.<br>
Please try again at a later time.</p>

<?
   }
   unset($_SESSION['reguname']);
   unset($_SESSION['registered']);
   unset($_SESSION['regresult']);
}

if(isset($_SESSION['registered'])){
/**
 * This is the page that will be displayed after the
 * registration has been attempted.
 */
?>

<html>
<title>Registration Page</title>
<body>

<? displayStatus(); ?>

</body>
</html>

<?
   return;
}

/**
 * Determines whether or not to show to sign-up form
 * based on whether the form has been submitted, if it
 * has, check the database for consistency and create
 * the new account.
 */
if(isset($_POST['subjoin'])){
   /* Make sure all fields were entered */
   if(!$_POST['user'] || !$_POST['pass']){
      die('You didn\'t fill in a required field.');
   }

   /* Spruce up username, check length */
   $_POST['user'] = trim($_POST['user']);
   if(strlen($_POST['user']) > 30){
      die("Sorry, the username is longer than 30 characters, please shorten it.");
   }

   /* Check if username is already in use */
   if(usernameTaken($_POST['user'])){
      $use = $_POST['user'];
      die("Sorry, the username: <strong>$use</strong> is already taken, please pick another one.");
   }

   /* Add the new account to the database */
   $md5pass = md5($_POST['pass']);
   $_SESSION['reguname'] = $_POST['user'];
   $_SESSION['regresult'] = addNewUser($_POST['user'], $md5pass);
   $_SESSION['registered'] = true;
   echo "<meta http-equiv=\"Refresh\" content=\"0;url=$HTTP_SERVER_VARS[PHP_SELF]\">";
   return;
}
else{
/**
 * This is the page with the sign-up form, the names
 * of the input fields are important and should not
 * be changed.
 */
?>

<html>
<title>Registration Page</title>
<body>
<h1>Register</h1>
<form action="<? echo $HTTP_SERVER_VARS['PHP_SELF']; ?>" method="post">
<table align="left" border="0" cellspacing="0" cellpadding="3">
<tr><td>Username:</td><td><input type="text" name="user" maxlength="30"></td></tr>
<tr><td>Password:</td><td><input type="password" name="pass" maxlength="30"></td></tr>
<tr><td>Email:</td><td><input type="text" name="email" maxlength="30"></td></tr>
<tr><td colspan="2" align="right"><input type="submit" name="subjoin" value="Join!"></td></tr>
</table>
</form>
</body>
</html>


<?
}
?>

swon

if you want new field email to insert in the database make sure that this field exist.

if it does change the function to following:

function addNewUser($username, $password){
global $conn;
$q = "INSERT INTO users VALUES ('$username', '$password','$email')";
return mysql_query($q,$conn);
}

if it should be a mandatory field, change this part

<?
if(isset($POST['subjoin'])){
/ Make sure all fields were entered /
if(!$POST['user'] || !$_POST['pass']){
die('You didn't fill in a required field.');
}
?>

<?
if(isset($POST['subjoin'])){
/ Make sure all fields were entered /
if(!$POST['user'] || !$_POST['pass'] || !$POST['email']){
die('You didn't fill in a required field.');

and then change this line:

<?
$SESSION['regresult'] = addNewUser($POST['user'], $md5pass);
?>

<?
$SESSION['regresult'] = addNewUser($POST['user'], $md5pass,$_POST['email']);
?>

I didn't check it out but this should work, i hope ;-)

devil_online

thanks but it gives me this error:

We're sorry, but an error has occurred and your registration for the username sd, could not be completed.
Please try again at a later time.

I think it's because i've create a new field (email), because when i create this new field it won't let me register even befor make those changes.
Thanks

swon

Sorry, forget to change this one correctly ($email was not in the function):
<?

function addNewUser($username, $password, $email){
global $conn;
$q = "INSERT INTO users VALUES ('$username', '$password', '$email')";
return mysql_query($q,$conn);
}

devil_online

it work. thanks very much.