Whats wrong with my script

[Cpkid91]

Whats wrong with my script:

<?PHP
$hour = date("G")
if ($hour = "0" || $hour = "6" || $hour = "12" || $hour = "18"){
#do stuff
}
if ($hour = "1" || $hour = "7" || $hour = "13" || $hour = "19"){
#do stuff
}
if ($hour = "2" || $hour = "8" || $hour = "14" || $hour = "20"){
#do stuff
}
if ($hour = "3" || $hour = "9" || $hour = "15" || $hour = "21"){
#do stuff
}
if ($hour = "4" || $hour = "10" || $hour = "16" || $hour = "22"){
#do stuff
}
if ($hour = "5" || $hour = "11" || $hour = "17" || $hour = "23"){
#do stuff
}
?>

Thanks planetsim

[planetsim]

Your using = instead of ==

[TheDefender]

Just to clarify which = planetsim is referring to:

<?PHP 
$hour = date("G") 
if ($hour == "0" || $hour == "6" || $hour == "12" || $hour == "18"){ 
#do stuff 
} 
if ($hour == "1" || $hour == "7" || $hour == "13" || $hour == "19"){ 
#do stuff 
} 
if ($hour == "2" || $hour == "8" || $hour == "14" || $hour == "20"){ 
#do stuff 
} 
if ($hour == "3" || $hour == "9" || $hour == "15" || $hour == "21"){ 
#do stuff 
} 
if ($hour == "4" || $hour == "10" || $hour == "16" || $hour == "22"){ 
#do stuff 
} 
if ($hour == "5" || $hour == "11" || $hour == "17" || $hour == "23"){ 
#do stuff 
} 
?> 

The first one is fine, where you are declaring your $hour variable.

[Cpkid91]

it still says error on line 3

[Drakla]

Put a semicolon after $hour = date("G"); <-

Also if you're using string constants try and use single quotes instead of double as php won't check if they contain variables that need parsing.

[TheDefender]

:queasy: Sorry, I missed that on my copy and paste...

[Drakla]

I had a 45 minute code-blindness session yesterday screaming because something wouldn't work and it turned out I'd put a semicolon after a for loop as in

for($i=0; $i<$something; $i++);
{
//intended code here
}

So I'm scannin' like a leopard at the moment - damn those automatic hands with their awful AI autocomplete.

[Cpkid91]

It says there is now an error on line 5 and thats just a '}'

[Drakla]

Are you copying this verbatim? Have you just got the #do stuff in the conditions for now?

The line php reports errors on is sometimes linked to the line above. Is the error "Unexpected }" by any chance?

Try changing the comment styles to // instead of # as I've read somewhere that it's being recommended not to use Unix style comments. If it doesn't work put in your error messages as it helps.

[Paragon]

Don't gotta put anything in qoutes unless its a string.

You also needed a ";" after the date.

<?PHP 
$hour = date("G");
if (($hour == 0) || ($hour == 6) || ($hour == 12) || ($hour == 18)){ 
#do stuff
} 
if (($hour == 1) || ($hour == 7) || ($hour == 13) || ($hour == 19)){ 
#do stuff
} 
if (($hour == 2) || ($hour == 8) || ($hour == 14) || ($hour == 20)){ 
#do stuff
} 
if (($hour == 3) || ($hour == 9) || ($hour == 15) || ($hour == 21)){ 
#do stuff
} 
if (($hour == 4) || ($hour == 10) || ($hour == 16) || ($hour == 22)){ 
#do stuff
} 
if (($hour == 5) || ($hour == 11) || ($hour == 17) || ($hour == 23)){ 
#do stuff
} 
?>