Sql insert with for statement

[SQHell]

Is this correct?

$PropertyID = mysql_insert_id(); 

for ($i = 1; $i <= $numbullets; $i++) 
{ 
$bullet_t = addslashes($bullet.$i); 
$sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'"; 
$query2 = mysql_query($sql2) or die("Cannot query the database.<br>" . mysql_error()); 
} 

Nothing is insert and no error is given.

The text boxes on the page are created using

<?php 
             for ($i = 1; $i <= $numbullets; $i++) 
                { 
                   echo "<input type=\"text\" name=\"bullet$i\"><br>"; 
                } 
             ?> 

This is why I am using addslashes($bullet.$i);

And the form is posted to itself. Any ideas what is wrong?

[Pig]

Try echoing out $sql2 to see if it matches what you expect.

[SQHell]

Sorry I don't understand what you mean.

[Pig]

You query is not returning the results you expect, so either the process you are using to build your query, or the information it is being fed, is wrong. As you are running through the loop, print the query instead of running it.

$PropertyID = mysql_insert_id();

for ($i = 1; $i <= $numbullets; $i++)

{

$bullet_t = addslashes($bullet.$i);

$sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'";

echo($sql2 . "<br>");
}

Check the printed queries to see if they look like you would expect them to. Check if the variables are somehow unexpected, etc.

[SQHell]

Thanks Pig! Will try that now.

[rachel2004]

Pig may have already answered your question... yes, you need to check what is contained in $sql2.
Here is alternate way of writing your code:

<?php
$PropertyID = mysql_insert_id(); 
$j = 1;
for ($i = 0; $i < $numbullets; $i++) 
{ 
    $bullet_t = $bullet.$j; 
    $sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'"; 
    $query2 = mysql_query($sql2) 
        or die("Cannot query the database.<br>" . mysql_error()); 
    $j++;
}
?>


<?php
$k = 1;
for ($i = 0; $i < $numbullets; $i++) 
{
    echo '<input type="text" name="bullet.$k"><br>';
    $k++; 
} 
?>  

[SQHell]

Hmmm, I can't seem to get your solution to work Rachel 🙁

I tried the insert with just and not with the for statement

$bullet_t = addslashes($bullet1);

and it worked and inserted the first text box details.

So it must be something to do with

$bullet_t = addslashes($bullet.$i);

Is the last part correct?

[rachel2004]

Okay, try:

$bullet_t = addslashes($bullet.$j);

Notice I used the variable $j, though. Let me know if it works

[SQHell]

Nope still nothing. Why do you use an extra varible and then increment it?

My original for statement to display the text boxes works fine. Look at the source once the page is displayed in the browser each box is correctly numbered bullet1, bullet2 etc. So it is strange that the Insert for doesn't work.

[SQHell]

BTW thanks for the help!!

[SQHell]

Some progress but no in the direction I wanted!

I changed $numbullets to 3 so it was

for ($i = 0; $i < $3; $i++)  

{  

    $bullet_t = $bullet.$j;  

    $sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'";  

    $query2 = mysql_query($sql2)  

        or die("Cannot query the database.<br>" . mysql_error());  

    $j++; 
} 
?> 

And while it now does insert a value it just enters

1
12
123

for each record no matter what I enter into the text field.

:queasy:

[rachel2004]

Can you tell me what you get with this:

$j = 1;
for ($i = 0; $i < 3; $i++)  

{  

    $bullet_t = $bullet.$j;  

     echo $bullet_t."<br>";
    $j++; 
} 
?>

[SQHell]

1231
12312
123123

:queasy:

And that was with putting

q
w
e

in the text box!!

[rachel2004]

This part:
addslashes($bullet.$i)

is not the same as

the $bullet in your form.

[SQHell]

Well there is no other $bullet

And I am not using addslashes($bullet.$i) anymore

:bemused:

[rachel2004]

This should work:

<?php
$bullet = array();
for ($i = 0; $i < $numbullets; $i++) 
{
    echo "<input type=\"text\" name=\"bullet[$i]\"><br>";
} 
?>

<?php
$PropertyID = mysql_insert_id(); 

for ($i = 0; $i < $numbullets; $i++) 
{ 
    $bullet_t = addslashes($_POST["bullet[$i]"]); 
    $sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'"; 
    $query2 = mysql_query($sql2) 
        or die("Cannot query the database.<br>" . mysql_error());    

}
?>

[SQHell]

Thanks for the help. I will try it in the morning.

Cheers Rachel🙂

[SQHell]

🙁 Still doesn't work

The html text boxes are created on the page and each called

bullet[1], bullet[2] etc

Yet when I post the data isn't inserted. I still have it to echo the results and it says

1
12
123

But checking the table each text box has been created on a seperate row. But there is no data in them🙁

[rachel2004]

Could you post more of your code as you have it now?

[SQHell]

Thanks for talking a look🙂

<?php 

 // Initialize Session 
      session_start(); 

 // Check for previous authentication 
      if ( !isset($_SESSION['auth']) ) 
      { 
           $loc = 'login.php?reason=login'; 
           header("location:$loc"); 
           exit; 
      }

$title = "Add a property";
include "../header.php";
include "../db.php";

$numbullets = $_POST["numbullets"];

if(!empty($Ref)) {
$Ref = addslashes($Ref);
$Name = addslashes($Name);
$Title = addslashes($Title);
$Location = addslashes($Location);
$Proptype = addslashes($Proptype);
$Price = addslashes($Price);
$No_bed = addslashes($No_bed);
$No_bath = addslashes($No_bath);
$Plotsize = addslashes($Plotsize);
$Descript = addslashes($Descript);
$numberofbullets = $_POST["nbullets"];

$cxn = @ConnectToDb($dbServer, $dbUser, $dbPass, $dbName);

$sql = "INSERT INTO properties SET Ref='$Ref', Name='$Name', Title='$Title', Location='$Location', Proptype='$Proptype', Price='$Price', No_bed='$No_bed', No_bath='$No_bath', Plotsize='$Plotsize', Descript='$Descript'";
$query = mysql_query($sql) or die("Cannot query the database.<br>" . mysql_error());

$PropertyID = mysql_insert_id();  

for ($i = 0; $i < $numberofbullets; $i++)  

{  

    $bullet_t = addslashes($_POST["bullet[$i]"]);  

    $sql2 = "INSERT INTO bullets SET bullet_t='$bullet_t', PropID='$PropertyID'";  

    $query2 = mysql_query($sql2)  

        or die("Cannot query the database.<br>" . mysql_error());     

} 

?>

<body bgcolor="#FFFFFF" text="#000000">
<meta HTTP-EQUIV="REFRESH" content="5; url=preupload.php?id=<?php echo $PropertyID;?>">
<?php 

$j = 1; 
for ($i = 0; $i < 3; $i++)   

{   

    $bullet_t = $bullet_t.$j;   

     echo $bullet_t."<br>"; 
    $j++;  

}  

} else {
?>
<table width="630" border="0" cellpadding="0" cellspacing="2">
  <tr> 
    <td>
      <table width="100%" border="0" cellpadding="0" cellspacing="5">
        <form name="addproperty" method="post" action="<?php echo $PHP_SELF; ?>">
          <tr> 
            <td width="212" valign="top" class="bodytext"><b>Property Reference:</b></td>
            <td valign="top" width="399" class="bodytext"> 
              <input type="text" name="Ref" value="" maxlength="50">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Name:</b></td>
            <td valign="top" class="bodytext"> 
              <input type="text" name="Name" value="" maxlength="50" size="50">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Title:</b></td>
            <td valign="top" class="bodytext"> 
              <input type="text" name="Title" value="" maxlength="50" size="50">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Location:</b></td>
            <td valign="top" class="bodytext"> 
              <input type="text" name="Location" value="">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Property type:</b></td>
            <td valign="top" class="bodytext"> 
              <select name="Proptype">
                <option>Apartment</option>
                <option>Villa</option>
              </select>
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Price:</b></td>
            <td valign="top" class="bodytext"> 
              <input type="text" name="Price" value="">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>N<sup>o</sup>. of Bedrooms:</b></td>
            <td valign="top" class="bodytext"> 
              <select name="No_bed">
                <option>1</option>
                <option>2</option>
                <option>3</option>
                <option>4</option>
                <option>5</option>
                <option>6</option>
              </select>
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>N<sup>o</sup>. of Bathrooms:</b></td>
            <td valign="top" class="bodytext"> 
              <select name="No_bath">
                <option>1</option>
                <option>2</option>
                <option>3</option>
                <option>4</option>
                <option>5</option>
                <option>6</option>
              </select>
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Plot size:</b></td>
            <td valign="top" class="bodytext"> 
              <input type="text" name="Plotsize" value="">
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Description:</b></td>
            <td valign="top" class="bodytext"> 
              <textarea name="Descript" cols="65" rows="10"><?php echo $Descript; ?></textarea>
            </td>
          </tr>
          <tr> 
            <td valign="top" class="bodytext"><b>Bullet points:</b></td>
            <td valign="top" class="bodytext"> 

			<?php 
			$bullet = array(); 
			for ($i = 0; $i < $numbullets; $i++)  
			{ 
			echo "<input type=\"text\" name=\"bullet[$i]\"><br>"; 
			}  
			?>   

        </td>
      </tr>
      <tr align="center"> 
        <td colspan="2"> <br>
          <input type="submit" name="Submit" value="Add property">
		  <input type="hidden" name="nbullets" value="<?php echo $numbullets; ?>">
	<input type="button" name="Cancel" value="Cancel" onclick="java_script_:history.back();return false;"/>
        </td>
      </tr>
    </form>
  </table>
</td>
  </tr>
</table>
</body>
</html>
<?php
}
?>