[Resolved] Session variables not passing to the same page?

alexboyer

Hello,

I am having a problem getting session variables to pass to a page... Basically I set up all my variables, then create a form that submits a username/pass using POST which gets checked against a database. The session is the same as 'authuser'. The weird thing is that it worked fine once. Then I used someone's suggestion of doing the session_destroy() and now it's not working...

Please help.

This is the first part of the file which I believe is the problematic part, but I'm not sure.

<?php 
session_start();
$_SESSION['authuser']=$authuser;
$_SESSION['authpass']=$authpass;
$authuser=$_POST['authuser'];
$authpass=$_POST['authpass'];
include("dbinfo.inc.php");
$submit=$_POST['submit'];
$sort=$_GET['sort'];
$order=$_GET['order'];
if(!$order){
$order="ASC";
}
if(!$sort){
$sort="firstname";
}
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM contest ORDER BY $sort $order";
$result=mysql_query($query);
$num=mysql_numrows($result);
$querypass="SELECT * FROM passwords WHERE authuser='$authuser' AND authpass='$authpass'";
$resultpass=mysql_query($querypass);
$numpass=mysql_num_rows($resultpass);
mysql_close();
?>

Then I start in with the if/elseif commands
the first if

<? if($numpass=="1"){?>
<? session_start();
echo "".session_id()."";
?>
<table border="0" align="center" cellpadding="0" cellspacing="0">
<tr>
  </tr>
<tr>
  <td valign="top"><br>
      <div align="center" class="style1"><span class="style2">Current List</span><br>
        <br>
      </div></td>
</tr>
<tr>
  <td valign="top">
    <form name="form1" method="GET" action="contest_results.php">
    	<select name="sort" size="1">
        	<option value="">Select  

            <option value="firstname">First Name
			<option value="lastname">Last Name
            <option value="email">E-Mail
            <option value="age">Age
		</select>
        <input name="Submit" type="submit" class="redform" value="Order List">
      </form>
<div align="center"><a href="logout.php">Logout</a></div>
</td>
</tr>
<tr>
  <td valign="top"><? echo " Sorting by $sort.&nbsp;&nbsp;<a href=\"contest_results.php?sort=$sort&order=ASC\"><img src=\"../graphics/nav_buttons/up_cc0000.gif\" width=\"5\" height=\"5\" border=0></a>&nbsp;&nbsp;<a href=\"contest_results.php?sort=$sort&order=DESC\"><img src=\"../graphics/nav_buttons/down_cc0000.gif\" width=\"5\" height=\"5\" border=0></a>"?></td>
</tr>
<tr>
<td valign="bottom">
<img src="../graphics/bkgd/1px_333.gif" width="100%" height="5"></td>
</tr>
<td>
<table align="left" width="350" border="0" cellspacing="0" cellpadding="0">
<?
$i=0;
while ($i < $num) {
$name=mysql_result($result,$i,"firstname");
$namelast=mysql_result($result,$i,"lastname");
$address_1=mysql_result($result,$i,"address_1");
$city=mysql_result($result,$i,"city");
$state=mysql_result($result,$i,"state");
$country=mysql_result($result,$i,"country");
$phone=mysql_result($result,$i,"phone_number");
$email=mysql_result($result,$i,"email");
$zip=mysql_result($result,$i,"zip");
$age=mysql_result($result,$i,"age");
$comments=mysql_result($result,$i,"comments");
?>
<tr>
  <td rowspan="3" background="../graphics/bkgd/1px_333.gif"><img src="../graphics/bkgd/1px_trans.gif" width="10" height="100%"></td>
  <td><img src="../graphics/bkgd/1px_333.gif" width="100%" height="5"></td>
  <td rowspan="3" background="../graphics/bkgd/1px_333.gif"><img src="../graphics/bkgd/1px_trans.gif" width="10" height="100%"></td>
</tr>
<tr>
  <td width="330" bgcolor="#666666">
    <table width="100%"  border="0" cellspacing="0" cellpadding="5">
      <tr>
        <td><?php echo "$name $namelast - ";
				if(!$age){
					echo "Did not give age information.<br>";
					}
				else{
					echo "$age years old.<br>";
					}
				echo "$address_1<br>$city, $state&nbsp;&nbsp;$zip<br>$phone<br><a href=\"mailto:$email\">$email</a>"?></td>
      </tr>
	  <tr><td>
	  <? echo"<div class=\"whitetiny\"><strong>Comments</strong></div>$comments" ?>
	  </td>
	  </tr>
    </table></td>
</tr>
<tr>
  <td>
<img src="../graphics/bkgd/1px_333.gif" width="100%" height="5"></td>
</tr>
<?
++$i;
} 
?>
</table>
</td>
</tr>
</table>
<br>

Then I have a user/pass form that gets submitted if the user/pass variables have not been assigned:

<? }

elseif(!$authuser || !$authpass){?>
<br><br><br>
<form name="form2" method="POST" action="contest_results.php"><table width="350" border="0" align="center" cellpadding="0" cellspacing="0" bgcolor="#666666">
<tr>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
</tr>
<tr>
<td width="50%">



  <div align="right">Username</div></td>
<td><input name="authuser" type="text" id="authuser" size="23" maxlength="23"></td>
</tr>
<tr>
  <td colspan="2"><img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5"></td>
  </tr>
<tr>
  <td><div align="right">Password</div></td>
  <td><input name="authpass" type="password" id="authpass" size="25" maxlength="25"></td>
</tr>
<tr>
  <td colspan="2"><div align="center">
    <input name="Submit" type="submit" class="redform" value="Submit">
    <input name="Reset" type="reset" class="redform" value="Reset"> 
    <img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5">    </div></td>
</tr>
</table>
</form>

Then I have an elseif in case the user/pass combo was incorrect.

<? }

elseif($numpass=="0"){?>
<br><br><br>
<form name="form2" method="POST" action="contest_results.php">
  <table width="350" border="0" align="center" cellpadding="0" cellspacing="0" bgcolor="#666666">
    <tr>
      <td colspan="2">Something was entered incorrectly... </td>
    </tr>
    <tr>
      <td width="50%"><div align="right">Username</div></td>
      <td><input name="authuser" type="text" id="authuser" size="23" maxlength="23"></td>
    </tr>
    <tr>
      <td colspan="2"><img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5"></td>
    </tr>
    <tr>
      <td><div align="right">Password</div></td>
      <td><input name="authpass" type="password" id="authpass" size="25" maxlength="25"></td>
    </tr>
    <tr>
      <td colspan="2"><div align="center">
          <input name="Submit" type="submit" class="redform" value="Submit">
          <input name="Reset" type="reset" class="redform" value="Reset">
          <img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5"> </div></td>
    </tr>
  </table>
</form>

Then I have a default for every other outcome...

<? }
else{?>
<br><br><br>
<form name="form2" method="POST" action="contest_results.php">
  <table width="350" border="0" align="center" cellpadding="0" cellspacing="0" bgcolor="#666666">
    <tr>
      <td width="50%" height="26"><div align="right">Username</div></td>
      <td><input name="authuser" type="text" id="authuser" size="23" maxlength="23"></td>
    </tr>
    <tr>
      <td colspan="2"><img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5"></td>
    </tr>
    <tr>
      <td><div align="right">Password</div></td>
      <td><input name="authpass" type="password" id="authpass" size="25" maxlength="25"></td>
    </tr>
    <tr>
      <td colspan="2"><div align="center">
          <input name="Submit" type="submit" class="redform" value="Submit">
          <input name="Reset" type="reset" class="redform" value="Reset">
          <img src="../graphics/bkgd/1px_trans.gif" width="100%" height="5"> </div></td>
    </tr>
  </table>
</form><? }

 ?>

leatherback

Hi,

It si abit hard to tell where the problem is, since you only say "It is not working". What is not working for the sessions, and when doesn't it work? Also, you talk about session_destroy, which I do not see in your code.

I think this section might be giving you trouble:

$_SESSION['authuser']=$authuser;
$_SESSION['authpass']=$authpass;
$authuser=$_POST['authuser'];
$authpass=$_POST['authpass'];

If the $_POST[authuser] is empty, there will not be anything in the session.

alexboyer

Sorry about not specifying. The problem is that when I enter the username/password, it brings up the page I want just fine... But whenever I use the sort options, or click another link(since they all go back to the same page), it sends me back to the login page. It's like the authuser and authpass variables are carried over once from the POST action, but then they're just dropped for some reason.

The session_destroy() is on a different page.

<?php
session_start();
unset($SESSION['authuser']);
unset($SESSION['authpass']);
session_destroy();
header("Location: ../index.html");
?>

alexboyer

Ok, I just found the exact error at the bottom of the page...

Warning: Unknown(): Your script possibly relies on a session side-effect which existed until PHP 4.2.3. Please be advised that the session extension does not consider global variables as a source of data, unless register_globals is enabled. You can disable this functionality and this warning by setting session.bug_compat_42 or session.bug_compat_warn to off, respectively. in Unknown on line 0

alexboyer

I think I may have found part of the problem.... I found this warning on the PHP website....

Caution
Do NOT unset the whole $SESSION with unset($SESSION) as this will disable the registering of session variables through the $_SESSION superglobal.

That may be why it stopped working after I used that unset and destroy command...... How do I re-enable this? Do I need to ssh in to the server?

alexboyer

Ok well I fixed it.... I'm not sure why this worked, but it's working....

I changed

$authuser=$POST['authuser'];
$authpass=$POST['authpass'];
$SESSION['authuser']=$authuser;
$SESSION['authpass']=$authpass;

if($POST["authuser"])
{
$authuser=$POST["authuser"];
$authpass=$POST["authpass"];

}
elseif($SESSION["authuser"])
{
$authuser=$SESSION["authuser"];
$authpass=$SESSION["authpass"];
}

alexboyer

SOLUTION: Like the warning says, do not use the
unset($SESSION) command! It causes the $SESSION variable to be disabled... I had to SSH in to the server and change my php.ini file because of it. After doing that, I got rid of the unset($SESSION) section and changed the logout page to session_start(); session_destroy(); and now it works fine... I get a new session ID when I go back to the page and the username/password variables carry over until I logout or it times out.