Modern Art Onion Style.

onion2k

Some annoying points in the code due to my host still using GD1.6 ...

<?php

srand((double)microtime()*1000000);

$output = imagecreate(400,400);

$white = imagecolorallocate($output,255,255,255);
$black = imagecolorallocate($output,0,0,0);
$fill[] = imagecolorallocate($output,255,0,0);
$fill[] = imagecolorallocate($output,255,255,0);
$fill[] = imagecolorallocate($output,0,0,255);

imagefill($output,0,0,$white);
$segments = rand(1,6);

$building = 0;
$counter = 0;

while ($building == 0) {

	if ($c++ > 20 and count($block) > 0) { $building = 1; }
	if (count($block) >= $segments)      { $building = 1; }

	$x = rand(1,39)*10;
	$y = rand(1,39)*10;
	$w = rand(3,10)*10;
	$h = rand(3,10)*10;

	$add = 0;

	if (is_array($block)) {
		foreach ($block as $bl) {

			if (  !( ($x     >=$bl['x']) and ($x     <=($bl['x']+$bl['w'])) )
			  and !( (($x+$w)>=$bl['x']) and (($x+$w)<=($bl['x']+$bl['w'])) )
			  and !( ($x     <=$bl['x']) and (($x+w) >=($bl['x']+$bl['w'])) )
			  and !( ($y     >=$bl['y']) and ($y     <=($bl['y']+$bl['h'])) )
			  and !( (($y+$h)>=$bl['y']) and (($y+$h)<=($bl['y']+$bl['h'])) )
			  and !( ($y     <=$bl['y']) and (($y+h) >=($bl['y']+$bl['h'])) )
			   )
			{
				$add = 1;
			} else {
				$add = 0;
				break;
			}

		}
	} else {
		$add = 1;
	}

	if ($add == 1) {
		$block[$counter]['x'] = $x;
		$block[$counter]['y'] = $y;
		$block[$counter]['w'] = $w;
		$block[$counter]['h'] = $h;
		$counter++;
	}
}

for ($counter=0;$counter<$segments;$counter++) {
	if ($block[$counter]['x'] > 0 or $block[$counter]['y'] > 0) {
		imagefilledrectangle($output,0,$block[$counter]['y'],400,$block[$counter]['y']+1,$black);
		imagefilledrectangle($output,0,$block[$counter]['y']+$block[$counter]['h'],400,$block[$counter]['y']+$block[$counter]['h']+1,$black);
		imagefilledrectangle($output,$block[$counter]['x'],0,$block[$counter]['x']+1,400,$black);
		imagefilledrectangle($output,$block[$counter]['x']+$block[$counter]['w'],0,$block[$counter]['x']+$block[$counter]['w']+1,400,$black);
	}
}

for ($counter=0;$counter<$segments;$counter++) {

	imagefilledrectangle($output,$block[$counter]['x']+2,$block[$counter]['y']+2,$block[$counter]['x']+$block[$counter]['w']-1,$block[$counter]['y']+$block[$counter]['h']-1,$fill[rand(0,2)]);
	imagerectangle($output,$block[$counter]['x']+1,$block[$counter]['y']+1,$block[$counter]['x']+$block[$counter]['w']+1,$block[$counter]['y']+$block[$counter]['h']+1,$black);
	imagerectangle($output,$block[$counter]['x'],$block[$counter]['y'],$block[$counter]['x']+$block[$counter]['w'],$block[$counter]['y']+$block[$counter]['h'],$black);

}

header("Content-Type: image/png");
imagepng($output);

?>

Paragon

Thats cool and all, but whats it for? 😃

onion2k

Originally posted by Paragon
Thats cool and all, but whats it for? 😃

Why does it have to have a purpose?

BuzzLY

I like the minimalism approach:

Paragon

Originally posted by onion2k
Why does it have to have a purpose?

Nobody said it has to. Thought maybe as a functional guy he would program with a purpose.

onion2k

Originally posted by Paragon
Nobody said it has to. Thought maybe as a functional guy he would program with a purpose.

Programming is an artform. Some of the best code ever written is utterly pointless.

Paragon

Originally posted by onion2k
Programming is an artform. Some of the best code ever written is utterly pointless.

HAHA what ever.

onion2k

Originally posted by Paragon
HAHA what ever.

What an intelligent and salient point. Well done.

tekky

Originally posted by Paragon
HAHA what ever.

But he is right... Unless of course you count Windows as some of the best code ever written.... then of course...

oh wait... breaking the world record of publicly undisclosed bugs/security risks could be a point.... Damn! foiled again :glare: :evilgrin:

tekky

Consequently... this came up RIGHT after I submitted grumble I like this one 😃

Weedpacket

Methinks a search for "TAOCP" is in order here.... All bow down to the mighty Knuth! And pray for the Coming of the Fourth Volume!

BuzzLY

On this page:
http://www.softpanorama.org/Bookshelf/Classic/taocp.shtml

is the title: Softpanorama Classic Series

I must be tired this morning. I thought this said "Softporn..."

I was wondering where Weedpacket was taking us... LOL

Paragon

Originally posted by onion2k
What an intelligent and salient point. Well done.

itchs his ballz

Weedpacket

Offers a banana.

Merve

I guess I'm the first person to reply about what to change in the code.

There's no reason to change anything. Just add a few comments to show what your code is doing. Comments will also help you remember what the hell you were doing a month ago 😉

Love the output though...you should sell it to an art gallery; you'd make millions 😃

Weedpacket

I'd consider using booleans for $building and $add; and/or get rid of $building by using a do..while loop instead.

while(!$building)
{ if(test) $building = true;
...
}

// ==>

do
{
...
}while(!test);

Or maybe alter the test slightly so that you can break as soon as it is true, instead of going for one more iteration.

while(true) // I tend to write for(;;) here
{ if(test) break;
...
}

Though of course if the the first thing you do in the loop is see if you're going to run the loop it would make sense to put the test in the - er - test.

while(test)
{
...
}