Database not get updated

[deolsabh]

My script looks good to me but it never updates values in the database .

here is edit script

<?php
// include function files for this application
require_once("site_sc_fns.php");
session_start();

do_html_header("Updating site");
if (isset($HTTP_SESSION_VARS['valid_user'])) {
if (filled_out($HTTP_POST_VARS)) {

$oldsite = addslashes($HTTP_POST_VARS['oldsite']);
$ktsitename = addslashes($HTTP_POST_VARS['ktsitename']);
$location = addslashes($HTTP_POST_VARS['location']);
$address  = addslashes($HTTP_POST_VARS['address']);
$sitecontact = addslashes($HTTP_POST_VARS['sitecontact']); 
$sitecontactph = addslashes($HTTP_POST_VARS['sitecontactph']); 
$sitectccell = addslashes($HTTP_POST_VARS['sitectccell']); 
$oobno = addslashes($HTTP_POST_VARS['oobno']); 
$lanip = addslashes($HTTP_POST_VARS['lanip']); 
$routerlanip = addslashes($HTTP_POST_VARS['routerlanip']); 
$routerlbip = addslashes($HTTP_POST_VARS['routerlbip']); 
$routerisdnip = addslashes($HTTP_POST_VARS['routerisdnip']); 
$routerhostname = addslashes($HTTP_POST_VARS['routerhostname']); 
$routerserialno = addslashes($HTTP_POST_VARS['routerserialno']); 
$frattcid = addslashes($HTTP_POST_VARS['frattcid']); 
$frlecpttcid = addslashes($HTTP_POST_VARS['frlecpttcid']); 
$miscid = addslashes($HTTP_POST_VARS['miscid']); 
$misleccid = addslashes($HTTP_POST_VARS['misleccid']); 
$attplcid = addslashes($HTTP_POST_VARS['attplcid']); 
$attplleccid = addslashes($HTTP_POST_VARS['attplleccid']); 
$ktplleccid = addslashes($HTTP_POST_VARS['ktplleccid']); 
$atmlecattcid = addslashes($HTTP_POST_VARS['atmlecattcid']); 
$ip = addslashes($HTTP_POST_VARS['ip']); 
$updated = addslashes($HTTP_POST_VARS['updated']); 
$notes = addslashes($HTTP_POST_VARS['notes']);

    if (update_site($oldsite, $ktsitename, $location, $address, $sitecontact, $sitecontactph, $sitectccell, $oobno, $lanip, $routerlanip, $routerlbip, $routerisdnip, $routerhostname, $routerserialno, $frattcid, $frlecpttcid, $miscid, $misleccid, $attplcid, $attplleccid, $ktplleccid, $atmlecattcid, $ip, $updated, $notes))

// if (update_site($oldsite, $ktsitename))
echo "Site was updated.<br>";

    else
        echo "Site could not be updated.<br>";
		 echo '<pre>';
		print_r ($_POST);
		echo '</pre><br>';
} else
    echo "You have not filled out the form.  Please try again.";
do_html_url("admin.php", "Back to administration menu");

} else
echo "You are not authorised to view this page.";

do_html_footer();

?>

here is my update function

function update_site($oldsite, $ktsitename, $location, $address, $sitecontact, $sitecontactph, $sitectccell, $oobno, $lanip, $routerlanip, $routerlbip, $routerisdnip, $routerhostname, $routerserialno, $frattcid, $frlecpttcid, $miscid, $misleccid, $attplcid, $attplleccid, $ktplleccid, $atmlecattcid, $ip, $updated, $notes)
// change details of book stored under $oldisbn in
// the database to new details in arguments
{
/
$ktsitename = addslashes($POST[ktsitename]);
$location = addslashes($POST[location]);
$address = addslashes($POST[address]);
$sitecontact = addslashes($POST[sitecontact]);
$sitecontactph = addslashes($POST[sitecontactph]);
$sitectccell = addslashes($POST[sitectccell]);
$oobno = addslashes($POST[oobno]);
$lanip = addslashes($POST[lanip]);
$routerlanip = addslashes($POST[routerlanip]);
$routerlbip = addslashes($POST[routerlbip]);
$routerisdnip = addslashes($POST[routerisdnip]);
$routerhostname = addslashes($POST[routerhostname]);
$routerserialno = addslashes($POST[routerserialno]);
$frattcid = addslashes($POST[frattcid]);
$frlecpttcid = addslashes($POST[frlecpttcid]);
$miscid = addslashes($POST[miscid]);
$misleccid = addslashes($POST[misleccid]);
$attplcid = addslashes($POST[attplcid]);
$attplleccid = addslashes($POST[attplleccid]);
$ktplleccid = addslashes($POST[ktplleccid]);
$atmlecattcid = addslashes($POST[atmlecattcid]);
$ip = addslashes($POST[ip]);
$updated = addslashes($POST[updated]);
$notes = addslashes($POST[notes]);
/
$conn = db_connect();

$query = "update noc
         set ktsitenmae = '$ktsitename',
		 location = '$location', 
		 address = '$address', 
		 sitecontact = '$sitecontact', 
		 sitecontactph = '$sitecontactph', 
		 sitectccell = '$sitectccell', 
		 oobno = '$oobno', 
		 lanip = '$lanip',
		 routerlanip = '$routerlanip', 
		 routerlbip = '$routerlbip',
		 routerisdnip = '$routerisdnip',
		 routerhostname = '$routerhostname', 
		 routerserialno = '$routerserialno', 
		 frattcid = '$frattcid',
		 frlecpttcid = '$frlecpttcid', 
		 miscid = '$miscid', 
		 milleccid = '$misleccid', 
		 attplcid = '$attplcid',
		 attplleccid = '$attplleccid', 
		ktplleccid = '$ktplleccid', 
		atmkecattcid = '$atmlecattcid',
		ip = '$ip', 
		updated = '$updated', 
		notes = '$notes'
		 where ktsitename='$oldsite'";

$result = mysql_query($query);
if (!$result)
    return false;
else
    return true;

}

[mattotto77]

try doing some error checking like

$result = mysql_query($sql) or die(mysql_error());

this will display any problems or amend your code to try just updating a few fields sometimes its something silly like typo.

[deolsabh]

Now i am getting this error
Duplicate entry 'test' for key 1

[deolsabh]

Now i am getting this error
Duplicate entry 'test' for key 1

[mourisj]

Did you try to echo() you $query?

you should do this to see if everythigs works right on that side.

Then, run this query (copy / paste to the mysql shell) directly on your database. I use this method sometimes (in desperate cases) to have an error-statement directly from the database engine.

Have a Nice day,

JJ Mouris

[mourisj]

Do you have a unique constraint on a column an you try to fill more than one row with the same value ??

[deolsabh]

that is sorted out now but another problem

no data is updated in dabase

[mourisj]

Apparently, you do not bring any changes to your data !!

Look at this example:

[FONT=courier new]mysql> select p_id, nom from person where nom like 'M%';
+------+------------------------+
| p_id | nom |
+------+------------------------+
| 119 | MARX |
+------+------------------------+
24 rows in set (0.01 sec)

mysql> update person set nom = 'MARX' where p_id = 119;
Query OK, 0 rows affected (0.01 sec) Rows matched: 1 Changed: 0 Warnings: 0

mysql> update person set nom = 'MARXX' where p_id = 119;
Query OK, 1 row affected (0.00 sec) Rows matched: 1 Changed: 1 Warnings: 0 [/FONT]

(Of course, I did cut some of the data)

When I update with the exact same value, 1 row, is matched, bbbut none is changed; if I update with an other value, 1 row is matched and 1 is changed!

Hope this helps

JJ Mouris

[deolsabh]

it get updated when i do from mysql

but when i use this script it does not update record

[mourisj]

Once you have updated from mySql, you have to use other data to update from your script! Otherwise, you don't do any changes again.

Also, be sure that your value in your WHERE-clause ($oldsite) still exists after your update !!

I guess thjis isn't an issue any more ??
set ktsitenmae = '$ktsitename',

Friendly,

JJ Mouris

[deolsabh]

function update_site($oldsite, $ktsitename, $location, $address, $sitecontact, $sitecontactph, $sitectccell, $oobno, $lanip, $routerlanip, $routerlbip, $routerisdnip, $routerhostname, $routerserialno, $frattcid, $frlecpttcid, $miscid, $misleccid, $attplcid, $attplleccid, $ktplleccid, $dlci, $atmattcid, $atmlecattcid, $ip, $updated, $notes)
// change details of book stored under $oldisbn in
// the database to new details in arguments
{

$conn = db_connect();

$query = "update noc set (ktsitename, location, address, sitecontact, sitecontactph, sitectccell, oobno, lanip, routerlanip, routerlbip, routerisdnip, routerhostname, routerserialno, frattcid, frlecpttcid, miscid, misleccid, attplcid, attplleccid, ktplleccid, dlci, atmattcid, atmlecattcid, ip, updated, notes) values
    ('$ktsitename', '$location', '$address', '$sitecontact', '$sitecontactph', '$sitectccell', '$oobno', '$lanip', '$routerlanip', '$routerlbip', '$routerisdnip', '$routerhostname', '$routerserialno', '$frattcid', '$frlecpttcid', '$miscid', '$misleccid', '$attplcid', '$attplleccid', '$ktplleccid', '$dlci', '$atmattcid', '$atmlecattcid', '$ip', '$updated', '$notes' )";


$query = "update noc
         set ktsitename = '$ktsitename',
		 location = '$location', 
		 address = '$address', 
		 sitecontact = '$sitecontact', 
		 sitecontactph = '$sitecontactph', 
		 sitectccell = '$sitectccell', 
		 oobno = '$oobno', 
		 lanip = '$lanip',
		 routerlanip = '$routerlanip', 
		 routerlbip = '$routerlbip',
		 routerisdnip = '$routerisdnip',
		 routerhostname = '$routerhostname', 
		 routerserialno = '$routerserialno', 
		 frattcid = '$frattcid',
		 frlecpttcid = '$frlecpttcid', 
		 miscid = '$miscid', 
		 misleccid = '$misleccid', 
		 attplcid = '$attplcid',
		 attplleccid = '$attplleccid', 
		ktplleccid = '$ktplleccid',
		dlci = '$dlci',
		atmattcid = '$atmattcid', 
		atmlecattcid = '$atmlecattcid',
		ip = '$ip', 
		updated = '$updated', 
		notes = '$notes'
		 where ktsitename='$oldsite'";

// echo '<pre>';
// print_r ($_POST);
// echo '</pre><br>';

$result = mysql_query($query) or die(mysql_error()); 
if (!$result)
    return false;
else
    return true;

}

[deolsabh]

the above function i am useing to update and it echo's out correct values