passing php variables to Javascript

wrwilson

I want to use the php variable $splitcontents[$addindex] variable in the javascript, because a data file contains URLs that I'm reading in to an array and based on what is selected on the previous HTML page I need to dynamically choose the URL. I'm having issues

if ($splitcontents[$index] == $_REQUEST['udr'])
{

$addindex = $index + 1;
echo "<br>Splitcontents val: $splitcontents[$addindex]<br>";
$bool = 1;
$path = 'C:\Documents and Settings\xxx\My Documents\xxx\Unavailable.html';
$path .= chr(10);
//echo "attempt to enter second stmt";
if ($splitcontents[$addindex] == $path)
{

echo '<script type="text/JavaScript">

</script>';
}
else
{

             echo '<script type="text/JavaScript">
             <!--				 

				 alert("Software is Available");
				 window.open("http://<? echo $splitcontents[$addindex]; ?>");
             //-->
	         </script>';
		  }[/COLOR]

It jumps to the address literally ('http://<? echo $splitcontents[$addindex]; ?>')
And I want it to jump to the URL that is the value of the variable; what I read in from the data file.

Help is greatly appreciated

drew010

just use
window.open("http://$splitcontents[$addindex]");

by the looks of it you already have php processing so <?php will not do anything if it is already inside an open php tag. you are also already in an echo statement so putting echo again will just write echo.

your code above was similar to this code below:
<?php echo '<?php echo $somevar; ?>';?>
where it should just be
<?php echo '$somevar'; ?>

wrwilson

Well thanks for the suggestion I tried that and when the command is executed it brings up a new browser window at the URL "http://$splitcontents[$addindex]/"
I just do not understand why it takes it literally and not the value of the variable. Thanks for the extra info after the suggestion.

I still need help solving this issue if anyone has any other suggestions.

drew010

see what this does for you:

 echo '<script type="text/JavaScript">
<!--

alert("Software is Available");
window.open("http://{$splitcontents[$addindex]}");
//-->
</script>';
}

wrwilson

This is the exact URL that was used in the new windows "http://$splitcontents[$addindex]/"

thanks for the continuing help

(and as long as I noticed the response right, the only change you made were the Curly brackets (or braces) around the php variable correct?

drew010

yeah the braces tell php that the following is a variable so it treats it special in the output. look at [man]echo[/man] if you continue having trouble making this work. make sure you are in <?php code because i dont see why it wont replace the variable with its actual contents.

wrwilson

The whole file is php and I echo javascript this is the entire file:

<?php

execute ();
function execute ()
{

$filename = "xxx.txt";
 $fd = fopen ($filename, "r");
 $contents = fread ($fd, filesize ($filename));

 fclose ($fd);
 $delimiter = "	";

 $splitcontents = explode($delimiter, $contents);

$bool = 0;
 $index = 1;
 $counter = 0;
 while ($bool != 1)
 {

     $counter = $counter + 1;
     if ($splitcontents[$index] == $_REQUEST['udr'])
    {             
         $addindex = $index + 1;
         echo "<br>Splitcontents val: $splitcontents[$addindex]<br>";
         $bool = 1;
         $path = 'Unavailable.html';
		 $path .= chr(10);

         if ($splitcontents[$addindex] == $path)
		 {   
             echo '<script type="text/JavaScript">
             <!--				 
				 alert("In the 2nd If");
                 window.open("http://{$splitcontents[$addindex]}");	 
             //-->
	         </script>';
          }
		  else 
		  {

             echo '<script type="text/JavaScript">
             <!--				 

				 alert("Software is Available");
				 window.open("http://$splitcontents[$addindex]");
             //-->
	         </script>';
		  }

    $index = $index + 3;
   }

}

?>

In desperation, I came to forum because I could not find any help on the internet, or all of the help I found did not help.

PallaviDalvi

am not sure if this helps but try
window.open("http://' . $splitcontents[$addindex] .' ");
atelast it worked in my case (IE).

wrwilson

Thanks for the help, but I just tried the response and IE appears to just skip the javascript because it "doesn't like it" or for some other reason...

PallaviDalvi

Well i dont know whats really happening in ur case... but for me window.open("http://' . $splitcontents[$addindex] .' ");
worked.
moreover i observed that the entire echo was in single quotes and if i'm not wrong variable substituition does not take place in single quotes.

wrwilson

thanks for your help got a response that resolved the issue