submitting with a form

wanted420

Ok I have a form that i cant get to submit correctly. I am doing this.

<?php
    if ($submit) {
    $members=mysql_connect("localhost", "root");
    mysql_select_db("members",$members);

$add_member="insert into members (username, password, sec_phrase, first_name, last_name, address, city, zip, email, phone, major, comments)  values ('$username','$password', '$sec_phrase', '$firstname', '$lastname', '$address', '$city', '$zip', '$zip', '$email', '$phone', '$major', '$comments')";
$result = mysql_query($add_member);
}
else {
?>
<table border="0" bgcolor="#2D0040" width="75%" cellspacing="8">
  <form name="reg_form" action="register.php" method="get">
this is all the form info
      <tr>
        <td align="right"><font color="#FFFFFF">&nbsp</font></td>
        <td align="right"><input type="submit" name="submit" value="&nbsp&nbsp Submit &nbsp&nbsp"></textarea></td>
        <td><font color="#FFFFFF">&nbsp</font></td>
      </tr>
      </form>
    </table>
    <?php
    echo "<font color='#FFFFFF'><h3>Thank You for registering " . $username . "!</h3></font>";
    }
    ?>

I have tried using action="<?php $PHP_SELF; ?>" but that didnt work either. I dont get an error it just reloads the registration page and does not enter anything into the database.

rgermain

First thing I noticed and something you should try is, use post instead of get in your form method.

Second thing, of course its going to just reload the page...Thats what you told it to do. Its working fine, just your coding is wrong. For example...

<? if($submit)  ?>

That is telling the Parser nothing... Try this instead.

<? if(isset($submit)) ?>

Changing those to things mentioned above should get you to a whole new level.

Now go, have fun and happy coding!! 🙂

devinemke

2 questions:

is the code you posted within "register.php"? if not what is in "register.php"?
do you have register_globals ON or OFF in your php.ini file?

wanted420

yes the code posted is in the register.php. My register page has a form to gather all the info i want to know about the person registering. register_globals are set to there default value. I am not sure what they are or what they can be used for so i havent touched them.

wanted420

This is the new code, which still isnt working. It reloads the page, like it's supposed to do, but it just shows the form and never inserts the info into my database:

<?php
    if(isset($submit)) {
    $members=mysql_connect("localhost", "root");
    mysql_select_db("members",$members);

$add_member="insert into members (username, password, sec_phrase, first_name, last_name, address, city, zip, email, phone, major, comments)  values ('$username','$password', '$sec_phrase', '$firstname', '$lastname', '$address', '$city', '$zip', '$zip', '$email', '$phone', '$major', '$comments')";
$result = mysql_query($add_member);
echo "<font color='#FFFFFF'><h3>Thank You for registering " . $username . "!</h3></font>";
}
else {
?>
<table border="0" bgcolor="#2D0040" width="75%" cellspacing="8">
  <form name="reg_form" action="register.php" method="post">
  <tr>
    <th colspan="2"><font color="#FFFFFF">Bitphire Username and Password Setup</font></th>
    <th><font color="#FFFFFF">Description</font></th>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Username: </font></td>
    <td><font color="#FFFFFF"><input type="text" maxlength="15" name="username" value="4 - 15 Characters"><i>@bitphire.com</i></font></td>
    <td><font color="#FFFFFF">This is your login in name and E-Mail address for Bitphire.com.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Password: </font></td>
    <td><input type="password" maxlength="15" name="password"></td>
    <td><font color="#FFFFFF">Enter in a password no more then 15 but no less then 4.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Re-Type Password: </td>
    <td><input type="password" maxlength="15" name="password2"></font></td>
    <td><font color="#FFFFFF">Re-Type the password just entered above for security reasons.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Security Phrase: </font></td>
    <td><input type="text" maxlength="25" name="sec_phrase"></td>
    <td><font color="#FFFFFF">This phrase will come in handy if you every forget your password and need to retrieve it.</font></td>
  </tr>
</table>
</center>
<br>
<hr width="85%">
<br>
<center>
<table border="0" bgcolor="#2D0040" width="75%" cellspacing="10">
  <tr>
    <th colspan="2"><font color="#FFFFFF">Your Personal Information</font></th>
    <th><font color="#FFFFFF">Description</font></th>
  </tr>
  <tr>
    <td align="right" width="20%"><font color="#FF0000">*</font><font color="#FFFFFF">First Name: </font></td>
    <td width="33%"><input type="text" maxlength="10" name="firstname"></td>
    <td width="47%"><font color="#FFFFFF">Your real first name.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Last Name: </font></td>
    <td><input type="text" maxlength="10" name="lastname"></td>
    <td><font color="#FFFFFF">Your real last name.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">Address: </td>
    <td><input type="text" maxlength="30" name="address"></td>
    <td><font color="#FFFFFF">Your home address or if on campus at Southwestern please put your room #.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">City: </font></td>
    <td><input type="text" maxlength="15" name="city"></td>
    <td><font color="#FFFFFF">Your home town/city.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FF0000">*</font><font color="#FFFFFF">Zip: </font></td>
    <td><input type="text" maxlength="15" name="zip"></td>
    <td><font color="#FFFFFF">Your zip code for the town/city entered above.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">E-Mail: </font></td>
    <td><input type="text" maxlength="30" name="email"></td>
    <td><font color="#FFFFFF">Enter another E-Mail account of yours, if you do not have one leave blank.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">Phone: </font></td>
    <td><input type="text" maxlength="13" name="phone"></td>
    <td><font color="#FFFFFF">Home phone number (without parantheses or dashes) or enter your dorm room extension at Southwestern College.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">Major: </font></td>
    <td><input type="text" maxlength="30" name="major"></td>
    <td><font color="#FFFFFF">This is mainly for Southwestern College students but if you are not a student here feel free to enter your major.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">Comments: </font></td>
    <td><textarea rows="5" cols="15" name="comments"></textarea></td>
    <td><font color="#FFFFFF">Please enter in any other comments you may have.</font></td>
  </tr>
  <tr>
    <td align="right"><font color="#FFFFFF">&nbsp</font></td>
    <td align="right"><input type="submit" name="submit" value="&nbsp&nbsp Submit &nbsp&nbsp"></textarea></td>
    <td><font color="#FFFFFF">&nbsp</font></td>
  </tr>
  </form>
</table>
<?php
}
?>

devinemke

...register_globals are set to there default value...

that default value depends on which version of PHP you installed. again, do you have register_globals ON or OFF in your php.ini file?

wanted420

They are turned off.

devinemke

see changes below:

if (isset($_POST['submit']))
{
		extract($_POST);

	$members = mysql_connect('localhost', 'root', 'password');
	mysql_select_db('members', $members);

	$add_member="insert into members
	(
	username,
	password,
	sec_phrase,
	first_name,
	last_name,
	address,
	city,
	zip,
	email,
	phone,
	major,
	comments
	)

	values
	(
	'$username',
	'$password',
	'$sec_phrase',
	'$firstname',
	'$lastname',
	'$address',
	'$city',
	'$zip',
	'$zip',
	'$email',
	'$phone',
	'$major',
	'$comments'
	)"; 

	$result = mysql_query($add_member);
	echo '<font color="#FFFFFF"><h3>Thank You for registering ' . $username . '!</h3></font>';
} 

else
{
// rest of your code

wanted420

It seems to be working half way now. when i click submit it show the thank you message but for some odd reason my table in sql is still empty. I must have something wrong. I know the DB should be board instead of members but that still didnt work. the root has no password, is there a way to change this? And what does extract ($POST) do? I know you can do $POST['whatever'] and it work with out the extract. Thats all. 🙂

Thanks for all the help.

Wanted420

EDIT:
I did install a Mail Server with a buit in mysql for it and then install mysql. Could it be when it access localhost it is finding the mailserver sql and not the one i installed?

EDIT 2:
Ok i uninstalled the mail server and it still wouldnt work. I am telling it to connect to localhost but i am behind a firewall. So i changed localhost to 192.168.1.103 and now i get these warnings:

Warning: mysql_connect(): Host '192.168.1.103' is not allowed to connect to this MySQL server in C:\Program Files\Apache Group\Apache2\htdocs\register.php on line 70

Warning: mysql_select_db(): supplied argument is not a valid MySQL-Link resource in C:\Program Files\Apache Group\Apache2\htdocs\register.php on line 71

The mysql_select_db() warning is fixed by changing: mysql_select_db("members",$members);
to
mysql_select_db("members");