Which method is more efficient?

AceE

The Longer, Simpler, Manual Way:

  $theNewLW = $theteam['leftwing'];
  $theNewC = $theteam['center'];
  $theNewRW = $theteam['rightwing'];
  $theNewLD = $theteam['leftdefense'];
  $theNewRD = $theteam['rightdefense'];

  $theLWskill = ceil(((($this->player[$theNewLW]['passing']*.09)+($this->player[$theNewLW]['speed']*.04)+($this->player[$theNewLW]['agility']*.04)+($this->player[$theNewLW]['offense']*.08)*$this->player[$theNewLW]['morale'])/100)+.7);
  $theCskill = ceil(((($this->player[$theNewC]['passing']*.09)+($this->player[$theNewC]['speed']*.04)+($this->player[$theNewC]['agility']*.04)+($this->player[$theNewC]['offense']*.08)*$this->player[$theNewC]['morale'])/100)+.7);
  $theRWskill = ceil(((($this->player[$theNewRW]['passing']*.09)+($this->player[$theNewRW]['speed']*.04)+($this->player[$theNewRW]['agility']*.04)+($this->player[$theNewRW]['offense']*.08)*$this->player[$theNewRW]['morale'])/100)+.7);
  $theLDskill = ceil(((($this->player[$theNewLD]['passing']*.09)+($this->player[$theNewLD]['speed']*.04)+($this->player[$theNewLD]['agility']*.04)+($this->player[$theNewLD]['offense']*.08)*$this->player[$theNewLD]['morale'])/100)+.7);
  $theRDskill = ceil(((($this->player[$theNewRD]['passing']*.09)+($this->player[$theNewRD]['speed']*.04)+($this->player[$theNewRD]['agility']*.04)+($this->player[$theNewRD]['offense']*.08)*$this->player[$theNewRD]['morale'])/100)+.7);

Or the shorter, complicated, automatic way:

  $plist = array("leftwing", "center", "rightwing", "leftdefense", "rightdefense");
  for($i=0;$i<$theteam['players'];$i++){
   $theskill[$plist[$i]] = $theLWskill = ceil(((($this->player[$theteam[$plist[$i]]]['passing']*.09)+($this->player[$theteam[$plist[$i]]]['speed']*.04)+($this->player[$theteam[$plist[$i]]]['agility']*.04)+($this->player[$theteam[$plist[$i]]]['offense']*.08)*$this->player[$theteam[$plist[$i]]]['morale'])/100)+.7);
  }

When I microTime() them ... the second one seems much quicker:
on average It took 0.00018 seconds to calculate the passing vs
It took 0.00011 seconds to calculate the passing

I've heard it's best to use as little code as possible (arrays/loops) AND I've also heard to write the code simple and long, cuz you only need to do it once...

...anyone who knows about advanced PHP and the workings of it, please comment, thx...

drew010

ive always been taught in cs classes to never hardcode stuff like example 1 because if you ever need to go back and change things it may take more time and be more confusing. looping and using variables certainly makes the code more easy to manage.

AceE

yea, thanks, thats what I usually try to do, but sometimes this happens:
It took 0.00026 seconds to calculate the passing
It took 0.00013 seconds to calculate the passing

... the longer way takes half the time...I know that time is incredibly tiny...but when I release my game...those tiny things could add up on my $6 a month server, lol...

drawmack

I'm lazy so I just use loops whenever I can.

Weedpacket

Originally posted by drew010
ive always been taught in cs classes to never hardcode stuff like example 1 because if you ever need to go back and change things it may take more time and be more confusing.

And also increases the risks of making a mistake at some point during all that dull mechanical updating of all those nearly-identical lines that makes you wish you had a machine to do it for you - oh, that's right, you do 😃

AceE

yea, I think I'll just shorten everything possible...but save chunks of the old code, because if it's half the speed, could be useful...i'll do more timed-testing aswell...