Correct way of inserting into SQL

[jellyfish]

<?

$data = @mysql_connect('localhost','root','password');
if (!$data) {
    	    echo('<p>Unable to connect to the '. 'database server at this time.</p>' );  
    	    exit();  
                }
mysql_select_db('FYP', $data);

if (! @mysql_select_db('FYP') ) {
  echo( '<p>Unable to locate the FYP ' . 'database at this time.</p>' );
}

$Full=$_POST['full'];
$Username=$_POST['user'];
$NRIC=$_POST['nric'];
$Address=$_POST['address'];
$Postal=$_POST['postal'];
$Email=$_POST['email'];
$Password=$_POST['password'];
$HP=$_POST['hp'];
$Home=$_POST['home'];
$Date=$_POST['Extra4'];
$Month=$_POST['Extra5'];
$Year=$_POST['Extra6'];
$Gender=$_POST['gender'];


$sql = "INSERT INTO Members values ('$Full','$Username','$NRIC','$Address','$Postal','$Email','$Password','$HP','$Home','$Date','$Month','$Year','$Gender')";

$result = mysql_query($sql) or errorhandle();
Function errorhandle(){
   $error_num = mysql_errno();
   $error_detail = mysql_error();
  die ("System Upgrading.Will be back online as soon as possible., $error_num ,<br> $error_details");
}	
?>

is this the correct way of inserting into a db ?
coz this fails to work whenever i add a new field into the db 😕

[tekky]

uhm it helps to show the error and the exact SQL call being made....

ie. echo $sql; and the use of mysql_error() which you already have...

[rachel2004]

First and foremost, follow tekky's advice. Seeing that you are doing an INSERT and without looking at your code in-depth, my suggestion is to also check that the number of columns in your table matches the number of columns that you are inserting into. That's a common mistake to make when doing INSERT statements.

[jellyfish]

What if i have a field in the db which i wont be storing data till later on , would that pose a problem?

[rachel2004]

It could. The INSERT statement that you posted is to be used when you are inserting into ALL of the columns in a table. If you are planning to insert only into column1, column2, and column4 (but not column3), then do this:

INSERT into my_table
(column1, column2, column4)
VALUES
('value1', 'value2', 'value4')

[tekky]

Originally posted by rachel2004
It could. The INSERT statement that you posted is to be used when you are inserting into ALL of the columns in a table. If you are planning to insert only into column1, column2, and column4 (but not column3), then do this:

INSERT into my_table
(column1, column2, column4)
VALUES
('value1', 'value2', 'value4')

and for your second opinion, I concur 😉 That was the main reason for supplying your ERROR statement, we could have said that right away 😉

[brockn]

Instead of having to specify which fields I am inserting the data I usually just insert blank data. I.E. ('')

That way I can leave the column type as NOT NULL and not insert the data until later.

[jellyfish]

<?

$data = @mysql_connect('localhost','root','password');
if (!$data) {
    	    echo('<p>Unable to connect to the '. 'database server at this time.</p>' );  
    	    exit();  
                }
mysql_select_db('FYP', $data);

if (! @mysql_select_db('FYP') ) {
  echo( '<p>Unable to locate the FYP ' . 'database at this time.</p>' );
}

$Full=$_POST['full'];
$Username=$_POST['user'];
$NRIC=$_POST['nric'];
$Address=$_POST['address'];
$Postal=$_POST['postal'];
$Email=$_POST['email'];
$Password=$_POST['password'];
$HP=$_POST['hp'];
$Home=$_POST['home'];
$Date=$_POST['Extra4'];
$Month=$_POST['Extra5'];
$Year=$_POST['Extra6'];
$Gender=$_POST['gender'];


$sql = "INSERT INTO Members (Full, Username, NRIC, Address, Postal, Email, Password, HP, Home, Date, Month, Year, Gender)
VALUES('$Full', '$Username', '$NRIC', '$Address', '$Postal', '$Email', '$Password', '$HP', '$Home', '$Date', '$Month', '$Year', '$Gender');

$result = mysql_query($sql) or errorhandle();
Function errorhandle(){
   $error_num = mysql_errno();
   $error_detail = mysql_error();
  die ("There has been an error creating your account. Please contact the Webmaster. $error_num ,<br> $error_details");
}	
?>

would this be better?

[Ali_Baba2]

i think you forgot a " after '$Gender'

maybe i'm wrong as im still a beginner but everything seems red

[tekky]

Originally posted by Ali Baba
i think you forgot a " after '$Gender'

maybe i'm wrong as im still a beginner but everything seems red

you are correct, good to see a beginner that understands the Hilighting 🙂

should be .....'$genger')");