IS THIS MAKING ANY SENSE ? auction script

[barnfold]

hi

here is a snippet from a part of a function im trying to alter to check and update a users bidding credits.

but being a beginner its not working heheh not sure i have it in the right palce or that it is even correct coding ?

i have tried numerous variations and they all seem to skip over my code, hang up on an error and dont update anything heheh

any suggestions greatly recieved !!

function process_bid($db,$auction_id=0,$bidder=0,$bid_amount=0)
{
if ($auction_id)
{
if ($bidder)
{

                    if ($bid_amount)
                            {

$q1 = "select bidcredit from ".$this->auctions_users_table." WHERE bidcredit = \"$bidcredit\" ";
$r1 = mysql_query($q1) or die(mysql_error());
$bid_credit = mysql_fetch_array($r1);

$q2 = "UPDATE ".$this->auctions_bids_table." SET bidcredit = \"$bid_credit\" WHERE bidder=\"$bidder\" ";
$r2 = mysql_query($q2) or die(mysql_error());
$bid_credit1 = mysql_fetch_array($r2);

if($bid_credit1 < $bid_amount)
{

$this->error_message = $this->messages[2314];
}

elseif ($bid_credit1 > $bid_amount)
{
$bidcredit = $bid_credit1 - $bid_amount;

$qup = "UPDATE ".$this->auctions_users_table." SET bidcredit = ".$bidcredit." WHERE id = ".$bidder." ";
$rup = mysql_query($bidcredit) or die(mysql_error());

}

...............................................the script then goes into checking high bidder etc

[dalecosp]

any suggestions greatly recieved !!

Well, I hope you can (didja mean 'gratefully'?) receive these:

1. Check out the thread entitled "Debugging 101", which is chock full of ideas that may help.

2. You might think about being a little clearer in your style; however, you do at least seem to have an inkling of style, which isn't bad for a newb ;-) ... Here's my take on your 'snippet' :

<?php

function process_bid($db,$auction_id=0,$bidder=0,$bid_amount=0) {

    if ($auction_id) {
            if ($bidder) {
                    if ($bid_amount) {

                            $q1 = "select bidcredit from ".$this->auctions_users_table." WHERE bidcredit = \"$bidcredit\" ";
                            $r1 = mysql_query($q1) or die(mysql_error());
                            $bid_credit = mysql_fetch_array($r1);

                            $q2 = "UPDATE ".$this->auctions_bids_table." SET bidcredit = \"$bid_credit\" WHERE bidder=\"$bidder\" ";
                            $r2 = mysql_query($q2) or die(mysql_error());
                            $bid_credit1 = mysql_fetch_array($r2);

                                    if($bid_credit1 < $bid_amount) {

                                            $this->error_message = $this->messages[2314];
                                    }

                                    elseif ($bid_credit1 > $bid_amount) {

                                            $bidcredit = $bid_credit1 - $bid_amount;

                                            $rup = mysql_query($bidcredit) or die(mysql_error());

                                    }

?>

skip over my code, hang up on an error and dont update anything heheh

Are you sure you want the function prototype to have its arguments set to zero by default? If you expect to occasionally not call the function with those arguments, should it not be

function foo(arg1, arg2=null, arg3=null) {

--- because any tests (your "if's", for example) done within the function if the argument is set to zero won't be evaluated...

HTH,

[barnfold]

hi thanks for the time replying (sorry about the apparent mistake with greatly, im english you see heheh)

the function arguments are set to 0 as that what the original script was set to so i left well alone there..... (geoauctions lite)

im not getting any errors at the moment apart from a sql syntax error near where = on line 1 so it says.... something to do with the \ maybe ??

ok now im going to seem even more stupid...
is this function working through like this ???

set arguments to 0
checking the auction_id and putting the relevant number in
checking the bidder and putting in relevant number
chcking the bid_amount number
(e.g we have the auction id number 'n' and bidder number 'n' and the bid amount 'n')
then its going through my code ??

[dalecosp]

Originally posted by barnfold
hi thanks for the time replying (sorry about the apparent mistake with greatly, im english you see heheh)

the function arguments are set to 0 as that what the original script was set to so i left well alone there..... (geoauctions lite)

You are correct, my mistake. It seems that either zero or "null" will have the desired effect...

im not getting any errors at the moment apart from a sql syntax error near where = on line 1 so it says.... something to do with the \ maybe ??

Quite possibly. Maybe:

$q1 = "select bidcredit from ".$this->auctions_users_table." WHERE bidcredit = $bidcredit";

In the event that $bidcredit is never going to be a string, that should work just as well or better.

ok now im going to seem even more stupid...
is this function working through like this ???

set arguments to 0

No, the function is simply allowing for the script to call it with either 1, 2, 3, or all 4 parameters. As I mentioned, I was wrong about "zero vs. null" ...

checking the auction_id and putting the relevant number in
checking the bidder and putting in relevant number
chcking the bid_amount number
(e.g we have the auction id number 'n' and bidder number 'n' and the bid amount 'n')
then its going through my code ??

What the function, at least the part I quoted, is doing, is this:

IF a variable $auction_id AND a variable $bidder and a variable $bid_amount exist, then get the variable $bid_credit from the relevant DB table, SET the $bidder's bid credit as $bidcredit, and finally, test to see if the bidder can actually afford the bid that has been input and, based on this fact, either assign an error message or perform a calculation ...

That's about it ...

[barnfold]

hi

i get the syntax error at .. where bidder = ..... at line 1
or
if i change the code where you suggested at the 'select' i get a syntax error ..... near " at line 1

i have tried alot of combinations heheh and if it does hang up there i get an error fromt he script further down saying it cant complete the bid

im doing something wrong !!

would the whole function help ???

cheers

[dalecosp]

Would the whole...

Probably.

[barnfold]

here it is sorry if it all over the place... not used to the format yet

 //check to if bid_amount is above or = to the minimum bid
 $sql_query = "select * from ".$this->auctions_table." where id = ".$auction_id;
                                        //echo $sql_query." is the query<br>\n";
                                        $result = &$db->Execute($sql_query);
                                        if (!$result)
                                        {
                                 //echo $sql_query." is the query<br>\n";
                       $this->error_message = $this->messages[2313];
                       return false;
                                        }
                                        elseif ($result->RecordCount() == 1)
                                        {
                                           $show = $result->FetchNextObject();
                           /echo $show->SELLER." is the seller id<br>\n";
                               //echo $bidder." is the bidder id<Br>\n";
                                                if ($show->SELLER == $bidder)
                                                {
                      $this->error_message = $this->messages[2333];
                                                        return false;
                                                }
                                                else
                                                {
                                                        if (!$show->CLOSED)
                                                        {
                                 //see if this person is the high bidder
 $sql_query = "select * from ".$this->auctions_bids_table." where auction = ".$auction_id."order by bid desc";
          $high_bidder_test_result = &$db->Execute($sql_query);
   if (!$high_bidder_test_result)
                                                                {
                          //echo $sql_query." is the query<br>\n";
                     $this->error_message = $this->messages[2313];
                                                                        return false;
                                                                }
                                                                elseif ($high_bidder_test_result->RecordCount() > 0)
                                                                {
                                                                        $show_high_bidder_test = $high_bidder_test_result->FetchNextObject();
       if ($show_high_bidder_test->BIDDER == $bidder)
                                                                        {
                      $this->error_message = $this->messages[2338];
                                                                                return false;
                                                                        }
                                                                }

                                      if ($show->HIGH_BID == 0)
                                                            {
  $increment = $this->get_increment($db,$show->MINIMUM_BID);
                     $next_bid = $show->MINIMUM_BID + $increment;
                                                                }
         elseif ($show->HIGH_BID > $show->MINIMUM_BID)
                                                                {
    $increment = $this->get_increment($db,$show->HIGH_BID);
                      $next_bid = $show->HIGH_BID + $increment;
                                                                }
                                                                else
                                                                {
 $increment = $this->get_increment($db,$show->MINIMUM_BID);
                       $next_bid = $show->MINIMUM_BID + $increment;
                                                                }

//echo $increment." is the increment to add to the minimum<br>\n";

                               if ($bid_amount >= $next_bid)
                                                            {
 $sql_query = "UPDATE ".$this->auctions_table." SET high_bid = \"".$bid_amount."\" WHERE id = \"".$auction_id."\"";
      $result = &$db->Execute($sql_query);
   if (!$result)
                                                                        {
                      $this->error_message = $this->messages[2313];
                                                                                return false;
                                                                        }

                          //echo $sql_query." is the query<br>\n";
$time = time();
$sql_query = "INSERT INTO ".$this->auctions_bids_table." VALUES (\"".$auction_id."\",\"". $bidder."\", \"".$bid_amount."\",\"".$time."\", 1)";
 $result = &$db->Execute($sql_query);
                                                       if (!$result)
                                                                        {
                                                                                //back out mimimum bid
                                                                                $sql_query = "UPDATE ".$this->auctions_table." SET high_bid = \"".$show->MINIMUM_BID."\" WHERE id = \"".$auction_id."\"";
                                                                                $result = &$db->Execute($sql_query);
                                                                                if (!$result)
                                                                                {
                     $this->error_message = $this->messages[2313];
                              return false;
                                                                                }

                 $this->error_message = $this->messages[2313];
                            return false;
                                                                    }
                             return true;

                                                            }

                                                            else
                                                            {
                   $this->error_message = $this->messages[2335];
                   return false;
                                                            }

                                                    }
                                                    else
                                                    {
                //auction closed
                  $this->error_message = $this->messages[2314];
                  return false;
                                                    }
                                            }
                                    }
                                    else
                                    {
        $this->error_message = $this->messages[2334];
        return false;
                                    }
                            }
                            else
                            {
            //no bid information
         $this->error_message = $this->messages[2335];
         return false;
                            }
                    }
                    else
                    {
          //no bidder information
          //internal error
            $this->error_message = $this->messages[2313];
                            return false;
                    }
            }
            else
            {
        //the auction id is missing
         $this->error_message = $this->messages[2313];
                    return false;
            }

    } //end of function process_bid