[Resolved] incoherence

[MrCool]

I have this code on my local apache server:

if(! isset($_GET['mode'])) {
$_GET['mode']="login";
}
if($_GET['mode']="logout") {
session_start();
unset($_SESSION['user']);
unset($_SESSION['pass']);
unset($_SESSION['status']);
header("Location:index.php");
}

If the mode is login why does he run the last line of the logout mode?

[drawmack]

my guess would be that this same exact line of code exists elsewhere in the script so that the user is always redirected back to the index.php file when they log in or log out.

A valid, though not very friendly, login/out methodology.

[MrCool]

Here's the rest:

<?
if($_GET['mode']="login") {
if (isset($_POST['form'])) {
include("includes/dbconnect.php");
$sql="SELECT * FROM users WHERE username='".$_POST['username']."' AND password='".md5($_POST['password'])."' LIMIT 1";
$res=mysql_query($sql,$db);
if (mysql_num_rows($res) == 1) {
session_start();
$_SESSION['user'] = $_POST['username'];
$_SESSION['pass'] = md5($_POST['password']);
$_SESSION['status']="User";
header("Location:".urldecode($_POST['referrer'])."");
} else {
$message="data provided invalid";
}
} 
include("includes/header.php");
if(isset($message)) {
echo $message;
}
?>
<form name="form1" method="post" action="login.php">
  <p class="main">
    Username: <input name="username" type="text" id="username">
  </p>
  <p class="main">
    Password: <input name="password" type="password" id="password">
    <input name="form" type="hidden" id="form" value="TRUE">
  </p>
  <p>
    <input type="submit" name="Submit" value="Submit" class="button">
</p>
</form>
<? }

Before I added the logout part at the top everything worked fine :queasy:

[laserlight]

Could it be a case of mixing up '=' with '=='?

[MrCool]

Yep, it was, thanks laserlight for your lasereyes 🙂