Upload Help

DigitalExpl0it

Im trying to write a upload script that upload multi images, single upload worked until I started adding the multi part..

thing is it keeps comming up as wrong type. Cant figure out why it wont upload.

<FORM ENCTYPE="multipart/form-data" ACTION="<? echo $PHP_SELF; ?>" METHOD="POST">
The file1:  <INPUT TYPE="file" NAME="userfile[0]"><br>
The file2: <INPUT TYPE="file" NAME="userfile[1]"><br>
<INPUT TYPE="submit" VALUE="Upload">
</FORM>

<?
$files = $HTTP_POST_FILES['userfile'];
$path = "/home/chillthrill/www/test/images/";
$max_size = 900000;

if (!isset($files)) exit;
foreach ($files['name'] as $key=>$name) {
	if (is_uploaded_file($files['tmp_name'][$key])) {
		if ($files['size'][$key]>$max_size) { echo "The file is too big<br>\n"; exit; }
			if (($files['size']['type'][$key]=="image/gif") || ($files['size']['type'][$key]=="image/pjpeg") || ($files['size']['type'][$key]=="image/jpeg")) {
				if (file_exists($path.$name)) { echo "The file already exists<br>\n"; exit; }
					$res = copy($name, $path.$name);
					if (!$res) { echo "upload failed!<br>\n"; exit; } else { echo "upload sucessful<br>\n"; }
						echo "File Name: ".$name."<br>\n";
						echo "File Size: ".$files['size'][$key]." bytes<br>\n";
						echo "File Type: ".$files['size']['type'][$key]."<br>\n";
						echo "Link: <a href='images/".$name."'>".$name."</a><br>\n";
					} else { 
						echo "Wrong file type<br>\n"; 
						echo $name;
						exit; 
					}
}
}
?>

DigitalExpl0it

well I got a bit further now Im getting a upload failed....


<FORM ENCTYPE="multipart/form-data" ACTION="<? echo $PHP_SELF; ?>" METHOD="POST">
The file1:  <INPUT TYPE="file" NAME="userfile[]"><br>
The file2: <INPUT TYPE="file" NAME="userfile[]"><br>
<INPUT TYPE="submit" VALUE="Upload">
</FORM>

<?
$files = $HTTP_POST_FILES['userfile'];
$path = "C:\\wwwroot\\upload\\images\\";
$max_size = 900000;

if (!isset($files)) exit;
foreach ($files['name'] as $key=>$name) {
	if (is_uploaded_file($files['tmp_name'][$key])) {
		if ($files['size'][$key]>$max_size) { 
			echo "The file is too big<br>\n"; 
			exit; 
		}
		$get_the_size = strtolower(substr(strrchr($name,'.'),1));
			if($get_the_size == "jpg" || $get_the_size == "gif" || $get_the_size == "bmp" || $get_the_size == "png") {
				if (file_exists($path.$name)) { 
					echo "The file already exists<br>\n"; 
					exit; 
				}
				$res = copy($name, $path.$name);
					if (!$res) { 
						print "upload failed!<br>\n"; 
						print_r ($files['name']);
						exit; 
					} else { 
						echo "upload sucessful<br>\n";
					}
				echo "File Name: ".$name."<br>\n";
				echo "File Size: ".$files['size'][$key]." bytes<br>\n";
				echo "File Type: ".$files['size']['type'][$key]."<br>\n";
				echo "Link: <a href='images/".$name."'>".$name."</a><br>\n";
			} else { 
				echo "Wrong file type<br>\n"; 
				echo $name;
				exit; 
			}
}
}
?>

here is the message with the array printed

upload failed!
Array ( [0] => ball.gif [1] => rcfc_bg.jpg )

DigitalExpl0it

fixed:

changed this

$res = copy($name, $path.$name);

to:

$res = copy($files['tmp_name'][$key], $path.$name);

DigitalExpl0it

having some problems with javascript and php..

I have added some javascript that will generate a input field when you click on a button. (used so i can upload many images)

thing is, the javascript works, it displays the input field just fine, you select the image u want to uplaod then you hit upload. now the enxt page the the php script above. Thing is php cannot see the forms if they are generated by javascript.

<head>
<script language="javascript">
<!--

var counter = 0;

function moreFields()
{
	counter++;
	var newFields = document.getElementById('readroot').cloneNode(true);
	newFields.id = '';
	newFields.style.display = 'block';
	var newField = newFields.childNodes;
	for (var i=0;i<newField.length;i++)
	{
		var theName = newField[i].name
		if (theName)
			newField[i].name = theName + counter;
	}
	var insertHere = document.getElementById('writeroot');
	insertHere.parentNode.insertBefore(newFields,insertHere);
}

function init()
{
	moreFields();
}

// -->
</script>
</head>
<div id="readroot" style="display: none">
	<input type="button" value="Remove" style="font-size: 10px" onClick="this.parentNode.parentNode.removeChild(this.parentNode);"> 
	<INPUT TYPE="file" NAME="userfile[]"><br>
</div>


<FORM ENCTYPE="multipart/form-data" ACTION="<? echo $PHP_SELF; ?>" METHOD="POST">
<INPUT TYPE="file" NAME="userfile[]"><br>
<div id="writeroot"></div>
<input type="button" value="Add Field" onClick="moreFields()">
<INPUT TYPE="submit" VALUE="Upload">
</FORM>

any help would be appreciated