[Resolved] Why is there a 1?

MrCool

This one i really don't get it

<body>
<?
if(empty($_GET['id'])){
	$_GET['id']="main";
}
$file=include("files/".$_GET['id'].".php");
if (empty($file)) {
	$file=include("files/404.php");
 }
 echo $file;
?>
</body>
</html>

And the file main says:
Test <br>
This is a test <br>

But the output has a 1 at the end, why?

TheDefender

What are the contents of your 404.php file? It looks like this part is failing, and the 404.php is being included. First remove that part of the code, and if the 1 goes away, then you need to figure out why it's failing. (Incidentally, you should look through any other files that may be called by the script to see if there is a rogue 1 anywhere.)

if (empty($file)) { 
    $file=include("files/404.php"); 
 }

devinemke

because that's what include() does: it returns boolean true(1) if it works and false(0) if it fails. you are simply echoing the boolean.

TheDefender

LOL devinemke, D'OH. Completely overlooked that... Yup, the script is doing exactly what you told it to do...

MrCool

it does output the text, so how should i write it then?

devinemke

it does output the text

yes , but you do not need to spool the output of include() into a variable and echo it, that is why you are seeing a "1" after your text. see change below.

if (empty($_GET['id'])) {$_GET['id'] = 'main';}
$include = @include('files/' . $_GET['id'] . '.php');
if (!$include) {include('files/404.php');}

sidney

 <body> 
<? 
if(empty($_GET['id'])){ 
    $_GET['id']="main"; 
} 
include("files/".$_GET['id'].".php"); 
if (empty($file)) { 
    include("files/404.php"); 
 } 
?> 
</body> 
</html>

this will out put file as soonn as its called
or

 <body> 
<? 
if(empty($_GET['id'])){ 
    $_GET['id']="main"; 
} 
$file=file_get_contents("files/".$_GET['id'].".php"); 
if (empty($file)) { 
    $file=file_get_contents("files/404.php"); 
 } 
 echo $file; 
?> 
</body> 
</html>

of course the second method wont parse any php in file unless you use eval on it but i wont be echoed untill you call it

devinemke

if you want to include() a file but don't want it's output to be sent to browser right away then you can always use PHP's output buffering functions