[Resolved] while loop with if condition

[joe2]

hi,

i trying to make on albhabet like address book,means if there is record start with that particalur letter than there will be link other wise letter without link. But it is not making links for all records.

$sql="SELECT Left(ucase(name),1) AS myalphabet, Count(*) AS mycount FROM mytable GROUP BY Left(ucase(name),1)";
$result=mysql_query($sql,$link);

	$asciiStart=65;
	$asciiEnd=90;

	while($row=mysql_fetch_array($result)){
		if( (ord($row['myalphabet'])) == $asciiStart ){
			print "<a href='alphabetlisting.php?st=".$row['myalphabet']."'>".$row['myalphabet']."</a>";
		}
		else
		{
			print (" ".chr($asciiStart)." ");
		}
	$asciiStart=$asciiStart+1;
	}
	while($asciiStart <= $asciiEnd){
		print (" ".chr($asciiStart)." ");
		$asciiStart=$asciiStart+1;
	}

Thanks

[PallaviDalvi]

well joe2... the reason why all the alphabets are not getting linked is following...
it reads first rec and name is say Adam... it creats link for A and increments $asciiStart
read second rec ...name is Carrie... it does not satisfy if condition in while and so prints $asciiStart (i.e 😎 and increments $asciiStart.
then reads next record... but wait...what happened to C and Carrie???? u keep reading the records sequentially and u increment the variable also sequentially... i hope u understand what ur doing wrong...
u wud want to do some thing like ...

while($row=mysql_fetch_array($result))
{ 
	if( (ord($row['myalphabet'])) == $asciiStart )
	{ 
		print "<a href='alphabetlisting.php?st=".$row['myalphabet']."'>".$row['myalphabet']."</a>"; 
	} 
	else 
	{ 
		while (ord($row['myalphabet']) != $asciiStart)
		{
			print (" ".chr($asciiStart)." "); 
			$asciiStart=$asciiStart+1;
		}
		print "<a href='alphabetlisting.php?st=".$row['myalphabet']."'>".$row['myalphabet']."</a>";
	 } 
	$asciiStart=$asciiStart+1; 
} 

note the extra while in the else.
it worked in my case hope it works for u too.
moreover i wud suggest giving a blank space after the closing a tag... just so it looks good.! 🙂

[TheDefender]

Here is a little something worked up from a recent thread I was in. Change the table name, and field names accordingly.

$sql = "SELECT upper(left([b]employee_lastname[/b], 1)) AS letter, count(*) as cnt FROM [b]employees[/b] GROUP BY letter ORDER BY letter";
$res = mysql_query($sql);

$results = range('A', 'Z');
$results = array_flip($results);
WHILE($row = mysql_fetch_array($res)):
   $results[$row['letter']] = '<a href="thepage.php?ln='.$row['letter'].'">'.$row['letter'].'</a>';
ENDWHILE;

FOREACH($results as $k => $v):
   IF($k == "Z"):
      echo is_numeric($v) ? $k : $v;
   ELSE:
      echo is_numeric($v) ? $k." | " : $v." | ";
   ENDIF;
ENDFOREACH;

Much cleaner, and much simpler than loping through Ascii Codes...

[joe2]

Its working.

Thanks a lot.

Joe

[TheDefender]

Be sure to mark the thread resolved...Have a nice weekend.