getting strange output from conditional statement

sovtek

I'm having problems with the output of an if statement when processing a form variable.

$enter_time = ($_POST['hour']);
$enter_time .= ($_POST['minute']);

<?php if ($enter_time > 0700 && $enter_time < 2100) {
					echo $total;
				} else {
		print $total * 0.20 + $total;
}
?>

From this form drop down list:

<select name="hour">
                <option value="">hour</option>
                <option value="01">01</option>
                <option value="02">02</option>
	<option value="03">03</option>
	<option value="04">04</option>
	<option value="05">05</option>
	<option value="06">06</option>
	<option value="07">07</option>
	<option value="08">08</option>
	<option value="09">09</option>
	<option value="10">10</option>
	<option value="11">11</option>
	<option value="12">12</option>
	<option value="13">13</option>
	<option value="14">14</option>
	<option value="15">15</option>
	<option value="16">16</option>
	<option value="17">17</option>
	<option value="18">18</option>
	<option value="19">19</option>
	<option value="20">20</option>
	<option value="21">21</option>
	<option value="22">22</option>
	<option value="23">23</option>
                </select>
							  <select name="minute">
                <option value="">mins</option>
                <option value="00">00</option>
                <option value="05">05</option>
	<option value="10">10</option>
	<option value="15">15</option>
	<option value="20">20</option>
	<option value="25">25</option>
	<option value="30">30</option>
	<option value="35">35</option>
	<option value="40">40</option>
	<option value="45">45</option>
	<option value="50">50</option>
	<option value="55">55</option>
              </select>

When you select either 0500 or 0600 it displays $total instead of doing the multiplication.
I am at a loss as to why.

TIA

drew010

try this:

<?php 
if ((int)$enter_time > 700 && (int)$enter_time < 2100) {
    echo $total;
} else {
    print $total * 0.20 + $total;
}
?>

BuzzLY

4 points, most likely unrelated to your problem, but significant nonetheless:

Why don't you have a 00 hour? It IS a 24 hour format, right?
Why use echo in one place, and print in another? I know you probably know they are almost identical, but someone modifying your code a year from now might not, and it can be confusing. Personally, I use echo for normal code operation, and print for debugging.
Your calculation could be made simpler by simply multiplying ($total * 1.2), don't you think?
You work for the $#&%#*@! phone company, don't you???

sovtek

Originally posted by BuzzLY
4 points, most likely unrelated to your problem, but significant nonetheless: Why don't you have a 00 hour? It IS a 24 hour format, right?

Thanks for pointing that out, I hadn't picked up on that little error.

Why use echo in one place, and print in another? I know you probably know they are almost identical, but someone modifying your code a year from now might not, and it can be confusing.

Because there are two of us working on this and we are both PHP newbs. He uses echo, I usually use print.

sonally, I use echo for normal code operation, and print for debugging.

I don't actually have enough experience to know which is better for a given situation...so I'll heed your advice.

Your calculation could be made simpler by simply multiplying ($total * 1.2), don't you think?

You are correct again. Thanks. I didn't do well in math. 🙂

You work for the $#&%#*@! phone company, don't you???

Huh?

Anyway, tanks a million for the tips.

Weedpacket

Try this:

echo 0700;

Then look at this.
Remember that 1200-1130 is 70, not 30.
There are sixty minutes in an hour, not a hundred, so the duration (in minutes) is minutes+60*hours.

BuzzLY

Originally posted by sovtek
Because there are two of us working on this and we are both PHP newbs. He uses echo, I usually use print. I don't actually have enough experience to know which is better for a given situation...so I'll heed your advice.

Neither is necessarily better than the other. I just like to be consistent in my code, and by using "print" for all debugging allows me to easily find all the places in my code that I'm printing debug messages to the screen (find and replace "print" with "//print" to disable them all at once without worrying about disabling actual code). Someone in another thread mentioned that they also use this technique a while back.

Re: Phone company: Huh?

You are adding 20% to the $total when the time is between 7am and 9pm... so I assumed you work for a cell phone company 😃