[Resolved] Using functions with template class?

[move3rd]

while adding a templating system to cubecart I have ran into a problem.

This function is inlcuded in the site header.php:

// countries drop down list
function countries($name,$selected_country,$prefix)
{

$select = mysql_query ("select country from ".$prefix."store_countries");

$content .="<select name=$name>";
    while ($row = mysql_fetch_array($select))
      {
          $country = $row["country"];

  $content .="<option value=\"$country\" ";
if($country==$selected_country){$content .="selected";}

$content .=">$country</option>";
	}
  $content .="</select>";
}

The templating system will output $content to the screen. For some unkown reason it isnt outputing the drop down list on my customer registration page:

countries("country",$site_country,$prefix);
							$content .="<font color=\"#990000\"> *</font>";

when I change the function so that it uses echo to output rather than the templates systems $content it outputs the dropdown list as it should so I know there is no problem with the function.

How can I get it to output using $content?😕

[crimaniak]

$content variable is local for function and lost on function exit. Try return $content;

BTW, Don't add space after each option. Add it BEFORE 'selected' keyword.

[drawmack]

because $content as you're using is local to the fucntion. There a two ways to handle this

// method 1 - not the prefered solution
function countries($name,$selected_country,$prefix)
{
    global $content;
    .
    .
    .
}

This method uses the global variable $content, but it makes the function unportable.

//method 2 - the prefered method
function countries($name,$selected_country,$prefix,&$content)
{
    .
    .
    .
}

This method passes content by address which leaves the function portable to other systems.

[move3rd]

Thank you both...

Originally posted by drawmack

//method 2 - the prefered method
function countries($name,$selected_country,$prefix,&$content)
{
    .
    .
    .
}

This method passes content by address which leaves the function portable to other systems. [/B]

I tried the above but it still didnt output. So you are telling me that $content is a variable that is already in use yes?

I tried changing the variable that the template system uses to $main_page_content but it still didnt output?

[drawmack]

if you use that method then in your call to the function you have to add $conetent too. Also $content should be declared before calling the function.

[move3rd]

Originally posted by drawmack
if you use that method then in your call to the function you have to add $conetent too. Also $content should be declared before calling the function.

You mean even if I'm using $main_page_content instead of $content with the template system I still need to add $content to the function as you showed me above:

//method 2 - the prefered method
function countries($name,$selected_country,$prefix,&$content)
{
    .
    .
    .
}

$main_page_content is declared before i use the function is called and I tried adding &$content and &$main_page_content ~( I wasnt shure what you ment) to the function but it still isnt outputing.

[ahundiak]

You are making it too hard. No need to pass $content as an argument. Just return it.

function countries($name,$selected_country,$prefix)
{
  $content = '<select ...';
  ...
  return $content;
}

$content_so_far .= countries($name ...);

[move3rd]

Thanks,

It still isnt working though. Here's what I have:

// countries drop down list
function countries($name,$selected_country,$prefix)
{

$select = mysql_query ("select country from ".$prefix."store_countries");
$content ="<select name=$name>";
    while ($row = mysql_fetch_array($select))
      {
          $country = $row["country"];

  $content .="<option value=\"$country\" ";
if($country==$selected_country)
{$content .="selected";}
$main_page_content .=">$country</option>";
	}
  $content .="</select>";

  return $content;
}


$main_page_content .="<font color=\"#990000\"> *</font>";

//The select box to be added to the $main_page_content varible here
countries("country",$site_country,$prefix);
													$main_page_content .="<font color=\"#990000\"> *</font>";

:queasy:

--- edited ---
code to prevent page width going west

[drawmack]

// countries drop down list
function countries($name,$selected_country,$prefix)
{

$select = mysql_query ("select country from ".$prefix."store_countries");
$content ="<select name=$name>";
    while ($row = mysql_fetch_array($select))
      {
          $country = $row["country"];

  $content .="<option value=\"$country\" ";
if($country==$selected_country){$content .="selected";}$main_page_content .=">$country</option>";
	}
  $content .="</select>";

  return $content;
}


$main_page_content .="<font color=\"#990000\"> *</font>";

//The select box to be added to the $main_page_content varible here
$main_page_content .= countries("country",$site_country,$prefix);
													$main_page_content .="<font color=\"#990000\"> *</font>";

[move3rd]

Thanks for you help!😃

Sorry you had to spell it out for me....:rolleyes:

I'm getting better everyday ... I'm getting better everyday ... I'm getting better everyday ... I'm getting better everyday ...I'm getting better everyday ...I'm getting better everyday ...I'm getting better everyday ...I'm getting better everyday ...

🙂