implode problem

[franwpd]

I am trying to achieve comma's. I want this to show

A101, A100

but what I get is

1, A1012, A100

What am I doing wrong?

<php>

$sql = mysql_query("SELECT * FROM tablenames") or die (mysql_error());

$count = mysql_num_rows($sql);

for($i=0;$i<$count;$i++)

{

$row = mysql_fetch_row($sql);
$array = ($row);

 $row = implode(", ",  $array); 
 print $row; 

}

</php>

[drawmack]

assuming that tablenames has only more then one column and you want to print a commafied list of the table names, which is only one column, do this.

$sql = mysql_query("SELECT <table_name> FROM tablenames") or die (mysql_error());

$tables = array();
while($row = mysql_fetch_array($sql)) {
    $tables[] = $row[0];
}
print $row; 

and replace <table_name> with the name of the column containing the table name.

[franwpd]

Here is my DB:

CREATE TABLE tablenames (
tablename_id int(5) unsigned NOT NULL auto_increment,
tablename varchar(25) NOT NULL default '',
PRIMARY KEY (tablename_id)
) TYPE=MyISAM AUTO_INCREMENT=3 ;

((This prints nothing. So I think I still don't get it.))

<php>

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error());

$tables = array();
while($row = mysql_fetch_array($sql)) {
$tables[] = $row[0];
}
print $row;

<php>

When I get the DB filled, it should print like this:

A101, A102, A103

With the comma's added but none on the end.

[Antistatic]

Your last php code has no implode?

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error());

$tables = array();
while($row = mysql_fetch_array($sql)) {
$tables[] = $row[0];
}

$data = implode(", ", $tables);

print $data;

[franwpd]

THANK YOU!!!!

[franwpd]

Got too excited...there is a comma at the end. This is a piece to a larger code and it must not have commas on the end. Any suggestions? We are almost there!!

[Antistatic]

That means your array contains blank items in it, if you were to print_r it im sure you would see blanks.

for the meantime try adding

foreach ($tables as $key => $value) {
   if ($value == NULL) { unset($tables[$key]); }
}

like:

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error()); 

$tables = array(); 
while($row = mysql_fetch_array($sql)) { 
$tables[] = $row[0]; 
} 

foreach ($tables as $key => $value) {
   if ($value == NULL) { unset($tables[$key]); }
}

$data = implode(", ", $tables); 

print $data;

This is just a workaround, all it is doing is removing the blanks from the array... and hopefully this will work.

[bubblenut]

Why not just never put them into the array if they're empty?

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error()); 

$tables = array(); 
while($row = mysql_fetch_array($sql))
	if($value != null)
		$tables[] = $row[0]; 

$data = implode(", ", $tables); 

print $data;

[Antistatic]

Originally posted by bubblenut
Why not just never put them into the array if they're empty?

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error()); 

$tables = array(); 
while($row = mysql_fetch_array($sql))
	if($row[0] !== null)
		$tables[] = $row[0]; 

$data = implode(", ", $tables); 

print $data;

[/B]

fixed.

[franwpd]

For those who need to know...

<php>

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error());

$tables = array();

while($row = mysql_fetch_array($sql)) {

$tables[] = $row[0];

}

foreach ($tables as $key => $value) {
if ($value == NULL) { unset($tables[$key]); }
}

$data = implode(", ", $tables);

print $data;

<php>

Prints A100, A101 Final Answer! Thanks ;-)

[yanivamar]

Antistatic;10530743 wrote:

Your last php code has no implode?

$sql = mysql_query("SELECT tablename FROM tablenames") or die (mysql_error());

$tables = array();
while($row = mysql_fetch_array($sql)) {
$tables[] = $row[0];
}

$data = implode(", ", $tables);

print $data;

THANK YOU I have been looking for this for 12 hours. I just couldn't get why my program would not work,