File upload problem

yuda_zdk

I have made an upload file form

<form enctype="multipart/form-data" action="<?=$PHP_SELF?>" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="10240" />
Send this file: <input name="userfile" type="file" />
<BR><BR><input type="submit" value="Send File" />
</form>

No value is updated after submitting the form.
The only value updated is: MAX_FILE_SIZE

If I change the form method to "GET"
the value is updated with the file name only

For example :

userfile will be presented as: adsl5.jpg

instead of:
/var/www/html/pictures/adsl5.jpg

What could be my problem ?

ZibingsCoder

Not to seem like a jerk, but have you read the corresponding PHP manual pages?

yuda_zdk

I have read the manual and followed it.
That's why I posted the message.

Thanx & best regards

Weedpacket

No problem. It's working as expected. A file named "adsl5.jpg" was uploaded, and $_FILES['userfile']['name'] has the vaue "adsl5.jpg". What path information are you expecting it to have?

yuda_zdk

I ecxpect it to have all ther path:
/var/www/html/pictures/adsl5.jpg

And why doesn't it work when the method is POST ?
it works only when the method is GET.

Thanx & best regards

snoj

cut'n'paste your code here... the html and the php, all of it.

yuda_zdk

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
<HEAD>
<TITLE> New Document </TITLE>
<META NAME="Generator" CONTENT="EditPlus">
<META NAME="Author" CONTENT="">
<META NAME="Keywords" CONTENT="">
<META NAME="Description" CONTENT="">
</HEAD>

<BODY BGCOLOR="#FFFFFF">
<form enctype="multipart/form-data" action="<?=$PHP_SELF?>" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="10240" />
Send this file: <input name="userfile" type="file" />
<BR><BR><input type="submit" value="Send File" />
</form>
<br><br>

<?php
while(list($key, $val) = each($POST)) {
$$key = $val;
echo "key=".$key." val=".$val."<br>"; // For debug purpose
}
echo "<br>";
echo "files_tmp_name=".$FILES['userfile']['tmp_name']; // For debug purpose
echo "<br>";
echo "file name= ".$userfile_name."<br><br>"; // For debug purpose
$uploaddir="images";
if (!empty($userfile)) {
$uploadfile=$userfile_name;
copy($userfile,$uploaddir."/".$userfile_name);
}
?>

    price:&nbsp;&nbsp;<INPUT TYPE="text" NAME="price"><BR>
    price_sale:&nbsp;&nbsp;<INPUT TYPE="text" NAME="price_sale"><BR>
    details:&nbsp;&nbsp;<INPUT TYPE="text" NAME="details"><BR>
    rem1:&nbsp;&nbsp;<INPUT TYPE="text" NAME="rem1"><BR>
    rem2:&nbsp;&nbsp;<INPUT TYPE="text" NAME="rem2"><BR>
    rem3:&nbsp;&nbsp;<INPUT TYPE="text" NAME="rem3"><BR><BR>
    <INPUT TYPE="reset" value="send">&nbsp;&nbsp;<INPUT TYPE="submit" value=reset>

</FORM>
</BODY>
</HTML>

snoj

here you go:

changes:

always start hp files with <?php. You never know what platform you'll be running on so declare it's PHP.
stop relying on register_globals to be 'on'. It is bad practice as it makes it easier for developers to create security holes. I removed all variables using register_globals, replaced them by $_FILES['userfile'] everywhere.

Note: you were mixing the $FILES variable with the $userfile variable. I don't think that's "wrong" but it definitely isn't good either! Use $FILES.

All this is documented on the PHP 'uploading files' page:
http://ch2.php.net/features.file-upload

I also commented out the unnecessary html form at the bottom of your page. Fell free to uncomment.

this works fine, tested (careful about the wrapping):

<?php

<form enctype="multipart/form-data" action="<?=$PHP_SELF?>" method="POST"> 
	<input type="hidden" name="MAX_FILE_SIZE" value="10240" /> 
	Send this file: <input name="userfile" type="file" /> 
		<BR>
		<BR>
	<input type="submit" value="Send File" /> 
</form>

<br>
<br>

<?php

while(list($key, $val) = each($_POST)) { 
	$$key = $val; 
	echo "key=".$key." val=".$val."<br>"; // For debug purpose 
}
echo "<br>";
echo "files_tmp_name=".$_FILES['userfile']['tmp_name']; // For debug purpose
echo "<br>";
echo "file name= ".$_FILES['userfile']['name']."<br><br>"; // For debug purpose
$uploaddir="images";

if ( is_uploaded_file($_FILES['userfile']['tmp_name']) ) {
	move_uploaded_file($_FILES['userfile']['tmp_name'], $uploaddir."/".$_FILES['userfile']['name']);
}

<!--

price: <INPUT TYPE="text" NAME="price"><BR>
price_sale: <INPUT TYPE="text" NAME="price_sale"><BR>
details: <INPUT TYPE="text" NAME="details"><BR>
rem1: <INPUT TYPE="text" NAME="rem1"><BR>
rem2: <INPUT TYPE="text" NAME="rem2"><BR>
rem3: <INPUT TYPE="text" NAME="rem3"><BR><BR>
<INPUT TYPE="reset" value="send"> <INPUT TYPE="submit" value=reset>
</FORM>

-->

</BODY>
</HTML>

yuda_zdk

First thanks.

I changed my code:

<?php

<?php
while(list($key, $val) = each($_POST)) {
$$key = $val;
echo "key=".$key." val=".$val."<br>"; // For debug purpose
}

    echo "<br>";
    echo "files_tmp_name=".$_FILES['userfile']['tmp_name']; // For debug purpose
    echo "<br>";
    //echo "file name= ".$userfile_name."<br><br>"; // For debug purpose
     echo "file name= ".$_FILES['userfile']['name']."<br><br>"; // For debug purpose

    $uploaddir="images";

    if ( is_uploaded_file($_FILES['userfile']['tmp_name']) ) {
            move_uploaded_file($_FILES['userfile']['tmp_name'], $uploaddir."/".$_FILES['userfile']['name']);
            $img_src="<IMG SRC\"".$uploaddir."/".$userfile_name."\">";
            echo "<br><br>";
            echo $img_src;
    }

It doesn't work.
$_FILES['userfile']['tmp_name'] is null from some reason.
I thought it might do with file permissions.I changed the
relevant permissions and still it doesn't work.
I work with Apache, php 4.2 and Mozilla.

Thanks & best regards

snoj

what is the size of the file you are trying to upload ?

what is your post_max_size and upload_max_filesize ?

if the file is too big to be uploaded, tmp_name is empty!

planetsim

Obviously you didnt read the part in File Uploads about errors.

http://www.php.net/manual/en/features.file-upload.errors.php

Should give you an idea on why your getting a blank result. However it probably is the case that the file you are uploading is too big for the PHP Configuration.