Need help with Queries and stuff

Richardtagger

For my read page of the internal mailing system i want a table with the user its from in one column and the subject in another. So far i have.

<?
session_start();
include 'db.php';
$username = $_SESSION['username'];

$sql_username_check = mysql_query("SELECT touser FROM mail WHERE touser='$username'");
$result = mysql_db_query("sheetshare", $sql_username_check);


$fromuser = ("fromuser Where id='$id'");
$sub  =  ("sub Where id='$id'");

if  ($result) 
{ 
echo "<font face='Tahoma'>Here are the results:<br><font face='Tahoma'><br>"; 
echo "<table width=90% align=center border=1 bordercolor=#111111 style=border-collapse: collapse><tr> 
    <font face='Tahoma'>
	<td align=center bgcolor=#FFFFFF><font face='Tahoma'>From</td> 
    <td align=center bgcolor=#FFFFFF><font face='Tahoma'>Subject</td> 
    </tr></font>"; 

    while ($r = mysql_fetch_array($result)) {     // Begin while 
        $from = $r["from"]; 
        $sub = $r["sub"]; 
              echo "<tr>
                    <td align=center>$from</td> 
                    <td align=center>$sub</td>"; 
    }                  // end while 
    echo "</table>"; 
 } else { echo "<font face='Tahoma'>Error, Contact Webmaster at SheetShare."; } 
   else { 
   echo "<font face='Tahoma'>You did not select anything to search for. <br><font face='Tahoma'> Please enter something above."; 
   } 
?>

i get parse error on the else line, 5 from final line. I dont know how to fix these things as my PHP isnt very good. Could i have a simple answer pls as i get easily confused.

laserlight

One thing that you should do is to use a consistent indent style:

<?php
session_start();
include 'db.php';
$username = $_SESSION['username'];

$sql_username_check = mysql_query("SELECT touser FROM mail WHERE touser='$username'");
$result = mysql_db_query("sheetshare", $sql_username_check);

$fromuser = "fromuser Where id='$id'";
$sub = "sub Where id='$id'";

if ($result)
{
	echo "<font face='Tahoma'>Here are the results:<br><font face='Tahoma'><br>"; 
	echo "<table width=90% align=center border=1 bordercolor=#111111 style=border-collapse: collapse><tr>
<font face='Tahoma'>
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>From</td>
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>Subject</td>
</tr></font>"; 

while ($r = mysql_fetch_array($result))
{
	$from = $r["from"];
	$sub = $r["sub"];
	echo "<tr>
<td align=center>$from</td>
<td align=center>$sub</td>"; 
	}
	echo "</table>"; 
}
else
{
	echo "<font face='Tahoma'>Error, Contact Webmaster at SheetShare.";
}
	/*** OOPS! Where does this else fit in?! ***/
	else { 
	echo "<font face='Tahoma'>You did not select anything to search for. <br><font face='Tahoma'> Please enter something above."; 
} 
?>

Richardtagger

Well thanx, that fixed the SQL error, but its not returning a result there i get the error please contact webmaster part.

 <?php 
include 'db.php'; 
$username = $_SESSION['username']; 

$sql_username_check = mysql_query("SELECT * FROM mail WHERE touser='$username'"); 
$result = mysql_db_query("sheetshare", $sql_username_check); 

$fromuser = "fromuser Where id='$id'"; 
$sub = "sub Where id='$id'"; 

if ($result) 
{ 
    echo "<font face='Tahoma'>Here are the results:<br><font face='Tahoma'><br>";  

    echo "<table width=90% align=center border=1 bordercolor=#111111 style=border-collapse: collapse><tr> 
<font face='Tahoma'> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>From</td> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>Subject</td> 
</tr></font>";  

while ($r = mysql_fetch_array($result)) 
{ 
    $from = $r["from"]; 
    $sub = $r["sub"]; 
    echo "<tr> 
<td align=center>$from</td> 
<td align=center>$sub</td>";  

    } 
    echo "</table>";  

} 
else 
{ 
    echo "<font face='Tahoma'>Error, Contact Webmaster at SheetShare."; 
}  

?>

Thankyou in advance for anyone who manages to ammend my code.

laserlight

You're using a poor method to send your query.

Dont use [man]mysql_db_query/man, stick to [man]mysql_query/man.

Stick to connecting to the database and selecting the database, and then running the queries.

Richardtagger

i now get this

Warning: mysql_query(): supplied resource is not a valid MySQL-Link resource in /home/sites/site603/users/sheetshare/web/pmsg/readpage.php on line 6

laserlight

Just use:

$result = mysql_query("SELECT * FROM mail WHERE touser='$username'");

Richardtagger

ok, that wasnt returning a result and that was because i wasnt defining what $id was, i tried to add a query to fetch the id but it didnt work i get the cant jump to row 0 error.

can anyone spot the prob here?

 <?php 
include 'db.php'; 
$username = $_SESSION['username']; 

$result = mysql_query("SELECT * FROM mail WHERE touser='$username'");

$idquery = mysql_query("SELECT id FROM mail WHERE touser='$username'");
$id = mysql_result($idquery,0,"id");

$fromuser = "fromuser Where id='$id'"; 
$sub = "sub Where id='$id'"; 

if ($result) 
{ 
    echo "<font face='Tahoma'>Here are the results:<br><font face='Tahoma'><br>";  

    echo "<table width=90% align=center border=1 bordercolor=#111111 style=border-collapse: collapse><tr> 
<font face='Tahoma'> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>From</td> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>Subject</td> 
</tr></font>";  

while ($r = mysql_fetch_array($result)) 
{ 
    $from = $r["from"]; 
    $sub = $r["sub"]; 
    echo "<tr>
                    <td align=center>$from</td> 
                    <td align=center>$sub</td>"; 
    }                  // end while 
    echo "</table>";   
} 
else 
{ 
    echo "<font face='Tahoma'>Error, Contact Webmaster at SheetShare."; 
}  

?>

Thanx

dnast

You don't need another query for the id. It's already in $result.

$id = mysql_result($result,0,"id");

That would do the same thing, although it seems your problem might be in the SQL.

For debugging purposes, change it to

$query = "SELECT * FROM mail WHERE touser='$username'";
$result = mysql_query($query)
    or die(mysql_error());

Do that and echo $query, and you'll probably see what's wrong right away.

Richardtagger

I added the echo $result line in and the words Resource id #2 appeared. Whats that about?

dnast

You can't echo a whole result set. The most you can do is use [man]print_r[/man] on a row.

Did everything look okay with "echo $query"?

Richardtagger

I echoed $query and got
select * from mail WHERE touser = 'Tagger'

That's what it should be.

Whats wrong?

<?php 
session_start();
include 'db.php';
$username = $_SESSION['username']; 

$query = "SELECT * FROM mail WHERE touser= '$username'"; 
$result = mysql_query($query) 
    or die(mysql_error());
$id = mysql_result($result,0,"id"); 

$fromuser = "fromuser Where id='$id'"; 
$sub = "sub Where id='$id'";

echo $query;

if ($result) 
{ 
    echo "<font face='Tahoma'>Here are the results:<br><font face='Tahoma'><br>";  

    echo "<table width=40% align=center border=1 bordercolor=#111111 style=border-collapse: collapse><tr> 
<font face='Tahoma'> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>From</td> 
<td align=center bgcolor=#FFFFFF><font face='Tahoma'>Subject</td> 
</tr></font>";  

while ($r = mysql_fetch_array($result)) 
{ 
    $from = $r["fromuser"]; 
    $sub = $r["sub"]; 
    echo "<tr>
                    <td align=left>$fromuser</td> 
                    <td align=left>$sub</td>"; 
    }                  // end while 
    echo "</table>";   
} 
else 
{ 
    echo "<font face='Tahoma'>Error, Contact Webmaster at SheetShare."; 
}  

?>