email validation

[tazgalsinh]

am trying to do a simple email validation but can't get it to work. all it is a simple mailing list form to add the email address to my mailing list.

i obtained this code. but i don't know how to fit it into my form if anyone could give help.

function validate_address( $email )
{
    if ( preg_match( '/^[A-z0-9\._-]+[@][A-z0-9_-]+([.][A-z0-9\._-]+)+[A-z]{2,4}$/', $email ) )
    {
        return( ( bool )true );
    }
    else
    {
        return( ( bool )false );
    }
}

if ( validate_address( '[e-mail]' ) ) echo( 'good' ); else echo( 'not good' ); 

[PallaviDalvi]

well i didnt really understand what ur prob was... is the code not working or u dont know where to use it?
if the prob is that its not working... must be some thing wrong at ur end... its working fine for me.
if the prob is that u dont know how to use it... i wud suggest u start with reading up on functions in PHP.

[tazgalsinh]

its just how to use the functions, am reading through the manual but can't find a simple way to show how to use it

[PallaviDalvi]

well u dont really have to read the manuals also... the code u posted has a call to the function!!!!!
just modify it to do what u want.

[tazgalsinh]

could you give me a quick example off how to use it with a form

[PallaviDalvi]

if ( validate_address( $_POST['email']) ) 
      echo( 'good' ); 
else 
      echo( 'not good' );

where $_POST['email'] contains the value entered in the email field.

[tazgalsinh]

i tried that with this but no luck:

<form name="form1" method="post" action="">
  <input type="text" name="email">
  <input type="submit" name="Submit" value="Submit">
</form>
<?php
function validate_address( $email )
{
    if ( preg_match( '/^[A-z0-9._-]+[@][A-z0-9_-]+([.][A-z0-9._-]+)+[A-z]{2,4}$/', $email ) )
    {
        return( ( bool )true );
    }
    else
    {
        return( ( bool )false );
    }
}

if ( validate_address( '[e-mail]' ) ) echo( 'good' ); else echo( 'not good' );
?>

[PallaviDalvi]

well either ur totally confused or u havent posted the entire code.
1. in the code posted below...the function is called as
validate_address( '[e-mail]' ) obviously in this case the email entered on the form will not be validated! u need to pass the entered email as a parameter to the function.

2. the validation of this email has to be done AFTER the form has been posted (atleast thats what my peice of code was doing).

if you havent understood what i've pointed out ... let me know....

[tazgalsinh]

sorry, i confused. this is the first time i have touched on functions

[PallaviDalvi]

is the prob solved or u need further help?

[tazgalsinh]

still need further help sorry

[PallaviDalvi]

well first off... i'd suggest u read thru the manual for help on functions. i can help u with what u have to do here....

<form name="form1" method="post" action=""> 
  <input type="text" name="email"> 
  <input type="submit" name="Submit" value="Submit"> 
</form> 

<?php 

function validate_address( $email ) 
{ 
    if ( preg_match( '/^[A-z0-9._-]+[@][A-z0-9_-]+([.][A-z0-9._-]+)+[A-z]{2,4}$/', $email ) ) 
    { 
        return( ( bool )true ); 
    } 
    else 
    { 
        return( ( bool )false ); 
    } 
} 

if (sizeof($_POST))
{
	//other validation code 
	if ( validate_address($_POST['email'] ) ) 
		// do whatever u want to when the email is ok
	else 
		//do what u want to when email is not correct.

//further code
}
?>

hope that helps

PS: in future wud be good for u if u understand the code ur coping before expecting it to work!

[tazgalsinh]

when i use the above code all that is displayed is a blank screen

[PallaviDalvi]

can u post ur code as in the current state?

[tazgalsinh]

<form name="form1" method="post" action="">
  <input type="text" name="email">
  <input type="submit" name="Submit" value="Submit">
</form>

<?php 

function validate_address( $email ) 
{ 
    if ( preg_match( '/^[A-z0-9._-]+[@][A-z0-9_-]+([.][A-z0-9._-]+)+[A-z]{2,4}$/', $email ) ) 
    { 
        return( ( bool )true ); 
    } 
    else 
    { 
        return( ( bool )false ); 
    } 
} 

if (sizeof($_POST))
{
    //other validation code
    if ( validate_address($_POST['email'] ) ) 
        // do whatever u want to when the email is ok
    else 
        //do what u want to when email is not correct.

//further code
}
?> 

[PallaviDalvi]

well!!! i seriously suggest that u read thru the manual for PHP... not only functions. I cant help u any further if the code u posted below is what u expect to work for u!
or do u expect me to code the whole thing for u and make it work????

[tazgalsinh]

<?php
Function ValidEmail($email)
{
if (eregi("^[a-z0-9\._-]+@+[a-z0-9\._-]+\.+[a-z]{2,3}$" , $email))
return true;
else
return false;
}
?> 
<?php
$mail1 = "[e-mail]";
If (ValidEmail($mail1))
echo "valid email address";
Else
echo "invalid email address"; 
?>

i understand this now. its checking the varible mail1: so "[e-mail]" is valid.

<?php
$formemail = "tazhotm.com";
?>

<?php
Function ValidEmail($email)
{
if (eregi("^[a-z0-9\._-]+@+[a-z0-9\._-]+\.+[a-z]{2,3}$" , $email))
return true;
else
return false;
}
?> 
<?php
$mail1 = "$formemail";
If (ValidEmail($mail1))
echo "valid email address";
Else
echo "invalid email address"; 
?>

and i can declare the varible like this. so this email is incorrect now.

but how do i get the email from a form? and is it possible to do it all in the same script?

[PallaviDalvi]

combine this understanding with the code posted by me.

[tazgalsinh]

i got two scripts now

form.htm

<form method="post" action="valform.php">
  Email: <input name="formemail" type="text" /><br />
   <input type="submit" />
</form>

and valform.php

<?php
Function ValidEmail($email)
{
if (eregi("^[a-z0-9\._-]+@+[a-z0-9\._-]+\.+[a-z]{2,3}$" , $email))
return true;
else
return false;
}
?> 
<?php
$mail1 = "$formemail";
If (ValidEmail($mail1))
echo "valid email address";
Else
echo "invalid email address"; 
?>

how do i make this into one?

[tazgalsinh]

<form method="post" action="">
  Email: <input name="formemail" type="text" /><br />
   <input type="submit" />
</form>

<?php
Function ValidEmail($email)
{
if (eregi("^[a-z0-9\._-]+@+[a-z0-9\._-]+\.+[a-z]{2,3}$" , $email))
return true;
else
return false;
}
?> 
<?php
$mail1 = "$formemail";
If (ValidEmail($mail1))
echo "valid email address";
Else
echo "invalid email address"; 
?>

this works now except, when i load the script. invalid email address, is displayed