Variables & Functions

[iceman2g]

Is there any particular rule when using a variable set at the start of a script with functions that invovle a switch. Reason being I have a little poll i've been working on but i'm using functions and a switch but can't seem to get any of my set variables to work. It'll only work if I include it within that particular function. Here's my script.

echo"<table align=\"left\" width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\">";



// display poll question and options.
function poll()	{
//I set the variable $id = 3 within the function as it doesn't work outside this function.
$id = '3';
$sql = mysql_query("SELECT store_polls.poll_question FROM store_polls WHERE store_polls.poll_id ='$id' "); 
 if (!$sql) 	{
    echo 'Query failed: ', mysql_error();
    exit;
				}
while ($question = mysql_fetch_array($sql))
   				{
		$poll_question = $question['poll_question'];

echo "$poll_question"; 
				}				

$sql = ("SELECT store_polls.poll_question, store_poll_options.poll_option_id, store_poll_options.poll_option_text 
 FROM store_polls, store_poll_options WHERE store_polls.poll_id ='$id' AND store_poll_options.poll_id = '$id' "); 
$result = mysql_query($sql);  

if (!$result) 	{
    echo 'Query failed: ', mysql_error();
    exit;
				}				
echo"<form method=\"get\" action=\"polls.php\">";

while ($row = mysql_fetch_assoc($result))
				{ 
  		$option = $row['poll_option_text'];  

  		$poll_id = $row['poll_option_id'];

echo "<input type=\"radio\" valign=\"top\" name=\"poll\" value=\"$poll_id\">$option<br>";  

	 			}						
echo"<input type=\"hidden\" name=\"cmd\" value=\"poll_results\"><br>"; 
echo"<div align=\"center\"><input type=\"submit\" value=\"vote\"></div>"; 
echo"</form>"; 
echo"</table>"; 
					}   


//submit poll results
function poll_results($poll, $id){

$sql = mysql_query("UPDATE store_poll_options SET poll_results = (poll_results + 0) WHERE poll_option_id = '$poll' ");
if (!$sql) {
	echo 'Query failed: ', mysql_error();
	       }

//Here you can see i'm trying to get the total of poll_results where the poll_id = $id (3).
$total = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = '$id'");
$test = $total['poll_results']; 

$question = ("SELECT * FROM store_polls WHERE poll_id = '$id'");
$sql = mysql_query($question);
while ($row = mysql_fetch_assoc($sql))
			{
$question = $row['poll_question'];

		}
echo "$question<br><br>";


$results = mysql_query("SELECT poll_option_text, poll_results FROM store_poll_options 
WHERE poll_id = '$id' ORDER BY poll_results DESC ");
if ($results)


while ($row = mysql_fetch_assoc($results))
			{

$poll_result = $row['poll_results']/$test*100;
$poll_option = $row['poll_option_text'];


echo"$poll_option<br>";
echo"($poll_result)<br>";
				}				 } 

switch($_REQUEST['cmd']){  

    default: 
    poll(); 
    break;
//Notice here I set the value of the variable $id to 3.    

    case "poll_results":
    poll_results($_GET['poll'], '3');
    break;   

						}

As you can see I have two ways in which I can get the variable $id to work in my script however i'd like to not have to use either of these instead i'd like to have it at the start of my script so when switching the poll I only need to change it once.

My other problem is because i'm not able to set the variables at the start and have it work, i'm not able to get the SELECT SUM(poll_results) query to work. I've tryed putting it within the function poll_results() but it doesn't give me the intended result. In fact using $test = $total['poll_results']; it doesn't work period. Omitting the ['poll_results'] works to a certain extent but not like it's suppose. What i'm basically trying to do with this is divide the individual poll results by the total combimed poll_results then multiply it by 100 to get my percentage.

What might I be missing when setting my variables. Any help would be greatly appreciated.

[Shrike]

I'm not quite sure what you are trying to do, but there are a few ways to get global scope variables into functions

// Define a global variable
$foo = 1;
//define a function
function foo(){
  // Import global variable $foo
  global $foo
  echo $foo;
}
foo(); // Echoes 1
// Define a function, and pass global variable by value
function bar($foo){
  echo $foo;
}
bar($foo); // Echoes 1
// You can move variables from local scope to global scope
function foobar(){
  $foo = 1;
  return $foo;
}
$foo = foobar();
echo $foo; // Echoes 1

Hope this makes some sense 🙂

[iceman2g]

Thanks for that. I do however have another question. Currently i'm using a SELECT SUM query to get the total sum a number of rows from a selected COLUMN.

Here's the code i'm using.

$sum = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE 

poll_id = '$id'");

Now this works fine in phpmyadmin but when used in conjunction with the rest of my code it doesn't work as intended. Instead of returning the sum of the rows pertaining to that particular column it returns the total number of rows.

i.e.

I have 14 rows in a column, for that column i'd like all the rows with the same poll_id to be added together and returned as a total.

Note there are 6 rows with the same poll_id so they should be added together to give me one total.

Now here's the code used in phpmyadmin, you'll notice it returns a sum of 229 as that's the total of all the rows with identical a poll_id.

Now here's the code i'm using in conjuction withthe SELECT SUM query.

$sql = mysql_query("UPDATE store_poll_options SET poll_results = (poll_results + 

0) WHERE poll_option_id = '$poll' ");
if (!$sql) {
	echo 'Query failed: ', mysql_error();
	       }

$question = ("SELECT * FROM store_polls WHERE poll_id = '$id'");
$sql = mysql_query($question);
while ($row = mysql_fetch_assoc($sql))
			{
$question = $row['poll_question'];

		}
echo "$question<br><br>";

$results = mysql_query("SELECT poll_option_text, poll_results FROM store_poll_options 
WHERE poll_id = '$id' ORDER BY poll_results DESC ");
if ($results)


while ($row = mysql_fetch_assoc($results))
//here's the SELECT SUM query			{
$sum = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = 

'$id'");		
    $poll_result = $row['poll_results']/ $sum * 100;
	$poll_option = $row['poll_option_text'];


echo"$poll_option<br>";
echo"$poll_result<br>";

[dcav]

That's what you need to do:

$sum = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = 

'$id'");         

    $poll_result = $row['SUM(poll_results)']/ $sum * 100; 
    $poll_option = $row['poll_option_text']; 


echo"$poll_option<br>"; 
echo"$poll_result<br>";

Good luck 🙂

[iceman2g]

Tryed it but don't seem to be having any luck. Is there any other way to get this to work as i'd like.

[dcav]

You didn't even use mysql_fetch_assoc

[iceman2g]

Sorry for my ignorance but what do you mean by that? I've only used the mysql_fetch_assoc with the while clause. Can you explain. Thank you.

[dcav]

The only times you don't need to use mysql_fetch is when you perform INSERT / DELETE / CREATE because those action do not return a result set.

Since you are using a SELECT, in order to get the result, you need to use fetch.

I don't know why you have a while there, but this should work on its own.

$sumQuery = "SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = '". $id . "'";          

$sum = mysql_query($sumQuery);

// Since SUM is only a single record result, you don't need to loop this...
$ansRow = mysql_fetch_assoc($sum);

$poll_result = $ansRow ['SUM(poll_results)']; 
$poll_option = $ansRow ['poll_option_text'];  

echo"$poll_option<br>";  

echo"$poll_result<br>";

I might have some syntax error here and there, but that's the logic behind it.

Good luck 🙂

EDIT: I had some free time and I rechecked your code, why are you dividing by $sum, when $sum being a recordset??

[dcav]

Now this works fine in phpmyadmin but when used in conjunction with the rest of my code it doesn't work as intended. Instead of returning the sum of the rows pertaining to that particular column it returns the total number of rows.

That's because the coding behind myphpadmin use your query as a variable to fill it in their query and perform and output it correctly. If you do it correctly, then the code I posted previously should work.

[iceman2g]

I'm dividing by $sum because it's suppose to be the sum of poll_results. This total is 229.

I'm using this code to do that.

$sum = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = '$id'");

[dcav]

Create a blank page and put the code the i posted 2 or 3 posts earlier. Run it and see if it gives the result you are looking for. And obviously, you just connect to mysql first.

[iceman2g]

Didn't give me a result.

[iceman2g]

well it's working now. Here's the code i'm using.

$results = mysql_query("SELECT poll_option_text, poll_results FROM store_poll_options 
WHERE poll_id = '3' ORDER BY poll_results DESC ");
if ($results)


while ($row = mysql_fetch_assoc($results))
			{
$sum = mysql_query("SELECT SUM(poll_results) FROM store_poll_options WHERE poll_id = '3'");           

$sum = mysql_fetch_assoc($sum); 

$poll_result = $row['poll_results'] / $sum['SUM(poll_results)'] * 100 ;  

$poll_option = $row['poll_option_text'];   

echo"$poll_option<br>";   

echo"$poll_result<br>";
				}

Do you know how i'd round it off currently i'm gettin 27.0742358079.

[dcav]

Do you know how i'd round it off currently i'm gettin 27.0742358079.

You can round it with:
ceil(27.0742358079), which equals to 28
or
round(27.0742358079), which equals to 27

Refer to the php manual.
CEIL:http://ca2.php.net/manual/en/function.ceil.php
ROUND: http://ca2.php.net/manual/en/function.round.php

If you are still learning PHP, you SHOULD learn how to consult the manual for simple tasks such as CEIL and ROUND

On a side note:
You've said before that you were supposed to get 229, so my code was just to get you that number that you queried in myphpadmin.

[iceman2g]

Thank you for that.

One final question though do I have to use js to refresh page or can I use php.

What I mean is when the results are shown i'd like it to visible of the index page right it takes me to the polls.php page.

Here's poll on the inxde page before clicking vote:

Now here's the poll result after vote has been clicked.

I'm trying to figure out how i'd get it to display result of index page when vote is clicked.

Edit: About the php manually I often have trouble finding things. Whenever I search using keywords it returns nothing pertaining to what i'm looking for.

[dcav]

You could do this,
In the action tag of your form, just send your results to:
example: index.php?poll=12&cmd=poll_results

In your index.php
you can do something like:

if ($_GET[cmd] == "poll_results") {
showResults();
}
else {
showThePoll();
}

I assumed that's similar to what you did in your polls.php, you just have to do it the same way and insert it to the proper block in your index page. In your case, the <div> that holds your POLL...

[iceman2g]

Thank you i'll try that out.

[iceman2g]

Yeah tryed it made the changes but it still takes me to the polls.php were the results are then displayed.

[dcav]

What will be your next socket upgrade?<form method="get" action="polls.php">

You didn't change it.

[iceman2g]

Sorry my fault I posted old pic. Method has been changed to post, I was using get to see the info in ie bar. But yeah it's working now. Right now i'm going to try and set up some cookies so that individuals may only vote once.