Function Help

JohnN4

Im making a encoding switcher, but i have an error in the script, and i don't know how to fix it.....I am using the variable $site_encoding to switch between a WML encoding function and a XHTML encoding fucntion...the thing is, i have the headers and footers as functions, and i need to call them inside another function.......see here:

<?

$site_encoding = 'WML';

//================================//
//     Site Encoding Switcher     //
//================================//

function opentable() {
        if ($site_encoding=='XHTML') { $xhtml_header }
        elseif ($site_encoding=='WML') { $wml_header }
        else { $wml_header }

}

function closetable() {
	if ($site_encoding=='XHTML') { $xhtml_footer } 
        elseif ($site_encoding=='WML') { $wml_footer }
        else { $wml_footer }
}

//================================//
//           WML Header           //
//================================//

$WML_Header = WML_Header();

function WML_Header() {
header('Content-type: text/vnd.wap.wml');
echo '<?xml version="1.0"?>';
print<<<_WML_

<!DOCTYPE wml PUBLIC "-//WAPFORUM//DTD WML 1.1//EN" "http://www.wapforum.org/DTD/wml_1.1.xml">
<wml>
<head>
<meta forua="true" http-equiv="Cache-Control" content="max-age=0"/>
</head>
_WML_;
}

//================================//
//           WML Footer           //
//================================//

$wml_footer = $wml_footer();

function $wml_footer() {
print<<<_WML_
</card>
</wml>

_WML_;
}

//================================//
//          XHTML Header          //
//================================//

$XHTML_Header = XHTML_Header();

function XHTML_Header() {
echo '<?xml version="1.0" encoding="ISO-8859-1"?>';
print<<<_XHTML_

<!DOCTYPE html PUBLIC "-//WAPFORUM//DTD XHTML Mobile 1.0//EN"
	"http://www.wapforum.org/DTD/xhtml-mobile10.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
_XHTML_;
}


//================================//
//          XHTML Footer          //
//================================//

$XHTML_Footer = XHTML_Footer();

function XHTML_Footer() {
print<<<_XHTML_
</body>
</html>

_XHTML_;
}

?>

What is wrong with it? Is there a way to make that script work in this way?

BuzzLY

So... why not just do this:

function opentable() {
    switch ($site_encoding) {
        case "XHTML":
            XHTML_header();
            break;
        case "WML":
        default:
            WML_header();
            break;
    }
}

Obviously, do the same thing for your footers.

As far as using variables for function names, you can do this. However, if I'm not mistaken, here is how:

function do_this() {
    echo "hello world";
}

 // this is the wrong way...

$my_function = "do_this()";
$my_function;

// this is the correct way (I think -- someone correct if I am wrong)...

$my_function = "do_this";
$my_function();

JohnN4

Thanks for the help man, ill try it.

JohnN4

Dude, try this out, i did what you instructed, but when i change the $site_encoding to XHTML, it still shows the wml....

look:

<?

$site_encoding = 'XHTML';

opentable();
closetable();

//================================//
//     Site Encoding Switcher     //
//================================//

function opentable() {
    switch ($site_encoding) {
        case 'XHTML':
            XHTML_header();
            break;
        case 'WML':
        default:
            WML_header();
            break;
    }
}

function closetable() {
    switch ($site_encoding) {
        case 'XHTML':
            XHTML_footer();
            break;
        case 'WML':
        default:
            WML_footer();
            break;
    }
}

//================================//
//           WML Header           //
//================================//

function WML_Header() {
header('Content-type: text/vnd.wap.wml');
echo '<?xml version="1.0"?>';
print<<<_WML_

<!DOCTYPE wml PUBLIC "-//WAPFORUM//DTD WML 1.1//EN" "http://www.wapforum.org/DTD/wml_1.1.xml">
<wml>
<head>
<meta forua="true" http-equiv="Cache-Control" content="max-age=0"/>
</head>
_WML_;
}

//================================//
//           WML Footer           //
//================================//

function WML_footer() {
print<<<_WML_
</card>
</wml>

_WML_;
}

//================================//
//          XHTML Header          //
//================================//

function XHTML_Header() {
echo '<?xml version="1.0" encoding="ISO-8859-1"?>';
print<<<_XHTML_

<!DOCTYPE html PUBLIC "-//WAPFORUM//DTD XHTML Mobile 1.0//EN"
	"http://www.wapforum.org/DTD/xhtml-mobile10.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
_XHTML_;
}


//================================//
//          XHTML Footer          //
//================================//

function XHTML_Footer() {
print<<<_XHTML_
</body>
</html>

_XHTML_;
}

?>

BuzzLY

inside your functions, you need to put:

[FONT=courier new]global $site_encoding;[/FONT]

So that each function can use the variable.

JohnN4

Thanks man, it really helped...sorry for being such a noob.