A simple delete script? What's going on here?

lukatchikm

I am in a situation where I have an established database called COUNTY_DIRECTORY, and within that database, a table called EMPLOYEE_INFO that contains all record fields. Thus far, I am able to add new records and update existing records. In the event that a profile needs to be deleted, I have used the following code to delete the specified profile. A form passes the first name and last name to the PHP script (below), which should then query the database, and finally delete the record. My problem is, the record is not getting deleted. It is hanging up on the "Information can not be deleted - contact your administrator error message'...Obviously, there is an error in my syntax, but I am not spotting it. Can anyone offer any suggestions?

<?php

$conn = @mysql_connect("localhost","michael","password")
or die("Could not connect to MySQL Report this error to your <a href='mailto:me@luzernecounty.org'>system administratior</a> now!");

$bd = @mysql_select_db("COUNTY_DIRECTORY",$conn)
or die("Could not select database. Report this error to your <a href='mailto:me.@luzernecounty.org'>system administratior</a> now!");

$sql = "(DELETE * from EMPLOYEE_INFO where f_name=\"$firstname\" AND l_name=\"$lastname\" )";

$result = @($sql,$conn)
or die("Could not delete information! Report this error to your <a href='mailto:me@luzernecounty.org'>system administratior</a> now!");

if ($result) { echo (" <h2>Profile for $firstname $lastname deleted!</h2> 
Click <a href='admin_delete.htm'>HERE</a> to delete another employee profile. Click <a href='admin_edit_home.htm'>HERE</a> to return to administration home."); }

Thanks in advance,

Mike
lukatchm@misericordia.edu

tommynanda

you shouldnt use * in DELETE .. here is a modified querry you may want to use

$sql = "(DELETE from EMPLOYEE_INFO where f_name=\"$firstname\" AND l_name=\"$lastname\" )";

That'll do the job

on a side note: Use mysql_error() to spot mysql errors

Good Luck
TommYNandA

lukatchikm

Hmmm....I gave it a shot, and it is still deverting to that error message...I'm simply passing two variables, firstname, and lastname, to the PHP script. By the way of my syntax, it should be able to do its thing....I'm baffled on why it keeps going back to that error message...Please help if anyone else has any other suggestions...Thanks in advance, Mike

LordShryku

Three points:
1) Don't surround your query with parens. They have no use and are probably your problem.
2) Use single quotes around query values. It's the ANSI standard.
3) Use [man]mysql_error[/man] instead of custom errors when debugging. When it bombs, it'll tell you why.

lukatchikm

Thanks for all of your help so far...

I am at a point where the firstname and lastname are being accepted, and the script is now telling me records are being deleted.

BUT

when I check my phpMyAdmin to verify the deletion of the record, it's still sitting there in my database....

I'm getting closer, and if you guys have anymore suggestions, I'd like to hear from you...

<?php

$conn = @mysql_connect("localhost","michael","password")
or die("Error Connecting: " .mysql_error());

$db = @mysql_select_db("COUNTY_DIRECTORY",$conn)
or die("Error Selecting Database: " .mysql_error());

$sql = 'DELETE from EMPLOYEE_INFO where f_name=\'$firstname\' and l_name=\'$lastname\' ';

$result = @($sql,$conn)
or die("Error: " .mysql_error());

morphius


$sql = "DELETE from EMPLOYEE_INFO where f_name='$firstname' and l_name='$lastname' ;";

mattvenables

right, you should use double quotes around query strings, but only the single quotaion mark around the query values...

morphius

By the way if l_name and f_name from a previous form by what method are you calling it .... i mean is it $_POST['l_name'] .....?

lukatchikm

Thanks once again...I'm passing the variables over through a simple html form...

The user enters a first name and a last name, and I'm not using the $_POST method....

I'll give a shot at the last few sugestions, and we'll see what happens next.

-Mike

lukatchikm

Back in Business. Thanks for everyone's help!!! This discussion is resolved.

Cheers!!!!