[Resolved] [Resolved] String containing relative URL

[vikette]

Hi all,

I am using in includes file to hold the code for an array of random images - which need to appear in various places in the web site. The code works perfectly IF the file which is calling the includes is in the ROOT. If I call the includes from another directory, the includes comes in but the link to the image is broken.

Includes ...

require_once('../includes/randomImages.php');

In the includes, the imgPath is specified as "gallery/folder1"

trying to print Image 0

<?php print( "<IMG SRC=\"../" . \"$imgpath[0]/" . $imgArray[0][ $randval[0] ] . "\">" );?>

trying to print Image 1

<?php print( "<IMG SRC=\"$imgpath[1]/" . $imgArray[1][ $randval[1] ] . "\">" );?>

The result is that they both write the correct path into the HTML (as I specified), but the image name itself isn't appended.

eg. image 1 will print:
IMG SRC="../gallery/mbh/"

image 2 will print:

IMG SRC="gallery/fg/"

Bit of a newbie, be gentle.

[vikette]

I also tried using both an absolute and a root-relative url in the includes file itself. Didn't work at all, even where it had worked previously.

$imgpath[0] = "http://www.bio.uib.no/bms/gallery/mbh";

[TheDefender]

You said the path is right, is that correct? My question is since the image name won't read correctly, we need to look there... Where and how is this part of the code being generated?
$imgArray[0][ $randval[0] ]

I assume your arrays are looking in some directory called from the directory the include is in? If that's the case, you need to look at how you have the paths defined there.

[vikette]

The directory is structured like this. Actually, I technically don't have access to the root of the web. I work in a folder called bms.

/bms/index.php
/bms/includes/randomImage.php
/bms/gallery/folder1/(bunch of images)
/bms/gallery/folder2/(bunch of images) etc.
/bms/test.php - gets include, renders images correctly
/bms/test/test.php - same code, messes up images

Below is the code from the includes file:

$imgpath = array();
$imgArray = array(); 
$randval = array();
$TotalImages = 9; // Total number of gallery folders

$imgpath[0] = "gallery/mbh";
$imgpath[1] = "gallery/fg";
$imgpath[2] = "gallery/eco";
$imgpath[3] = "gallery/rm";
$imgpath[4] = "gallery/fish";
$imgpath[5] = "gallery/bio";
$imgpath[6] = "gallery/climate";
$imgpath[7] = "gallery/geo";
$imgpath[8] = "gallery/petrol";

for ($i=0; $i<$TotalImages; $i++) {
	$handle= opendir( "$imgpath[$i]");
	$imgArray[$i] = array(); 
	while($file = readdir($handle)){
    	if( $file != "." && $file != ".." ){
        	array_push( $imgArray[$i], $file );
    	}
	}
	closedir( $handle );
}

mt_srand( (double)microtime( ) * 1000000 );  // Random number initializer

for ($i=0; $i<$TotalImages; $i++) {
	$randval[$i] = mt_rand( 0, sizeof( $imgArray[$i] ) - 1 );
}

[TheDefender]

OK, I believe the problem is because your image array is being set relative to the path structure from within the included file...

So in other words, this:
$imgpath[0] = "gallery/mbh";

when processed in your FOR loop is looking here:
/bms/includes/gallery/mbh

and of course, there are no images there... Try this in your includes file:

In your FOR loop, add the "../" to the path name. Don't hard set it in each imgpath definition, because you need to define the path without it in your original file, since the path is relative to that.

for ($i=0; $i<$TotalImages; $i++) { 
    $imgpath[$i] = "../".$imgpath[$i]; // Add this to the loop
    $handle= opendir( "$imgpath[$i]"); 
    $imgArray[$i] = array();  

    while($file = readdir($handle)){ 
        if( $file != "." && $file != ".." ){ 
            array_push( $imgArray[$i], $file ); 
        } 
    } 
    closedir( $handle ); 
}

In your original file, your call would be:

<?php print( "<IMG SRC=\"$imgpath[1]/" . $imgArray[1][ $randval[1] ] . "\">" );?> 

I hope this makes sense, and works for you. Good Luck with it.

[vikette]

Er, sorry. The resulting HTML source reads:
<IMG SRC="/"> from all locations.

[TheDefender]

OK, I doublechecked it all in a simulated test environment, and the first bit I gave you should work, when you include the i in the LOOP (on the line I advised you to add). I corrected the code above, so make it look like this, and it should work for you:

for ($i=0; $i<$TotalImages; $i++) {
    $imgpath[$i] = "../".$imgpath[$i]; // Add this to the loop
    $handle= opendir( "$imgpath[$i]");
    $imgArray[$i] = array();
    while($file = readdir($handle)){
        if( $file != "." && $file != ".." ){
            array_push( $imgArray[$i], $file );
        }
    }
    closedir( $handle );
}

Sorry about the confusion...

[vikette]

I would call that a success!

It now works for the files down one level but not in the root - I guess it has no way to tell where it is. However, only the index.php in the "root" which will use the random images, so I can just paste in the initial code for that. Meanwhile, I can use your modifications for the rest of the pages needing random images. I understand now how to adjust it if needed.

Thank you! (and try not to think of coding while driving to work - I'm sure my Mom would say that causes blindness or something).

[TheDefender]

LOL... Got nothing else to do when traffic is jammed up on the highway. 😉, and the radio is on commercial break...

<< Note to self, invest in a satellite radio system for the car >>