Not inserting into mysql

pinehead18


	        if (isset($_POST['submit'])) {

					$date = date("l, M, d");

			        $con = mysql_connect("localhost","pinehead","") or die(mysql_error());
                    $db = mysql_select_db("lkcforum",$con) or die(mysql_error());

			$sql = "SELECT tid FROM threads ORDER by tid DESC";
			$result = mysql_query($sql,$con) or die(mysql_error());
			$row = mysql_fetch_array($result) or die(mysql_error());			

			   if (!isset($row['tid'])) { $last_id = $row['id']; } else { $last_id = "0"; }

			     $newid = $last_id + 1;


		$sql = "INSERT INTO threads (tid,topic,uname,body,forum_id,topic_id,date) VALUES ('$newid','$topic','$name','$body','$fid','1','$date')";
        mysql_query($sql,$con) or die(mysql_error());
        mysql_close();
	 	echo $sql;

                }

Ok, this is my code, here is what is happening. Whenever their is 1 or more rows in the table threads everything works just fine. However, if their are 0 rows in the table then it just goes to a white blank screen. Will not echo sql or anything that i try to tell it to do. But when their is 1 or more rows already in the table it all works fine.

Any ideas? Thank you
Anthony
P.S This is just the insert of a new thread in my mini forums for my site.

tsinka

Hi,

did you copy'n'paste the code ?

Besides that you might want to put

ini_set("error_reporting",E_ALL);

on top of the script. Maybe an error that doesn't get displayed because of the error_reporting setting.

The following line seems to contain errors:

if (!isset($row['tid'])) { $last_id = $row['id']; } else { $last_id = "0"; }

If $row['tid'] isn't set you try to use $row['id']. Two errors in one line ...

First it should be

if (isset($row['tid'])) .....

and it should be

$last_id = $row['tid'];

instead of

$last_id = $row['id'];

Do you see a mysql error message if you view the source of the page in the browser ?

Thomas

planetsim

Why are you creating the ID on the fly. Why isnt your database ID set up as Primary Key auto_increment?

pinehead18

I'm creating the id so i can tie together the topics and the threads all in one db.

Any ideas/

devinemke

Originally posted by pinehead18
I'm creating the id so i can tie together the topics and the threads all in one db.

...this is a bad idea, you should really be using [man]mysql_insert_id[/man]

pinehead18

what part is a bad idea?

pinehead18

my bad i do have tid set to auto increment. But i'm also still having that problem.

pinehead18

I remember why i had it like that. See i have a new thread write to the threads db. Then i have post reply write to the threads db but i want to assign it the same tid as the newthread but i keep getting

Duplicate entry '2' for key 1

Any better ways of doing this?

Thank you for your patients.

Anthony

tsinka

Hi,

there are several ways to solve that problem. Here are two of them:

1.
add a column to the table called e.g. parentid or something like that.

If someone starts a new thread you insert the data with parentid=0.
If someone replies to a post you insert the data with parentid=auto_increment_id_of_starter_thread

You could then first create a list of all threads by selecting all rows with parentid=0. To get all replies to a specific thread fetch all rows with parentid=auto_id_of_thread.

2.
split the data. Have one table containing the threads and one table containing the replies to that thread.

There are other ways to do this but what to do depends on the way your forum(s) work.

Thomas