[Resolved] Images wont display

[erikhillis]

Here is my code... my problem is that no images are being displayed on my page 🙁

http://jops.xwargames.net/screenshots.php

$i=1;

echo "<table border=0 bgcolor=#000000 cellspacing=1 cellpadding=0 align=Center>";


while ($rows = mysql_fetch_row($result))
{

if ($i == '0')
print "<tr>";

if ($i == '4')
print "<tr>";

if ($i == '8')
print "<tr>";

if ($i == '12')
print "<tr>";

if ($i == '16')
print "<tr>";

if ($i == '20')
print "<tr>";

echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image=$rows[1]'><img border= '0' src= '$rows[1]' width= '115' height= '87'></a></td>";

$i++;

}

echo "</tr></table>";

[zapa]

try....

echo '<td><a href="http://jops.xwargames.net/screenshot.php?image='.$rows[1].'"><img border="0" src="'.$rows[1].'" width="115" height="87"></a></td>'; 

insted of

 echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image=$rows[1]'><img border= '0' src= '$rows[1]' width= '115' height= '87'></a></td>"; 

what you got know would show up as

<IMG SRC=$rows[1]'> in html and $rows[1]' is not a image name so thats why it wasnt show up

if you change IMG SRC="$rows[1]" then it would work

when useing '$rows[1]' = $rows[1]' but "$rows[1]" would echo veribale

[erikhillis]

I replaced it, but it didn't seem to do anything? 🙁 Any other ideas?

[planetsim]

Im a little curious about this code

if ($i == '0')
print "<tr>";

if ($i == '4')
print "<tr>";

if ($i == '8')
print "<tr>";

if ($i == '12')
print "<tr>";

if ($i == '16')
print "<tr>";

if ($i == '20') 

Why not do something like this

  if (!($i%4)) 
  echo "<tr>";

[zapa]

yes,

check this...
you table code, i think it could be table code that is not showing the images.. I dont see a </TR> close tag for all teh TR open tags you got.

do a image test by

trying to show a image outside table code.

any i am guess you $result is linked to a SELECT right?

[erikhillis]

Originally posted by planetsim
Im a little curious about this code

if ($i == '0')
print "<tr>";

if ($i == '4')
print "<tr>";

if ($i == '8')
print "<tr>";

if ($i == '12')
print "<tr>";

if ($i == '16')
print "<tr>";

if ($i == '20') 

Why not do something like this

  if (!($i%4)) 
  echo "<tr>";

[/B]

Thanks

Tried that, but didn't help.

[zapa]

close the </TR> tag and i am betting it would work 🙂

[erikhillis]

Originally posted by zapa
yes,


check this...
you table code, i think it could be table code that is not showing the images.. I dont see a </TR> close tag for all teh TR open tags you got.

do a image test by

trying to show a image outside table code.


any i am guess you $result is linked to a SELECT right?

Here is my current full code... this may help:

<?php  

$db = mysql_connect("localhost","xwg_jops","---"); 
mysql_select_db (xwg_jops); 

if(!isset($_GET['page'])){  

    $page = 1;  

} else {  

    $page = $_GET['page'];  

}  

$max_results = 20;  

$from = (($page * $max_results) - $max_results);  

$sql = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $from, $max_results");  

$i=1;

echo "<table border=0 bgcolor=#000000 cellspacing=1 cellpadding=0 align=Center>";


while ($rows = mysql_fetch_row($result))
{

if (!($i%4))  

  echo "<tr>";

echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image={$row['url']}'><img border= '0' src= '{$row['url']}' width= '115' height= '87'></a></td>";

$i++;

}

echo "</tr></table>";



$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM screenshots"),0);  

$total_pages = ceil($total_results / $max_results);  

echo "<font face=Verdana size=1 color=818562><br><B>Select a Page</B><br /><font face=Verdana size=1 color=FFFFFF>";  

if($page > 1){  

    $prev = ($page - 1);  

    echo "<a href=\"screenshots.php?page=$prev\"><font face=Verdana size=1 color=818562><B>«</B><Previous</a>&nbsp;";  

}  

for($i = 1; $i <= $total_pages; $i++){ 
    if(($page) == $i){  

        echo "$i&nbsp;";  

        } else {  

            echo "<a href=\"screenshots.php?page=$i\">$i</a>&nbsp;";  

    }  

}  

if($page < $total_pages){  

    $next = ($page + 1);  

    echo "<a href=\"archive.php?page=$next\">Next&nbsp;<font face=Verdana size=1 color=818562><B>»</B></a>";  

}  

?> 

[zapa]

while ($rows = mysql_fetch_row($result))

i dont see $result any place on the code

could ment to use ?
$sql = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $from, $max_results");

[erikhillis]

With the following code, it shows 1 image with a dead url.

http://jops.xwargames.net/screenshots.php

$max_results = 20;  

$from = (($page * $max_results) - $max_results);  

$sql = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $from, $max_results");

$i=1;

echo "<table border=0 bgcolor=#000000 cellspacing=1 cellpadding=0 align=Center>";

if (!($i%4))  

  echo "<tr>";

echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image=$row[url]'><img border= '0' src= '$row[url]' width= '115' height= '87'></a></td>";

$i++;

echo "</tr></table>";

[zapa]

use $from is bad name choice. because sql use from already.

$sql = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $from, $max_results");

if you use any word liek $select $insert $update then use with it.
example....$from`

again the reson you get one image could be BCAUSE YOU <TR> TAG ARE NOT CLOSE IN THE MIDDEL like i said 3 times already!

try something like this to close your tr tags like you are closing them at start and end ofyou table.

next time if you post you better have them TR tags closed or i will not replay to this post hehe

if (!($i%4))

echo "</tr><tr>";

[tsinka]

Hi,

one exception here:

If $i==0 you only need <tr> since it is the first row

if (!($i%4))
echo ($i!=0 ? "</tr>" : "")."<tr>";

Thomas

[erikhillis]

This isn't working... does anyone have a better way to get 4 images in a line, then 4 on the next? :queasy:

[tsinka]

How does your code like now ?

Thomas

[erikhillis]

<?php  

$db = mysql_connect("localhost","---","---"); 
mysql_select_db (---); 

if(!isset($_GET['page'])){  

    $page = 1;  

} else {  

    $page = $_GET['page'];  

}  

$max_results = 20;  

$from = (($page * $max_results) - $max_results);  

$sql = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $from, $max_results");

$i=4;

echo "<table border=0 bgcolor=#000000 cellspacing=1 cellpadding=0 align=Center>";

if (!($i%4))  

  echo "<tr>";

echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image=$row[url]'><img border= '0' src= '$row[url]' width= '115' height= '87'></a></td>";

if (!($i%4))  

echo "</tr><tr>";

$i++;


echo "</table>";

$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM screenshots"),0);  

$total_pages = ceil($total_results / $max_results);  

echo "<font face=Verdana size=1 color=818562><br><B>Select a Page</B><br /><font face=Verdana size=1 color=FFFFFF>";  

if($page > 1){  

    $prev = ($page - 1);  

    echo "<a href=\"screenshots.php?page=$prev\"><font face=Verdana size=1 color=818562><B>«</B><Previous</a>&nbsp;";  

}  

for($i = 1; $i <= $total_pages; $i++){ 
    if(($page) == $i){  

        echo "$i&nbsp;";  

        } else {  

            echo "<a href=\"screenshots.php?page=$i\">$i</a>&nbsp;";  

    }  

}  

if($page < $total_pages){  

    $next = ($page + 1);  

    echo "<a href=\"archive.php?page=$next\">Next&nbsp;<font face=Verdana size=1 color=818562><B>»</B></a>";  

}  

?> 

[tsinka]

Hi,

the while loop is missing ...

hmmmm, I could swear that I know this code from somewhere ...
looks familiar to me ... from another thread ...

<?php   

$db = mysql_connect("localhost","---","---");  

mysql_select_db (---);  


$page = isset($_GET['page']) ? $_GET['page'] : 1;

$max_results = 20;   

$start = (($page * $max_results) - $max_results);   

$res = mysql_query("SELECT * FROM screenshots order by id asc LIMIT $start, $max_results") or die("SQL error: ".mysql_error()); 

$i=0; 

if (mysql_num_rows($res) > 0) {
  echo "<table border='0' bgcolor='#000000' cellspacing='1' cellpadding='0' align='center'>"; 
  while ($row = mysql_fetch_assoc($res)) {
    if (!($i%4))   

      echo ($i!=0 ? "</tr>" : "")."<tr>"; 

echo "<td><a href= 'http://jops.xwargames.net/screenshot.php?image="
    .urlencode($row['url'])
    ."'><img border= '0' src= '"
    .$row['url']
    ."' width='115' height='87' border='0'></a></td>\n"; 
$i++; 
  }

  // finish row if neccessary
  for ($cnt=$i;$cnt%4>0;$cnt++)
    echo "<td>&nbsp;</td>";

  echo "</tr></table>"; 

  $total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM screenshots"),0) or die("SQL error: ".mysql_error());   

  $total_pages = ceil($total_results / $max_results);   

  echo "<font face=Verdana size=1 color=818562><br><B>Select a Page</B><br /><font face=Verdana size=1 color=FFFFFF>";   

  if($page > 1){   

    $prev = ($page - 1);   

    echo "<a href=\"screenshots.php?page=$prev\"><font face=Verdana size=1 color=818562><B>«</B><Previous</a>&nbsp;";   

  }   

  for($i = 1; $i <= $total_pages; $i++){  

    if(($page) == $i){   

        echo "$i&nbsp;";   

        } else {   

            echo "<a href=\"screenshots.php?page=$i\">$i</a>&nbsp;";   

    }   

  }   

  if($page < $total_pages){   

    $next = ($page + 1);
    echo "<a href=\"archive.php?page=$next\">Next&nbsp;<font face=Verdana size=1 color=818562><B>»</B></a>";   

  }   

} else {
  echo "Sorry, no pics...";
}
?>  

This should work ...

Thomas

[erikhillis]

Yep, thats it 😉

Thanks alot for your help Thomas